From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: outdated documentation for lp5523 LED driver?
Date: Fri, 15 Jul 2016 09:40:52 +0200 [thread overview]
Message-ID: <20160715074052.GE29844@pali> (raw)
In-Reply-To: <20160715073214.GC13429@amd>
On Friday 15 July 2016 09:32:14 Pavel Machek wrote:
> Hi!
>
> Documentation says that load/leds are only visible in the load mode,
> but that does not seem to be true (kernel 4.4.0 on N900).
>
> # 1) Legacy interface - enginex_mode, enginex_load and enginex_leds
> # Control interface for the engines:
> # x is 1 .. 3
> # enginex_mode : disabled, load, run
> # enginex_load : microcode load (visible only in load mode)
> # enginex_leds : led mux control (visible only in load mode)
>
> pavel at n900:/sys/class/leds/lp5523:r/device$ ls -al engine*
> -rw-r--r-- 1 root root 4096 Jul 6 22:47 engine1_leds
> --w------- 1 root root 4096 Jul 6 22:47 engine1_load
> -rw-r--r-- 1 root root 4096 Jul 6 23:41 engine1_mode
> -rw-r--r-- 1 root root 4096 Jul 6 22:47 engine2_leds
> --w------- 1 root root 4096 Jul 6 22:47 engine2_load
> -rw-r--r-- 1 root root 4096 Jul 6 23:41 engine2_mode
> -rw-r--r-- 1 root root 4096 Jul 6 22:47 engine3_leds
> --w------- 1 root root 4096 Jul 6 22:47 engine3_load
> -rw-r--r-- 1 root root 4096 Jul 6 22:47 engine3_mode
> pavel at n900:/sys/class/leds/lp5523:r/device$ grep . engine*mode
> engine1_mode:run
> engine2_mode:load
> engine3_mode:run
> pavel at n900:/sys/class/leds/lp5523:r/device$
On 2.6.28 kernel is present only legacy interface and for this version
is above documentation correct. When engine is in "run" or "disabled",
then sysfs nodes _load and _leds are invisible.
So I suspect that bug is in current kernel code and documentation is
correct... So I would propose to fix kernel code to reflect
documentation...
> I got both the legacy and the firmware interface to work... but the
> firmware interface only seems to work once for me.
>
> How new and old interface are expected to interact with each other is
> not clear to me.
In my opinion both interfaces could be used. They provide same states
load/run but via different sysfs files.
> What should be done there?
>
> Best regards,
> Pavel
>
--
Pali Roh?r
pali.rohar at gmail.com
next prev parent reply other threads:[~2016-07-15 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 7:32 outdated documentation for lp5523 LED driver? Pavel Machek
2016-07-15 7:40 ` Pali Rohár [this message]
2016-07-15 8:54 ` Pavel Machek
2016-07-15 9:01 ` Pali Rohár
2016-07-15 9:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715074052.GE29844@pali \
--to=pali.rohar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).