From: matt@codeblueprint.co.uk (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] efi: esrt: use memremap not ioremap to access ESRT table in memory
Date: Fri, 15 Jul 2016 16:05:53 +0100 [thread overview]
Message-ID: <20160715150553.GD2406@codeblueprint.co.uk> (raw)
In-Reply-To: <1468263646-28184-2-git-send-email-ard.biesheuvel@linaro.org>
On Mon, 11 Jul, at 09:00:45PM, Ard Biesheuvel wrote:
> On ARM and arm64, ioremap() and memremap() are not interchangeable like
> on x86, and the use of ioremap() on ordinary RAM is typically flagged
> as an error if the memory region being mapped is also covered by the
> linear mapping, since that would lead to aliases with conflicting
> cacheability attributes.
>
> Since what we are dealing with is not an I/O region with side effects,
> using ioremap() here is arguably incorrect anyway, so let's replace
> it with memremap() instead.
>
> Acked-by: Peter Jones <pjones@redhat.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/firmware/efi/esrt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Looks sensible, thanks Ard, applied.
next prev parent reply other threads:[~2016-07-15 15:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 19:00 [PATCH v2 0/2] efi/arm*: wire up ESRT table Ard Biesheuvel
2016-07-11 19:00 ` [PATCH v2 1/2] efi: esrt: use memremap not ioremap to access ESRT table in memory Ard Biesheuvel
2016-07-15 15:05 ` Matt Fleming [this message]
2016-07-11 19:00 ` [PATCH v2 2/2] efi/arm*: esrt: add missing call to efi_esrt_init() Ard Biesheuvel
2016-07-15 15:22 ` Matt Fleming
-- strict thread matches above, loose matches on Subject: below --
2016-02-15 11:32 [PATCH v2 0/2] efi: ARM/arm64: wire up ESRT table Ard Biesheuvel
2016-02-15 11:32 ` [PATCH v2 1/2] efi: esrt: use memremap not ioremap to access ESRT table in memory Ard Biesheuvel
2016-02-15 15:45 ` Peter Jones
2016-02-16 19:19 ` Baicar, Tyler
2016-02-18 10:44 ` Matt Fleming
2016-02-18 12:16 ` Ard Biesheuvel
2016-02-18 13:28 ` Matt Fleming
2016-02-18 13:29 ` Ard Biesheuvel
2016-02-18 13:43 ` Matt Fleming
2016-02-18 13:44 ` Ard Biesheuvel
2016-02-18 14:15 ` Matt Fleming
2016-02-18 14:21 ` Ard Biesheuvel
2016-02-18 14:38 ` Matt Fleming
2016-02-19 9:27 ` Dave Young
2016-02-18 19:16 ` Peter Jones
2016-02-26 14:41 ` Matt Fleming
2016-03-01 23:30 ` Matt Fleming
2016-03-01 23:31 ` Matt Fleming
2016-03-02 1:16 ` Dave Young
2016-03-02 10:23 ` Matt Fleming
2016-03-04 6:25 ` Dave Young
2016-05-18 8:36 ` Ard Biesheuvel
2016-05-18 8:53 ` Matt Fleming
2016-06-16 13:47 ` Ard Biesheuvel
2016-06-20 11:49 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715150553.GD2406@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).