From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] mfd: add support for Allwinner SoCs ADC
Date: Thu, 21 Jul 2016 13:12:53 +0100 [thread overview]
Message-ID: <20160721121253.GE14925@dell> (raw)
In-Reply-To: <d64cf632-41a4-3e23-6239-7f854cbb0293@kernel.org>
On Wed, 20 Jul 2016, Jonathan Cameron wrote:
> On 19/07/16 08:31, Lee Jones wrote:
> > On Mon, 18 Jul 2016, Jonathan Cameron wrote:
> >
> >> On 15/07/16 10:59, Quentin Schulz wrote:
> >>> The Allwinner SoCs all have an ADC that can also act as a touchscreen
> >>> controller and a thermal sensor. For now, only the ADC and the thermal
> >>> sensor drivers are probed by the MFD, the touchscreen controller support
> >>> will be added later.
> >>>
> >>> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> >> Hmm. Previous patch includes the header this one creates. Ordering issue?
> >> The depends kind of prevents build failures by ensuring that can't be built
> >> until this one is in place, but it is certainly an ugly way to do it.
> >>
> >> Few little bits innline.
> >>> ---
> >>>
> >>> v2:
> >>> - add license headers,
> >>> - reorder alphabetically includes,
> >>> - add SUNXI_GPADC_ prefixes for defines,
> >>>
> >>> drivers/mfd/Kconfig | 14 +++
> >>> drivers/mfd/Makefile | 2 +
> >>> drivers/mfd/sunxi-gpadc-mfd.c | 197 ++++++++++++++++++++++++++++++++++++
> >>> include/linux/mfd/sunxi-gpadc-mfd.h | 23 +++++
> >>> 4 files changed, 236 insertions(+)
> >>> create mode 100644 drivers/mfd/sunxi-gpadc-mfd.c
> >>> create mode 100644 include/linux/mfd/sunxi-gpadc-mfd.h
> >
> > [...]
> >
> >>> +static struct mfd_cell sun6i_gpadc_mfd_cells[] = {
> >>> + {
> >>> + .name = "sun6i-a31-gpadc-iio",
> >>> + .resources = adc_resources,
> >>> + .num_resources = ARRAY_SIZE(adc_resources),
> >>> + }, {
> >>> + .name = "iio_hwmon",
> >> I still really dislike using this to force the probe of that driver but
> >> kind of up to the hwmon / mfd guys on this.
> >
> > Can you at least say *why* you don't like it?
> It just feels odd to have an mfd child that isn't really dependent
> on the mfd hardware itself.
>
> Still if you are happy, mfd is your domain and my objections were
> as you probably noticed not that strong - or well described!)
>
> So I'm fine with this.
I see. So it's not actually part of the same IP/chip?
> > How else would it get probed?
> >
> >> I don't have any better suggestions though..
> >>> + },
> >>> +};
> >
> > [...]
> >
> >>> + if (ret) {
> >>> + dev_err(&pdev->dev, "failed to add MFD devices: %d\n", ret);
> >>> + regmap_del_irq_chip(irq, sunxi_gpadc_mfd_dev->regmap_irqc);
> >>> + return ret;
> >>> + }
> >>> +
> >>> + dev_info(&pdev->dev, "successfully loaded\n");
> >> Seems like noise to me, but not my subsystem :)
> >
> > Agreed, I don't allow this either.
> >
> > [...]
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-07-21 12:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 9:59 [PATCH v2 0/4] add support for Allwinner SoCs ADC Quentin Schulz
2016-07-15 9:59 ` [PATCH v2 1/4] hwmon: iio_hwmon: defer probe when no channel is found Quentin Schulz
2016-07-16 17:00 ` [v2,1/4] " Guenter Roeck
2016-07-18 10:02 ` Maxime Ripard
2016-07-18 13:29 ` Guenter Roeck
2016-07-15 9:59 ` [PATCH v2 2/4] iio: adc: add support for Allwinner SoCs ADC Quentin Schulz
2016-07-18 12:57 ` Maxime Ripard
2016-07-19 9:04 ` Quentin Schulz
2016-07-19 12:40 ` Maxime Ripard
2016-07-18 13:18 ` Jonathan Cameron
2016-07-19 8:33 ` Quentin Schulz
2016-07-20 14:57 ` Jonathan Cameron
2016-07-21 12:15 ` Quentin Schulz
2016-07-23 6:37 ` Jonathan Cameron
2016-07-20 12:37 ` Quentin Schulz
2016-07-20 14:15 ` Crt Mori
2016-07-20 14:59 ` Jonathan Cameron
2016-07-15 9:59 ` [PATCH v2 3/4] mfd: " Quentin Schulz
2016-07-18 13:02 ` Maxime Ripard
2016-07-19 12:04 ` Quentin Schulz
2016-07-18 13:25 ` Jonathan Cameron
2016-07-19 7:31 ` Lee Jones
2016-07-20 15:01 ` Jonathan Cameron
2016-07-21 12:12 ` Lee Jones [this message]
2016-07-21 20:08 ` Maxime Ripard
2016-07-22 13:55 ` Lee Jones
2016-07-23 6:42 ` Jonathan Cameron
2016-07-25 9:55 ` Maxime Ripard
2016-07-19 8:35 ` Quentin Schulz
2016-07-15 9:59 ` [PATCH v2 4/4] hwmon: iio: add label for channels read by iio_hwmon Quentin Schulz
2016-07-15 14:03 ` Guenter Roeck
2016-07-15 14:36 ` Quentin Schulz
2016-07-16 2:53 ` Guenter Roeck
2016-07-18 12:24 ` Jonathan Cameron
2016-07-19 6:55 ` Quentin Schulz
2016-07-20 14:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721121253.GE14925@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).