From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 06/12] drivers: net: xgene: Add backward compatibility
Date: Fri, 22 Jul 2016 05:52:37 +0800 [thread overview]
Message-ID: <201607220546.vhppFUlO%fengguang.wu@intel.com> (raw)
In-Reply-To: <1469084370-16781-7-git-send-email-isubramanian@apm.com>
Hi,
[auto build test WARNING on net-next/master]
[also build test WARNING on next-20160721]
[cannot apply to v4.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/drivers-net-xgene-Fix-module-crash-and-1G-hot-plug/20160722-005356
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 'xgene_enet_phy_connect':
>> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:834:22: warning: unused variable 'adev' [-Wunused-variable]
struct acpi_device *adev;
^
>> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:878:23: warning: 'phy_dev' may be used uninitialized in this function [-Wmaybe-uninitialized]
phy_dev->advertising = phy_dev->supported;
^
vim +/adev +834 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
828 int xgene_enet_phy_connect(struct net_device *ndev)
829 {
830 struct xgene_enet_pdata *pdata = netdev_priv(ndev);
831 struct device_node *np;
832 struct phy_device *phy_dev;
833 struct device *dev = &pdata->pdev->dev;
> 834 struct acpi_device *adev;
835 int i;
836
837 if (dev->of_node) {
838 for (i = 0 ; i < 2; i++) {
839 np = of_parse_phandle(dev->of_node, "phy-handle", i);
840 if (np)
841 break;
842 }
843
844 if (!np) {
845 netdev_dbg(ndev, "No phy-handle found in DT\n");
846 return -ENODEV;
847 }
848
849 phy_dev = of_phy_connect(ndev, np, &xgene_enet_adjust_link,
850 0, pdata->phy_mode);
851 if (!phy_dev) {
852 netdev_err(ndev, "Could not connect to PHY\n");
853 return -ENODEV;
854 }
855
856 pdata->phy_dev = phy_dev;
857 } else {
858 #ifdef CONFIG_ACPI
859 adev = acpi_phy_find_device(dev);
860 if (adev)
861 pdata->phy_dev = adev->driver_data;
862
863 phy_dev = pdata->phy_dev;
864
865 if (!phy_dev ||
866 phy_connect_direct(ndev, phy_dev, &xgene_enet_adjust_link,
867 pdata->phy_mode)) {
868 netdev_err(ndev, "Could not connect to PHY\n");
869 return -ENODEV;
870 }
871 #endif
872 }
873
874 pdata->phy_speed = SPEED_UNKNOWN;
875 phy_dev->supported &= ~SUPPORTED_10baseT_Half &
876 ~SUPPORTED_100baseT_Half &
877 ~SUPPORTED_1000baseT_Half;
> 878 phy_dev->advertising = phy_dev->supported;
879
880 return 0;
881 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/octet-stream
Size: 37043 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160722/4bc05e6d/attachment-0001.obj>
next prev parent reply other threads:[~2016-07-21 21:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 6:59 [PATCH v6 00/12] drivers: net: xgene: Fix module crash and 1G hot-plug Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 01/12] drivers: net: xgene: Separate set_speed from mac_init Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 02/12] drivers: net: xgene: Fix module unload crash - hw resource cleanup Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 03/12] drivers: net: xgene: Fix module unload crash - change sw sequence Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 04/12] drivers: net: xgene: Fix module unload crash - clkrst sequence Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 05/12] drivers: net: phy: xgene: Add MDIO driver Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 06/12] drivers: net: xgene: Add backward compatibility Iyappan Subramanian
2016-07-21 21:52 ` kbuild test robot [this message]
2016-07-21 6:59 ` [PATCH v6 07/12] drivers: net: xgene: Enable MDIO driver Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 08/12] drivers: net: xgene: Use exported functions Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 09/12] drivers: net: xgene: ethtool: Use phy_ethtool_gset and sset Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 10/12] dtb: xgene: Add MDIO node Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 11/12] Documentation: " Iyappan Subramanian
2016-07-21 22:01 ` Rob Herring
2016-07-21 22:31 ` Iyappan Subramanian
2016-07-21 6:59 ` [PATCH v6 12/12] MAINTAINERS: xgene: Add driver and documentation path Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201607220546.vhppFUlO%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).