From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback
Date: Fri, 19 Aug 2016 22:32:08 +0530 [thread overview]
Message-ID: <20160819170208.GC9343@localhost> (raw)
In-Reply-To: <37b059dcb67d1c83c2193acecef0ab96@codeaurora.org>
On Fri, Aug 19, 2016 at 07:13:43AM -0400, okaya at codeaurora.org wrote:
> On 2016-08-19 01:52, Vinod Koul wrote:
> >On Thu, Aug 18, 2016 at 11:48:52PM -0400, Sinan Kaya wrote:
> >>On 8/18/2016 11:42 PM, Vinod Koul wrote:
> >>> On Thu, Aug 18, 2016 at 11:26:28PM -0400, Sinan Kaya wrote:
> >>>> On 8/18/2016 10:48 PM, Vinod Koul wrote:
> >>>>>> Keep a size limited list with error cookies and flush them in terminate all?
> >>>>> I think so, terminate_all anyway cleans up the channel. Btw what is the
> >>>>> behaviour on error? Do you terminate or somthing else?
> >>>>>
> >>>>
> >>>> On error, I flush all outstanding transactions with an error code and I reset
> >>>> the channel. After the reset, the DMA channel is functional again. The client
> >>>> doesn't need to shutdown anything.
> >>>
> >>> You mean from the client context or driver?
> >>>
> >>
> >>The client doesn't need to call device_free_chan_resources and
> >>device_terminate_all
> >>to be specific. Client can certainly call these if it needs to
> >>but it is not
> >>required to recover the channel.
> >
> >You didn't answer my question!
> >
> >On error you said you flush, so who does that?
>
> This is done by the driver in interrupt context when an error
> interrupt is received. All transactions are posted and hw is reset.
Hmmm, waht about the txn which are pending? DO you clear them..?
--
~Vinod
next prev parent reply other threads:[~2016-08-19 17:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 2:57 [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback Sinan Kaya
2016-07-16 1:00 ` Sinan Kaya
2016-07-24 6:24 ` Vinod Koul
2016-07-25 14:19 ` Sinan Kaya
2016-08-04 12:55 ` Vinod Koul
2016-08-04 14:17 ` Sinan Kaya
2016-08-04 14:40 ` Russell King - ARM Linux
2016-08-04 15:27 ` Sinan Kaya
2016-08-04 15:38 ` Russell King - ARM Linux
2016-08-04 15:59 ` Lars-Peter Clausen
2016-08-08 9:08 ` Vinod Koul
2016-08-08 12:25 ` Lars-Peter Clausen
2016-08-10 17:23 ` Vinod Koul
2016-08-04 16:08 ` Sinan Kaya
2016-08-04 16:15 ` Lars-Peter Clausen
2016-08-05 6:32 ` Robert Jarzmik
2016-08-05 8:34 ` Lars-Peter Clausen
2016-08-05 15:17 ` Sinan Kaya
2016-08-08 9:02 ` Vinod Koul
2016-08-08 14:45 ` Sinan Kaya
2016-08-10 17:28 ` Vinod Koul
2016-08-10 17:31 ` Sinan Kaya
2016-08-19 2:48 ` Vinod Koul
2016-08-19 3:26 ` Sinan Kaya
2016-08-19 3:42 ` Vinod Koul
2016-08-19 3:48 ` Sinan Kaya
2016-08-19 5:52 ` Vinod Koul
2016-08-19 11:13 ` okaya at codeaurora.org
2016-08-19 17:02 ` Vinod Koul [this message]
2016-08-19 17:21 ` Sinan Kaya
2016-08-22 6:08 ` Vinod Koul
2016-08-22 13:27 ` Sinan Kaya
2016-08-22 17:00 ` Vinod Koul
2016-08-08 8:51 ` Vinod Koul
2016-08-08 12:10 ` okaya at codeaurora.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819170208.GC9343@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).