From: jens.wiklander@linaro.org (Jens Wiklander)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 2/4] tee: generic TEE subsystem
Date: Wed, 31 Aug 2016 14:47:45 +0200 [thread overview]
Message-ID: <20160831124744.GA25472@ermac> (raw)
In-Reply-To: <e08f821b-bf7c-be65-59a5-281aa3343cf4@ti.com>
On Tue, Aug 30, 2016 at 02:29:45PM -0500, Andrew F. Davis wrote:
> On 08/22/2016 08:00 AM, Jens Wiklander wrote:
> > +/*
> > + * Unprivileged devices in the in the lower half range and privileged
>
> ^^ in the in the
> [snip]
>
> > +
> > + rc = alloc_chrdev_region(&tee_devt, 0, TEE_NUM_DEVICES, "tee");
> > + if (rc < 0) {
>
> if (rc) ?
>
> [snip]
>
> > + * Memory allocated as global shared memory is automatically freed when the
> > + * TEE file pointer is closed. The @flags field uses the bits defined by
> > + * TEE_SHM_* above. TEE_SHM_MAPPED must currently always be set. If
>
> ^^^ not really above anymore, out of file now looks like
>
> > + * TEE_SHM_DMA_BUF global shared memory will be allocated and associated
> > + * with a dma-buf handle, else driver private memory.
> > + *
> > + * @returns a pointer to 'struct tee_shm'
>
> Doesn't say anything, is this really needed?
>
> [snip]
>
> > +/**
> > + * struct tee_shm_pool_mem_info - holds information needed to create a shared
> > + * memory pool
> > + * @vaddr: Virtual address of start of pool
> > + * @paddr: Physical address of start of pool
> > + * @size: Size in bytes of the pool
> > + */
> > +struct tee_shm_pool_mem_info {
> > + unsigned long vaddr;
> > + unsigned long paddr;
>
> phys_addr_t paddr; ?
Thanks for taking the time to review this. I'll address all your
comments here in the next version of the patch set.
--
Jens
next prev parent reply other threads:[~2016-08-31 12:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 13:00 [PATCH v11 0/4] generic TEE subsystem Jens Wiklander
2016-08-22 13:00 ` [PATCH v11 1/4] dt/bindings: add bindings for optee Jens Wiklander
2016-08-22 13:00 ` [PATCH v11 2/4] tee: generic TEE subsystem Jens Wiklander
2016-08-30 19:29 ` Andrew F. Davis
2016-08-31 12:47 ` Jens Wiklander [this message]
2016-08-22 13:00 ` [PATCH v11 3/4] tee: add OP-TEE driver Jens Wiklander
2016-08-23 8:38 ` Jérôme Forissier
2016-08-30 20:23 ` Andrew F. Davis
2016-08-31 13:50 ` Jens Wiklander
2016-08-31 16:40 ` Andrew F. Davis
2016-09-01 9:22 ` Jens Wiklander
2016-09-01 18:06 ` Andrew F. Davis
2016-09-02 10:49 ` Jens Wiklander
2016-09-02 13:56 ` Andrew F. Davis
2016-08-31 17:02 ` Volodymyr Babchuk
2016-09-07 7:49 ` Zeng Tao
2016-09-07 9:18 ` Jens Wiklander
2016-08-22 13:00 ` [PATCH v11 4/4] Documentation: tee subsystem and op-tee driver Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831124744.GA25472@ermac \
--to=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).