From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/5] drm/sun4i: rgb: Remove the bridge enable/disable functions
Date: Fri, 30 Sep 2016 16:37:05 +0200 [thread overview]
Message-ID: <20160930143709.1388-2-maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <20160930143709.1388-1-maxime.ripard@free-electrons.com>
The atomic helpers already call the drm_bridge_enable on our behalf,
there's no need to do it a second time.
Reported-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/gpu/drm/sun4i/sun4i_rgb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c
index 4e4bea6f395c..d198ad7e5323 100644
--- a/drivers/gpu/drm/sun4i/sun4i_rgb.c
+++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c
@@ -155,9 +155,6 @@ static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder)
if (!IS_ERR(tcon->panel))
drm_panel_prepare(tcon->panel);
- /* encoder->bridge can be NULL; drm_bridge_enable checks for it */
- drm_bridge_enable(encoder->bridge);
-
sun4i_tcon_channel_enable(tcon, 0);
if (!IS_ERR(tcon->panel))
@@ -177,9 +174,6 @@ static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder)
sun4i_tcon_channel_disable(tcon, 0);
- /* encoder->bridge can be NULL; drm_bridge_disable checks for it */
- drm_bridge_disable(encoder->bridge);
-
if (!IS_ERR(tcon->panel))
drm_panel_unprepare(tcon->panel);
}
--
2.9.3
next prev parent reply other threads:[~2016-09-30 14:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 14:37 No subject Maxime Ripard
2016-09-30 14:37 ` Maxime Ripard [this message]
2016-09-30 14:37 ` [PATCH v5 2/5] drm/bridge: Add RGB to VGA bridge support Maxime Ripard
2016-10-03 11:10 ` Archit Taneja
2016-10-06 7:21 ` Maxime Ripard
2016-10-06 11:39 ` Archit Taneja
2016-10-06 17:27 ` Laurent Pinchart
2016-10-06 19:53 ` Sean Paul
2016-10-06 21:04 ` Laurent Pinchart
2016-10-07 4:57 ` Archit Taneja
2016-10-07 9:14 ` Maxime Ripard
2016-10-10 5:35 ` Archit Taneja
2016-10-10 7:15 ` Laurent Pinchart
2016-10-10 9:34 ` Archit Taneja
2016-10-07 9:28 ` Laurent Pinchart
2016-10-07 13:42 ` Laurent Pinchart
2016-09-30 14:37 ` [PATCH v5 3/5] ARM: sun5i: a13-olinuxino: Enable VGA bridge Maxime Ripard
2016-09-30 14:37 ` [PATCH v5 4/5] ARM: multi_v7: enable " Maxime Ripard
2016-09-30 14:37 ` [PATCH v5 5/5] ARM: sunxi: Enable " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930143709.1388-2-maxime.ripard@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).