From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] Input: ambakmi - Convert to use devm_*()
Date: Sun, 26 Mar 2017 15:50:24 +0100 [thread overview]
Message-ID: <20170326145023.GO7909@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1490539314-9681-2-git-send-email-leo.yan@linaro.org>
On Sun, Mar 26, 2017 at 10:41:50PM +0800, Leo Yan wrote:
> Convert driver to use devm_*() APIs so rely on driver model core layer
> to manage resources. This eliminates error path boilerplate and makes
> code neat.
>
> This patch also fixes the memory leakage for 'kmi->io' when remove
> module.
No, it is not leaked, in fact, your patch introduces a use-after-free
bug.
kmi->io is of type "struct serio", and this structure has an embedded
"struct device". The lifetime of any structure containing a "struct
device" is controlled by the lifetime of the struct device.
Once serio_register_port() has been called on it, it is up to the
serio layer to free this structure.
Therefore, your patch creates a bug, and so it gets a NAK. There is no
resource leakage here.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-03-26 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 14:41 [PATCH 0/5] Convert to use devm_*() for amba attached modules Leo Yan
2017-03-26 14:41 ` [PATCH 1/5] Input: ambakmi - Convert to use devm_*() Leo Yan
2017-03-26 14:50 ` Russell King - ARM Linux [this message]
2017-03-26 15:23 ` Leo Yan
2017-03-26 14:41 ` [PATCH 2/5] drivers/rtc/rtc-pl030.c: " Leo Yan
2017-03-29 1:45 ` Linus Walleij
2017-03-26 14:41 ` [PATCH 3/5] drivers/rtc/rtc-pl031.c: " Leo Yan
2017-03-29 1:46 ` Linus Walleij
2017-03-26 14:41 ` [PATCH 4/5] vfio: platform: " Leo Yan
2017-04-02 14:45 ` Auger Eric
2017-04-06 14:17 ` Leo Yan
2017-03-26 14:41 ` [PATCH 5/5] ALSA: AACI: Convert to use devm_ioremap_resource() Leo Yan
2017-03-26 14:54 ` Russell King - ARM Linux
2017-03-26 15:20 ` [PATCH 0/5] Convert to use devm_*() for amba attached modules Alexandre Belloni
2017-03-26 15:38 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326145023.GO7909@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).