linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v22 00/11] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date: Tue, 28 Mar 2017 15:53:26 +0100	[thread overview]
Message-ID: <20170328145325.GD8643@leverpostej> (raw)
In-Reply-To: <CADyBb7vddnQ4TZXaem3q=+v=vC41J7O4cVsokn04S2jGGU8veA@mail.gmail.com>

Hi,

On Tue, Mar 28, 2017 at 10:29:10PM +0800, Fu Wei wrote:
> On 28 March 2017 at 21:05, Mark Rutland <mark.rutland@arm.com> wrote:
> > Sorry for the delay; I have not had the time to focus on this as I would
> > like to. I'm happy with patches 1-4, but from patch 5 onwards, there's
> > one change I'd like to see.
> >
> > I'd prefer that mmio timer frame rame N was always stored at
> > arch_timer_mem::frame[N], rather than arch_timer_mem::frame[] being in
> > an arbitrary order. That will make arch_timer_mem_frame::frame_nr
> > redundant.
> >
> > To allow arch_timer_mem::frame[] this to be sparse, I'm happy to have a
> > bool arch_timer_mem_frame::valid field that we set when probing each
> > frame. Then we don't need arch_timer_mem::num_frames.
> >
> > This will make iterating over the frames far less confusing, and makes
> > it simple to detect when a frame number is erroneously reused.
> >
> > Otherwise, I'm largely happy to pick the rest and apply any fixups
> > myself.
> 
> Great thanks for your feedback!
> I will follow your suggestion to improve my patches, then post it in a day.

Thanks, that is much appreciated.

> So I will rebase my patchset on arch-timer/gtdt branch of your REPO
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arch-timer/gtdt

Yes please! The current HEAD should be:

ebbfe8889cffa12f ("clocksource: arm_arch_timer: move arch_timer_needs_of_probing into DT init call").

Thanks,
Mark.

  reply	other threads:[~2017-03-28 14:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 16:31 [PATCH v22 00/11] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 01/11] clocksource: arm_arch_timer: introduce a wrapper function to get the frequency from mmio fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 02/11] clocksource: arm_arch_timer: separate out device-tree code and remove arch_timer_detect_rate fu.wei at linaro.org
2017-03-28 14:58   ` Daniel Lezcano
2017-03-29  3:41     ` Fu Wei
2017-03-29  5:11       ` Fu Wei
2017-03-29 14:41         ` Daniel Lezcano
2017-03-29 15:01           ` Fu Wei
2017-03-21 16:31 ` [PATCH v22 03/11] clocksource: arm_arch_timer: refactor arch_timer_needs_probing fu.wei at linaro.org
2017-03-28 15:02   ` Daniel Lezcano
2017-03-29 15:24     ` Mark Rutland
2017-03-29 15:32       ` Daniel Lezcano
2017-03-21 16:31 ` [PATCH v22 04/11] clocksource: arm_arch_timer: move arch_timer_needs_of_probing into DT init call fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 05/11] clocksource: arm_arch_timer: introduce some new structs to prepare for GTDT fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 06/11] clocksource: arm_arch_timer: refactor MMIO timer probing fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 07/11] acpi/arm64: Add GTDT table parse driver fu.wei at linaro.org
2017-03-28 11:35   ` Lorenzo Pieralisi
2017-03-29  9:48     ` Fu Wei
2017-03-29 10:21       ` Lorenzo Pieralisi
2017-03-29 10:48         ` Fu Wei
2017-03-29 11:33           ` Lorenzo Pieralisi
2017-03-29 13:42             ` Fu Wei
2017-03-29 16:02               ` Lorenzo Pieralisi
2017-03-29 14:29     ` Fu Wei
2017-03-29 14:31       ` Fu Wei
2017-03-29 15:19         ` Lorenzo Pieralisi
2017-03-21 16:31 ` [PATCH v22 08/11] clocksource: arm_arch_timer: simplify ACPI support code fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 09/11] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei at linaro.org
2017-03-29 16:47   ` Lorenzo Pieralisi
2017-03-30  7:54     ` Fu Wei
2017-03-21 16:31 ` [PATCH v22 10/11] clocksource: arm_arch_timer: add GTDT support for memory-mapped timer fu.wei at linaro.org
2017-03-21 16:31 ` [PATCH v22 11/11] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei at linaro.org
2017-03-28 15:41   ` Lorenzo Pieralisi
2017-03-31  8:10     ` Fu Wei
2017-03-31 11:54       ` Lorenzo Pieralisi
2017-03-28 11:32 ` [PATCH v22 00/11] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Jon Masters
2017-03-28 12:34   ` Fu Wei
2017-03-28 13:05     ` Mark Rutland
2017-03-28 14:29       ` Fu Wei
2017-03-28 14:53         ` Mark Rutland [this message]
2017-03-31 17:55           ` Fu Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328145325.GD8643@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).