From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes
Date: Fri, 31 Mar 2017 20:21:11 +0200 [thread overview]
Message-ID: <20170331182111.GJ22609@lunn.ch> (raw)
In-Reply-To: <20170331193920.030d9ca8@gmail.com>
On Fri, Mar 31, 2017 at 07:39:20PM +0200, Ralph Sennhauser wrote:
> On Fri, 31 Mar 2017 18:50:15 +0200
> Andrew Lunn <andrew@lunn.ch> wrote:
>
> > > - sata at a8000 {
> > > + satac0: sata at a8000 {
> >
> > Hi Ralph
> >
> > Why the c in satac0?
>
> For controller and to not conflict with a use case of sata0 for a port,
> similarly to pciec and pcie1. See armada-385-synology-ds116.dts.
:~/linux/arch/arm/boot/dts$ ls *ds116*
ls: cannot access '*ds116*': No such file or directory
But anyway, a few boards seem to solve this by calling the controller
node ahci0: and the port sata0:
> > > - usb3 at f0000 {
> > > + usb3_0: usb3 at f0000 {
> > > compatible =
> > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>;
> > > interrupts = <GIC_SPI 16
> > > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@
> > > status = "disabled";
> > > };
> > >
> > > - usb3 at f8000 {
> > > + usb3_1: usb3 at f8000 {
> > > compatible =
> > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>;
> > > interrupts = <GIC_SPI 17
> > > IRQ_TYPE_LEVEL_HIGH>;
> >
> > I can understand what you are saying. But does anybody else care? Are
> > there other .dtsi files differentiating between USB 1.1, 2 and 3?
>
> It's handled differently where ever I looked, some do some don't. A
> case for distinguishing USB 2.0 and USB 3.0 like this is
> armada-388-gp.dts.
Humm...
/* CON4 */
usb at 58000 {
vcc-supply = <®_usb2_0_vbus>;
status = "okay";
};
/* CON5 */
usb3 at f0000 {
usb-phy = <&usb2_1_phy>;
status = "okay";
};
/* CON7 */
usb3 at f8000 {
usb-phy = <&usb3_phy>;
status = "okay";
};
Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to
it? CON7 is the only true USB 3 port? I think some comments written in
schwiizerd??tsch would be clearre.:-)
Andrew
next prev parent reply other threads:[~2017-03-31 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 7:41 [PATCH] ARM: dts: armada-38x: label USB and SATA nodes Ralph Sennhauser
2017-03-31 16:50 ` Andrew Lunn
2017-03-31 17:39 ` Ralph Sennhauser
2017-03-31 18:21 ` Andrew Lunn [this message]
2017-04-01 8:09 ` Ralph Sennhauser
2017-04-05 15:49 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331182111.GJ22609@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).