From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3
Date: Mon, 3 Apr 2017 08:42:08 +0200 [thread overview]
Message-ID: <20170403064208.llk6usgtkbg5ejzw@lukather> (raw)
In-Reply-To: <3f13c07d-be6a-0350-6d86-de1a4d4e33a8@free-electrons.com>
On Sun, Apr 02, 2017 at 04:34:55PM +0200, Quentin Schulz wrote:
> Hi Icenowy,
>
> On 02/04/2017 15:33, Icenowy Zheng wrote:
> > As we have gained the support for the thermal sensor in H3, we can now
> > add its device nodes to the device tree.
> >
> > Add them to the H3 device tree.
> >
> > The H5 thermal sensor has some differences, and will be added furtherly.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> > arch/arm/boot/dts/sun8i-h3.dtsi | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> > index b36f9f423c39..552217bb9266 100644
> > --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> > @@ -72,6 +72,32 @@
> > };
> > };
> >
> > + iio-hwmon {
> > + compatible = "iio-hwmon";
> > + io-channels = <&ths>;
> > + };
> > +
> > + soc {
> > + ths: ths at 01c25000 {
> > + compatible = "allwinner,sun8i-h3-ths";
> > + reg = <0x01c25000 0x100>;
> > + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
> > + clock-names = "bus", "ths";
> > + resets = <&ccu RST_BUS_THS>;
> > + #thermal-sensor-cells = <0>;
> > + #io-channel-cells = <0>;
> > + };
> > + };
> > +
> > + thermal-zones {
> > + cpu_thermal {
> > + /* milliseconds */
> > + polling-delay-passive = <250>;
> > + polling-delay = <1000>;
> > + thermal-sensors = <&ths>;
> > + };
>
> Would it make sense to add the CPU temp trip points in this patch?
No.
This is a separate, unrelated, change that has nothing to do with what
is described either in the commit title or the commit log.
The thermal zone itself shouldn't even be in this patch.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170403/347b7e7e/attachment.sig>
prev parent reply other threads:[~2017-04-03 6:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 13:33 [RFC PATCH v2 0/4] IIO-based thermal sensor driver for Allwinner H3 SoC Icenowy Zheng
2017-04-02 13:33 ` [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 Icenowy Zheng
2017-04-03 9:15 ` Maxime Ripard
2017-04-03 9:31 ` Icenowy Zheng
2017-04-04 13:20 ` Maxime Ripard
2017-04-04 14:47 ` Rob Herring
2017-04-04 15:02 ` Icenowy Zheng
2017-04-05 19:04 ` Rob Herring
2017-04-02 13:33 ` [RFC PATCH v2 2/4] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23 Icenowy Zheng
2017-04-03 14:28 ` Lee Jones
2017-04-02 13:33 ` [RFC PATCH v2 3/4] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Icenowy Zheng
2017-04-02 14:29 ` Quentin Schulz
2017-04-02 13:33 ` [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3 Icenowy Zheng
2017-04-02 14:34 ` Quentin Schulz
2017-04-03 6:42 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403064208.llk6usgtkbg5ejzw@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).