From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm: Fix memory attribute inconsistencies when using fixmap
Date: Wed, 5 Apr 2017 23:42:45 +0100 [thread overview]
Message-ID: <20170405224245.GA17774@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1491291087-17450-1-git-send-email-ard.biesheuvel@linaro.org>
On Tue, Apr 04, 2017 at 08:31:27AM +0100, Ard Biesheuvel wrote:
> diff --git a/arch/arm/include/asm/mmu.h b/arch/arm/include/asm/mmu.h
> index a5b47421059d..80dfeb8ce8f2 100644
> --- a/arch/arm/include/asm/mmu.h
> +++ b/arch/arm/include/asm/mmu.h
> @@ -1,6 +1,8 @@
> #ifndef __ARM_MMU_H
> #define __ARM_MMU_H
>
> +struct machine_desc;
> +
> #ifdef CONFIG_MMU
>
> typedef struct {
> @@ -24,6 +26,8 @@ typedef struct {
> #define ASID(mm) (0)
> #endif
>
> +void early_mm_init(const struct machine_desc *mdesc);
> +
> #else
>
> /*
> @@ -35,6 +39,8 @@ typedef struct {
> unsigned long end_brk;
> } mm_context_t;
>
> +static inline void early_mm_init(const struct machine_desc *mdesc) { }
> +
Why are we stuffing this into mmu.h? mmu.h is not the header file for
arch/arm/mm/mmu.c - although they have the same base filename, they are
not really related.
asm/mmu.h is supposed to be a kernel-wide include file for the mm_context_t
thing, and should not be filled with arch-private stuff.
Please find a better location for this.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-04-05 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 7:31 [PATCH v3] arm: Fix memory attribute inconsistencies when using fixmap Ard Biesheuvel
2017-04-04 8:48 ` Jon Medhurst (Tixy)
2017-04-04 9:10 ` Ard Biesheuvel
2017-04-04 16:01 ` Jon Medhurst (Tixy)
2017-04-05 22:42 ` Russell King - ARM Linux [this message]
2017-04-06 13:46 ` Jon Medhurst (Tixy)
2017-04-06 13:49 ` Ard Biesheuvel
2017-04-06 16:03 ` [PATCH v4] " Jon Medhurst (Tixy)
2017-04-08 16:51 ` afzal mohammed
2017-04-10 10:16 ` Jon Medhurst (Tixy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405224245.GA17774@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).