From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: boot/compressed: fix decompressor header layout for v7-M
Date: Fri, 19 May 2017 18:37:13 +0100 [thread overview]
Message-ID: <20170519173713.GY22219@n2100.armlinux.org.uk> (raw)
In-Reply-To: <67bd95eb-1f4b-d9d2-9a68-3574d03ac072@arm.com>
On Fri, May 19, 2017 at 06:16:36PM +0100, Robin Murphy wrote:
> On 19/05/17 17:59, Ard Biesheuvel wrote:
> > Indeed. Apart from the error in the second line, this sequence should
> > be equivalent, but the nested macro invocations don't make it clearer
> > imo.
> >
> > I could add some more comments as well if that helps?
>
> Hmm, couldn't it be ISA-agnostic?
>
> ldr pc, 1f
> .ltorg
> THUMB( .thumb )
> ...
>
> given that that should be interworking on anything where THUMB() is
> valid in the first place.
Unfortunately not, this is PIC code, so we must not have anything that
contains an absolute address. LDR to branch is out of the question.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-05-19 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 14:59 [PATCH] arm: boot/compressed: fix decompressor header layout for v7-M Ard Biesheuvel
2017-05-19 15:31 ` Nicolas Pitre
2017-05-19 16:46 ` Dave Martin
2017-05-19 16:59 ` Ard Biesheuvel
2017-05-19 17:08 ` Russell King - ARM Linux
2017-05-19 17:13 ` Ard Biesheuvel
2017-05-19 17:16 ` Robin Murphy
2017-05-19 17:33 ` Ard Biesheuvel
2017-05-19 17:58 ` Robin Murphy
2017-05-19 18:33 ` Russell King - ARM Linux
2017-05-19 17:34 ` Dave Martin
2017-05-19 17:38 ` Dave Martin
2017-05-19 17:37 ` Russell King - ARM Linux [this message]
2017-05-19 17:29 ` Dave Martin
2017-05-19 17:35 ` Russell King - ARM Linux
2017-05-19 17:37 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519173713.GY22219@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).