From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Fri, 19 May 2017 22:33:33 +0300 Subject: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue In-Reply-To: References: <1495104615-4752-1-git-send-email-srishtishar@gmail.com> <20170518135850.GA24513@kroah.com> Message-ID: <20170519193333.5sfsripy27k3xd7r@mwanda> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: > Was the format of this patch acceptable ,the "from" matches the > "signed-off-by" right , so this should be correct , were there any > errors in this ? Should I resend it ? > > Regards, > Srishti > You should capitalize your name in both since you're doing that here. Also I really think you can figure out how to fix your email headers so you don't need to use a From header. Lots of people use gmail and they were able to figure it out. But yeah, the way you sent it is also fine. regards, dan carpenter