linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ralph.sennhauser@gmail.com (Ralph Sennhauser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/13] ARM: dts: armada-385-linksys: group pins in pinctrl
Date: Sun, 21 May 2017 14:48:59 +0200	[thread overview]
Message-ID: <20170521124903.11050-11-ralph.sennhauser@gmail.com> (raw)
In-Reply-To: <20170521124903.11050-1-ralph.sennhauser@gmail.com>

A pin group per node is sufficient, further specialisation only serves
as documentation which can be a comment just as well. This simplifies
configuring pins for nodes in dependants.

Also use labels which end up right by the node they are intended for.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
 arch/arm/boot/dts/armada-385-linksys.dtsi | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index 485abff..1bb974a 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -83,7 +83,7 @@
 		compatible = "gpio-keys";
 		#address-cells = <1>;
 		#size-cells = <0>;
-		pinctrl-0 = <&keys_pin>;
+		pinctrl-0 = <&gpio_keys_pins>;
 		pinctrl-names = "default";
 
 		button at 1 {
@@ -101,7 +101,7 @@
 
 	gpio_leds: gpio-leds {
 		compatible = "gpio-leds";
-		pinctrl-0 = <&power_led_pin &sata_led_pin>;
+		pinctrl-0 = <&gpio_leds_pins>;
 		pinctrl-names = "default";
 
 		power {
@@ -247,18 +247,15 @@
 };
 
 &pinctrl {
-	keys_pin: keys-pin {
+	gpio_keys_pins: gpio-keys-pins {
+		/* mpp24: wps, mpp29: reset */
 		marvell,pins = "mpp24", "mpp29";
 		marvell,function = "gpio";
 	};
 
-	power_led_pin: power-led-pin {
-		marvell,pins = "mpp55";
-		marvell,function = "gpio";
-	};
-
-	sata_led_pin: sata-led-pin {
-		marvell,pins = "mpp54";
+	gpio_leds_pins: gpio-leds-pins {
+		/* mpp54: sata, mpp55: power */
+		marvell,pins = "mpp54", "mpp55";
 		marvell,function = "gpio";
 	};
 
-- 
2.10.2

  parent reply	other threads:[~2017-05-21 12:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-21 12:48 [PATCH 00/13] Linksys WRT3200ACM (Rango) support Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 01/13] ARM: dts: armada-385-linksys: flatten dtsi Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 02/13] ARM: dts: armada-385-linksys: label nodes Ralph Sennhauser
2017-05-22 14:49   ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants Ralph Sennhauser
2017-05-22 14:51   ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 04/13] ARM: dts: armada-385-linksys: drop redundant properties in dependants Ralph Sennhauser
2017-05-22 14:52   ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 05/13] ARM: dts: armada-385-linksys: bm pools by label order Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 06/13] ARM: dts: armada-385-linksys: usb3 label cleanup Ralph Sennhauser
2017-05-22 14:55   ` Andrew Lunn
2017-05-22 18:13     ` Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 07/13] ARM: dts: armada-385-linksys: drop leagcy DSA bindings Ralph Sennhauser
2017-05-22 14:55   ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes Ralph Sennhauser
2017-05-22 15:00   ` Andrew Lunn
2017-05-22 18:24     ` Ralph Sennhauser
2017-05-23  8:33       ` Ralph Sennhauser
2017-05-23 12:02         ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 09/13] ARM: dts: armada-385-linksys: partition layout is board specific Ralph Sennhauser
2017-05-23 12:04   ` Andrew Lunn
2017-05-21 12:48 ` Ralph Sennhauser [this message]
2017-05-23 12:06   ` [PATCH 10/13] ARM: dts: armada-385-linksys: group pins in pinctrl Andrew Lunn
2017-05-21 12:49 ` [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names Ralph Sennhauser
2017-05-23 12:07   ` Andrew Lunn
2017-05-21 12:49 ` [PATCH 12/13] clk: mvebu: add support for 1866MHz variants Ralph Sennhauser
2017-05-23 12:15   ` Andrew Lunn
2017-05-23 19:55     ` Ralph Sennhauser
2017-05-21 12:49 ` [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango) Ralph Sennhauser
2017-05-23 12:18   ` Andrew Lunn
2017-05-23 12:25   ` Andrew Lunn
2017-05-23 20:04     ` Ralph Sennhauser
2017-05-22 18:42 ` [PATCH 00/13] Linksys WRT3200ACM (Rango) support Imre Kaloz
2017-05-23 15:22 ` Gregory CLEMENT
2017-05-23 16:11   ` Ralph Sennhauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170521124903.11050-11-ralph.sennhauser@gmail.com \
    --to=ralph.sennhauser@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).