From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] genirq/cpuhotplug: Revert "Set force affinity flag on hotplug migration"
Date: Thu, 27 Jul 2017 11:24:58 +0100 [thread overview]
Message-ID: <20170727102458.GB20746@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1707271217590.3109@nanos>
Thanks Thomas, this should fix our nightly testing which is currently
failing the CPU hotplug tests.
On Thu, Jul 27, 2017 at 12:21:11PM +0200, Thomas Gleixner wrote:
> --- a/kernel/irq/cpuhotplug.c
> +++ b/kernel/irq/cpuhotplug.c
> @@ -95,8 +95,13 @@ static bool migrate_one_irq(struct irq_d
> affinity = cpu_online_mask;
> brokeaff = true;
> }
> -
> - err = irq_do_set_affinity(d, affinity, true);
> + /*
> + * Do not set the force argument of irq_do_set_affinity() as this
> + * disables the masking of offline CPUs from the supplied affinity
> + * mask and therefor might keep/reassign the irq to the outgoing
Typo: therefore
> + * CPU.
> + */
> + err = irq_do_set_affinity(d, affinity, false);
With that fixed:
Acked-by: Will Deacon <will.deacon@arm.com>
Cheers,
Will
prev parent reply other threads:[~2017-07-27 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 10:21 [PATCH] genirq/cpuhotplug: Revert "Set force affinity flag on hotplug migration" Thomas Gleixner
2017-07-27 10:24 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727102458.GB20746@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).