From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] pci: add support for firmware initialized designware RCs
Date: Thu, 24 Aug 2017 11:46:33 -0500 [thread overview]
Message-ID: <20170824164633.GI31858@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170821192907.8695-1-ard.biesheuvel@linaro.org>
On Mon, Aug 21, 2017 at 08:29:04PM +0100, Ard Biesheuvel wrote:
> UEFI based systems incorporating a Synopsys Designware PCIe controller
> in RC mode will typically configure it before entering the OS. If this
> configuration is fully static and ECAM compliant, there is no need to
> expose particulars of the device to the OS, and we can simply describe
> it as "pci-host-ecam-generic".
I *love* the idea of moving more of this to firmware. I spend an
incredible amount of time looking at all these native drivers, and
*zero* time looking at the ACPI driver (pci_root.c). And it's not
like all this code in the native drivers is adding features or
performance. It's just extra work for no benefit.
I'm assuming there'll be a v2 soon for the kbuild warnings.
> However, the Synopsys IP may be synthesized in a way where a quirk is
> needed for config space accesses to the first bus. It makes little sense
> to instantiate yet another pcie-designware driver that contains all the
> low level setup code, but it is also not justified to add quirks handling
> to the generic ECAM driver.
>
> So instead, create a variant of the generic ECAM driver that filters config
> space accesses directed at device #1 and up on the first bus.
>
> Also, add a binding and driver to support the MSI functionality available
> in some versions of this IP. This allows the MSI routing to be described
> at the DT level rather than hardcoding it in the driver.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Graeme Gregory <graeme.gregory@linaro.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Joao Pinto <Joao.Pinto@synopsys.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
>
> Ard Biesheuvel (3):
> pci: designware: add driver for DWC controller in ECAM shift mode
> pci: designware: add separate driver for the MSI part of the RC
> dt-bindings: designware: add binding for Designware PCIe in ECAM mode
>
> Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt | 56 +++++
> drivers/pci/dwc/Kconfig | 11 +
> drivers/pci/dwc/Makefile | 4 +-
> drivers/pci/dwc/pcie-designware-ecam.c | 75 ++++++
> drivers/pci/dwc/pcie-designware-msi.c | 255 ++++++++++++++++++++
> 5 files changed, 400 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> create mode 100644 drivers/pci/dwc/pcie-designware-ecam.c
> create mode 100644 drivers/pci/dwc/pcie-designware-msi.c
>
> --
> 2.11.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-08-24 16:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 19:29 [PATCH 0/3] pci: add support for firmware initialized designware RCs Ard Biesheuvel
2017-08-21 19:29 ` [PATCH 1/3] pci: designware: add driver for DWC controller in ECAM shift mode Ard Biesheuvel
2017-08-24 16:24 ` kbuild test robot
2017-08-24 16:25 ` kbuild test robot
2017-08-21 19:29 ` [PATCH 2/3] pci: designware: add separate driver for the MSI part of the RC Ard Biesheuvel
2017-08-24 16:42 ` Bjorn Helgaas
2017-08-24 16:43 ` Ard Biesheuvel
2017-08-24 16:48 ` Robin Murphy
2017-08-24 16:50 ` Ard Biesheuvel
2020-02-15 0:54 ` Alan Mikhak
2020-02-15 9:35 ` Ard Biesheuvel
2020-02-15 10:36 ` Marc Zyngier
2020-02-18 19:09 ` Alan Mikhak
2020-02-19 8:11 ` Marc Zyngier
2020-02-19 8:17 ` Ard Biesheuvel
2020-02-19 20:24 ` Alan Mikhak
2020-02-19 21:06 ` Ard Biesheuvel
2020-02-19 21:35 ` Alan Mikhak
2017-08-21 19:29 ` [PATCH 3/3] dt-bindings: designware: add binding for Designware PCIe in ECAM mode Ard Biesheuvel
2017-08-24 16:46 ` Bjorn Helgaas [this message]
2017-08-31 19:21 ` [PATCH 0/3] pci: add support for firmware initialized designware RCs Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824164633.GI31858@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).