Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/13] replace print_symbol() with printk()-s
Date: Fri, 5 Jan 2018 19:25:38 +0900
Message-ID: <20180105102538.GC471@jagdpanzerIV> (raw)
In-Reply-To: <20180105102105.GB471@jagdpanzerIV>

On (01/05/18 19:21), Sergey Senozhatsky wrote:
> On (01/05/18 11:03), Petr Mladek wrote:
> [..]
> > Anyway, print_symbol() is an old weird API and it would be nice
> > to eventually get rid of it. I could take this patches into
> > printk.git.
> 
> no objections from my side if the patch set will go through the printk tree.
> shall we wait for ACKs or can we move on? do you plan to land it in 4.16?
> 
> > Would you mind if I change the commit messages to something like?:
> > 
> >     print_symbol() is an old weird API. It has been
> >     obsoleted by printk() and %pS format specifier.
> 
> I wouldn't. let's drop the "weird" part. other than that looks
> good to me.

oh, one more thing. one extra patch, which gets rid of
print_symbol()/__print_symbol().

8< ===

From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: [PATCH] kallsyms: remove print_symbol() function

No more print_symbol()/__print_symbol() users left, remove these
symbols.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Suggested-by: Joe Perches <joe@perches.com>
---
 Documentation/filesystems/sysfs.txt                    |  4 ++--
 Documentation/translations/zh_CN/filesystems/sysfs.txt |  4 ++--
 include/linux/kallsyms.h                               | 18 ------------------
 kernel/kallsyms.c                                      | 11 -----------
 4 files changed, 4 insertions(+), 33 deletions(-)

diff --git a/Documentation/filesystems/sysfs.txt b/Documentation/filesystems/sysfs.txt
index 9a3658cc399e..a1426cabcef1 100644
--- a/Documentation/filesystems/sysfs.txt
+++ b/Documentation/filesystems/sysfs.txt
@@ -154,8 +154,8 @@ static ssize_t dev_attr_show(struct kobject *kobj, struct attribute *attr,
         if (dev_attr->show)
                 ret = dev_attr->show(dev, dev_attr, buf);
         if (ret >= (ssize_t)PAGE_SIZE) {
-                print_symbol("dev_attr_show: %s returned bad count\n",
-                                (unsigned long)dev_attr->show);
+                printk("dev_attr_show: %pS returned bad count\n",
+                                dev_attr->show);
         }
         return ret;
 }
diff --git a/Documentation/translations/zh_CN/filesystems/sysfs.txt b/Documentation/translations/zh_CN/filesystems/sysfs.txt
index 7d3b05edb8ce..452271dda141 100644
--- a/Documentation/translations/zh_CN/filesystems/sysfs.txt
+++ b/Documentation/translations/zh_CN/filesystems/sysfs.txt
@@ -167,8 +167,8 @@ static ssize_t dev_attr_show(struct kobject *kobj, struct attribute *attr,
         if (dev_attr->show)
                 ret = dev_attr->show(dev, dev_attr, buf);
         if (ret >= (ssize_t)PAGE_SIZE) {
-                print_symbol("dev_attr_show: %s returned bad count\n",
-                                (unsigned long)dev_attr->show);
+                printk("dev_attr_show: %pS returned bad count\n",
+                                dev_attr->show);
         }
         return ret;
 }
diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
index 23190e5c940b..657a83b943f0 100644
--- a/include/linux/kallsyms.h
+++ b/include/linux/kallsyms.h
@@ -94,9 +94,6 @@ extern int sprint_symbol(char *buffer, unsigned long address);
 extern int sprint_symbol_no_offset(char *buffer, unsigned long address);
 extern int sprint_backtrace(char *buffer, unsigned long address);
 
-/* Look up a kernel symbol and print it to the kernel messages. */
-extern void __print_symbol(const char *fmt, unsigned long address);
-
 int lookup_symbol_name(unsigned long addr, char *symname);
 int lookup_symbol_attrs(unsigned long addr, unsigned long *size, unsigned long *offset, char *modname, char *name);
 
@@ -166,23 +163,8 @@ static inline int kallsyms_show_value(void)
 	return false;
 }
 
-/* Stupid that this does nothing, but I didn't create this mess. */
-#define __print_symbol(fmt, addr)
 #endif /*CONFIG_KALLSYMS*/
 
-/* This macro allows us to keep printk typechecking */
-static __printf(1, 2)
-void __check_printsym_format(const char *fmt, ...)
-{
-}
-
-static inline void print_symbol(const char *fmt, unsigned long addr)
-{
-	__check_printsym_format(fmt, "");
-	__print_symbol(fmt, (unsigned long)
-		       __builtin_extract_return_addr((void *)addr));
-}
-
 static inline void print_ip_sym(unsigned long ip)
 {
 	printk("[<%px>] %pS\n", (void *) ip, (void *) ip);
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index 24f456689f9c..a23e21ada81b 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -429,17 +429,6 @@ int sprint_backtrace(char *buffer, unsigned long address)
 	return __sprint_symbol(buffer, address, -1, 1);
 }
 
-/* Look up a kernel symbol and print it to the kernel messages. */
-void __print_symbol(const char *fmt, unsigned long address)
-{
-	char buffer[KSYM_SYMBOL_LEN];
-
-	sprint_symbol(buffer, address);
-
-	printk(fmt, buffer);
-}
-EXPORT_SYMBOL(__print_symbol);
-
 /* To avoid using get_symbol_offset for every symbol, we carry prefix along. */
 struct kallsym_iter {
 	loff_t pos;
-- 
2.15.1

  reply index

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 12:50 sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 01/13] arm: do not use print_symbol() sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 02/13] arm64: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 03/13] c6x: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 04/13] ia64: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 05/13] mn10300: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 06/13] sh: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 07/13] unicore32: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 08/13] x86: " sergey.senozhatsky.work
2017-12-11 17:45   ` bp
2017-12-12  2:41     ` sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 09/13] drivers: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 10/13] sysfs: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 11/13] irq debug: " sergey.senozhatsky.work
2017-12-11 12:55   ` David.Laight
2017-12-12  2:50     ` sergey.senozhatsky.work
2017-12-12  7:34   ` [PATCHv2 " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 12/13] lib: " sergey.senozhatsky.work
2017-12-11 12:50 ` [PATCH 13/13] arc: do not use __print_symbol() sergey.senozhatsky.work
2017-12-11 16:28   ` Vineet.Gupta1
2017-12-12  2:41     ` sergey.senozhatsky.work
2017-12-11 16:26 ` [PATCH 00/13] replace print_symbol() with printk()-s joe
2017-12-12  2:47   ` sergey.senozhatsky.work
2017-12-12  3:10     ` joe
2017-12-21  5:54       ` sergey.senozhatsky.work
2017-12-20 10:20 ` sergey.senozhatsky.work
2018-01-05 10:03 ` pmladek
2018-01-05 10:21   ` sergey.senozhatsky.work
2018-01-05 10:25     ` sergey.senozhatsky.work [this message]
2018-01-05 14:42       ` pmladek
2018-01-05 14:57         ` sergey.senozhatsky
2018-01-08  2:09         ` sergey.senozhatsky.work
     [not found]           ` <20180116163301.lh76kvjheyobjgkp@pathway.suse.cz>
2018-01-17  2:36             ` sergey.senozhatsky.work
2018-01-05 11:38     ` pmladek
2018-01-05 12:01     ` sergey.senozhatsky.work
2018-01-05 12:23       ` sergey.senozhatsky.work
2018-01-05 13:09         ` pmladek

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105102538.GC471@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git