From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Fri, 26 Jan 2018 08:53:43 +0100 Subject: [PATCH v4 4/8] PCI: brcmstb: Add dma-range mapping for inbound traffic In-Reply-To: References: <1516058925-46522-1-git-send-email-jim2101024@gmail.com> <1516058925-46522-5-git-send-email-jim2101024@gmail.com> <20180118073123.GA15766@lst.de> <20180118152331.GA24461@lst.de> <20180123132033.GA21438@lst.de> Message-ID: <20180126075343.GB2356@lst.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 24, 2018 at 12:04:58PM -0800, Florian Fainelli wrote: > This looks nicer than the current shape, but this still requires to > register a PCI fixup to override phys_to_dma() and dma_to_phys(), and it > would appear that you have dodged my question about how this is supposed > to fit with an entirely modular PCIe root complex driver? Are you > suggesting that we split the module into a built-in part and a modular part? I don't think entirely modular PCI root bridges should be a focal point for the design. If we happen to support them by other design choices: fine, but they should not be a priority. That being said if we have core dma mapping or PCIe code that has a list of offsets and the root complex only populates them it should work just fine.