From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9BC1C43441 for ; Thu, 29 Nov 2018 16:27:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A816F20863 for ; Thu, 29 Nov 2018 16:27:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qdhGhWnN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A816F20863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IbiZAeBENMc2zlA4BphROpblTsMmAdP9gtfLHib8zyw=; b=qdhGhWnN8l7MRk /sNwtHd0KFEQhMBqttPSec0Agqo0bfIxh4N9WhGlpuc1c/nugsza1t4+mY+rYu+qn16qmXM2nzCc0 YXJyBI5egPdAAAutprAMjs9NRpJWB4p1XR3V6UoPbEJYFfZYITqW7c1cHH/FMN9HK8SCPptiXVe3U h9UJ4VDROGKlWKCyIa3RkqO6BwKP3RZnUVLPEPzDTnWGSvsHXwzEXStH1s28ScGsQliIihEEIxjEq EdjMWF4qCJmC3+7RTcVSbkyTnhe6dIl56UdY6eOajJ6ko27twKARRna/gOJOKGggoiPEXmvE6GWnV A4fIo4qEOHcJPis88+Zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSP9X-0005wj-Uk; Thu, 29 Nov 2018 16:26:59 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSP9S-0005kN-UV for linux-arm-kernel@lists.infradead.org; Thu, 29 Nov 2018 16:26:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 845EAA78; Thu, 29 Nov 2018 08:26:43 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7A953F59C; Thu, 29 Nov 2018 08:26:41 -0800 (PST) Date: Thu, 29 Nov 2018 16:26:39 +0000 From: Mark Rutland To: Julien Thierry Subject: Re: [PATCH v6 01/24] arm64: Remove unused daif related functions/macros Message-ID: <20181129162638.gth6epspauks3a4i@lakrids.cambridge.arm.com> References: <1542023835-21446-1-git-send-email-julien.thierry@arm.com> <1542023835-21446-2-git-send-email-julien.thierry@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1542023835-21446-2-git-send-email-julien.thierry@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181129_082655_008412_73000794 X-CRM114-Status: GOOD ( 17.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, christoffer.dall@arm.com, james.morse@arm.com, joel@joelfernandes.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 12, 2018 at 11:56:52AM +0000, Julien Thierry wrote: > There are some helpers to modify PSR.[DAIF] bits that are not referenced > anywhere. The less these bits are available outside of local_irq_* > functions the better. > > Get rid of those unused helpers. > > Signed-off-by: Julien Thierry > Cc: Catalin Marinas > Cc: Will Deacon > Cc: James Morse Reviewed-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/assembler.h | 10 +--------- > arch/arm64/include/asm/daifflags.h | 10 ---------- > 2 files changed, 1 insertion(+), 19 deletions(-) > > diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h > index 6142402..6e76c8e 100644 > --- a/arch/arm64/include/asm/assembler.h > +++ b/arch/arm64/include/asm/assembler.h > @@ -60,16 +60,8 @@ > .endm > > /* > - * Enable and disable interrupts. > + * Save/restore interrupts. > */ > - .macro disable_irq > - msr daifset, #2 > - .endm > - > - .macro enable_irq > - msr daifclr, #2 > - .endm > - > .macro save_and_disable_irq, flags > mrs \flags, daif > msr daifset, #2 > diff --git a/arch/arm64/include/asm/daifflags.h b/arch/arm64/include/asm/daifflags.h > index 8d91f22..546bc39 100644 > --- a/arch/arm64/include/asm/daifflags.h > +++ b/arch/arm64/include/asm/daifflags.h > @@ -43,16 +43,6 @@ static inline unsigned long local_daif_save(void) > return flags; > } > > -static inline void local_daif_unmask(void) > -{ > - trace_hardirqs_on(); > - asm volatile( > - "msr daifclr, #0xf // local_daif_unmask" > - : > - : > - : "memory"); > -} > - > static inline void local_daif_restore(unsigned long flags) > { > if (!arch_irqs_disabled_flags(flags)) > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel