From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BD7C04EB9 for ; Mon, 3 Dec 2018 17:19:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47F3B20848 for ; Mon, 3 Dec 2018 17:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iMfiHIn0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47F3B20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rQzby4eMVt+nHfo5YQX3fDBjUJpmEp6zlYzp6I/SVI0=; b=iMfiHIn0+1y1kZ oqIrTRLCoxrbiPn3btZIlR01QxOzY6DoOakPnkjJlI8OAtFaYjAKPhWdkPI6QErqR8fvILms8e+/l JsBeOpPtwRYYFxpR8NPG5gHwJQ8s4ntYf2bnwVt5rrM2JorisKzRnRuR+dXfwvbnPs2urJr+nZIir nGw7dcH/WRrsDvcQR9lXrZmy/RhwbZ5fcJ4DJV+lCCsFWSjAoIXBZ6SO7StWiOtZuAFFQ5hu4NiA6 82Yk3ZB1WHIHptAE4ice1mTW8CSE+lyBR5ZNnCzrjyk/Q/SX0bO4lTOMurZ0DTYMTV3avkLoPMrjo 6FUCqBec6Xn8vjdPclWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTrsP-0006ar-BS; Mon, 03 Dec 2018 17:19:21 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTrsM-0006ZW-94 for linux-arm-kernel@lists.infradead.org; Mon, 03 Dec 2018 17:19:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C76271682; Mon, 3 Dec 2018 09:19:07 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BE7A3F59C; Mon, 3 Dec 2018 09:19:04 -0800 (PST) Date: Mon, 3 Dec 2018 17:18:59 +0000 From: Lorenzo Pieralisi To: Miquel Raynal Subject: Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support Message-ID: <20181203171859.GA12792@e107981-ln.cambridge.arm.com> References: <20181123141831.8214-1-miquel.raynal@bootlin.com> <20181123141831.8214-6-miquel.raynal@bootlin.com> <20181203102708.GA6090@e107981-ln.cambridge.arm.com> <20181203163846.494904f9@xps13> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181203163846.494904f9@xps13> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181203_091918_324775_9ED11F60 X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , linux-pci@vger.kernel.org, Gregory Clement , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Maxime Chevallier , Nadav Haklai , Stephen Boyd , Rob Herring , Thomas Petazzoni , sudeep.holla@arm.com, Bjorn Helgaas , Michael Turquette , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+Stephen, Mike] On Mon, Dec 03, 2018 at 04:38:46PM +0100, Miquel Raynal wrote: > Hi Lorenzo, > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > 10:27:08 +0000: > > > [+Rafael, Sudeep] > > > > On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: > > > Add suspend and resume callbacks. The priority of these are > > > "_noirq()", to workaround early access to the registers done by the > > > PCI core through the ->read()/->write() callbacks at resume time. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > drivers/pci/controller/pci-aardvark.c | 52 +++++++++++++++++++++++++++ > > > 1 file changed, 52 insertions(+) > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > > index 108b3f15c410..7ecf1ac4036b 100644 > > > --- a/drivers/pci/controller/pci-aardvark.c > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > @@ -1108,6 +1108,55 @@ static int advk_pcie_setup_clk(struct advk_pcie *pcie) > > > return ret; > > > } > > > > > > +static int __maybe_unused advk_pcie_suspend(struct device *dev) > > > +{ > > > + struct advk_pcie *pcie = dev_get_drvdata(dev); > > > + > > > + advk_pcie_disable_phy(pcie); > > > + > > > + clk_disable_unprepare(pcie->clk); > > > > I have noticed it is common practice, still, I would like to check whether > > it is allowed to call functions that may sleep in a NOIRQ suspend/resume > > callback ? > > You are right this is weird. I double checked and for instance, > pcie-mediatek.c, pci-tegra.c and pci-imx6.c do the exact same thing. > There are probably other cases where drivers call functions that may > sleep from a NOIRQ context. I am interested to know if this is valid > and if not, what is the alternative? I added Stephen and Mike, who along with Rafael can help us shed some light into this, I do not have the necessary bits of info myself, I just noticed. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel