From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Rob Herring <robh@kernel.org>, Marcel Partap <mpartap@gmx.net>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
omerlle@gmail.com, Merlijn Wajer <merlijn@wizzup.org>,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
NeKit <nekit1000@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Michael Scott <hashcode0f@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
linux-omap@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver
Date: Tue, 18 Dec 2018 13:46:16 +0100 [thread overview]
Message-ID: <20181218124616.GA10758@amd> (raw)
In-Reply-To: <20181217004450.GW6707@atomide.com>
[-- Attachment #1.1: Type: text/plain, Size: 2994 bytes --]
Hi!
> So the little elves have been slowly working to get voice calls
> working on droid 4 with the mainline kernel. And just in time for the
> upcoming holidays, it might be possible to call friends and relatives.
>
> I've pushed out an experimental branch containing serdev ts 27.010
> UART multiplexing support. That contains a serdev core driver for the
> mdm6600 modem (that also now idles the modem for PM), support for Alsa
> ASoC voice codec and mixer, and a GNSS driver for the GPS.
Thanks for doing the work.
I'm quite busy these days, but...
# commit 64cf2bf6b7614da35028a11974acb5a445dcc535 (patch)
# n_gsm: Use const unsigned char * and size_t
# We can use const unsigned char * and size_t. This makes things
# a bit easier for adding serdev support.
#
# Note that gsm_control_modem() gsm_control_rls() read the data
# for tty control characters and then call gsm_control_reply()
# that allocates a new reply and copies the data.
#
# REVISIT: Check size_t usage vs int
#
# Signed-off-by: Tony Lindgren <tony@atomide.com>
Dunno, I see that you might want const there, but u8 -> unsigned char
seems like a step in wrong direction.
# commit cd16272060d8100ef0388349cf88f42a1dc667fc (patch)
# tty: n_gsm: Add support for serdev
Is it worth putting those in separate file? n_gsm_serdev.c?
# commit 0c1bc81ba976bcd480d6e3c3009a28589f8427c0 (patch)
# mfd: motmdm: Add Motorola TS 27.010 serdev driver for devices like droid4
Oh, that is a lot of fun. Especially state machine for parsing modem
responses. I wonder how well it is going to work when modem is
accessed over USB...
motmdm_read_state(... size_t len)
I applied it over my tree (I still need patches for display,
right?). I'm getting
/data/fast/l/k/drivers/mfd/motorola-mdm.c:1132:3: error: initializer
element is not constant
/data/fast/l/k/drivers/mfd/motorola-mdm.c:1132:3: error: (near
initialization for 'motmdm_driver.driver.name')
/data/fast/l/k/scripts/Makefile.build:291: recipe for target
'drivers/mfd/motorola-mdm.o' failed
Oh and that mdelay(3000) is going to hurt... especially because
console is initialized very late or d4.
I did a quick test in my config... and it did not break my old setup
-- voice calls still work when set up over USB and with manual mixer
setup. That was good surprise.
Thanks,
Pavel
diff --git a/drivers/mfd/motorola-mdm.c b/drivers/mfd/motorola-mdm.c
index eea754d..2b7c324 100644
--- a/drivers/mfd/motorola-mdm.c
+++ b/drivers/mfd/motorola-mdm.c
@@ -1129,7 +1129,7 @@ static void motmdm_remove(struct serdev_device *serdev)
static struct serdev_device_driver motmdm_driver = {
.driver = {
- .name = motmdm_driver_name,
+ .name = "motmdm",
.of_match_table = of_match_ptr(motmdm_id_table),
.pm = &motmdm_pm_ops,
},
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-18 12:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 0:44 WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver Tony Lindgren
2018-12-18 12:46 ` Pavel Machek [this message]
2018-12-18 15:36 ` Tony Lindgren
2018-12-18 20:22 ` Pavel Machek
2018-12-18 21:53 ` Tony Lindgren
2019-01-16 13:48 ` Pavel Machek
2019-01-17 2:54 ` Tony Lindgren
2019-01-17 12:51 ` Pavel Machek
2018-12-22 23:05 ` Pavel Machek
2018-12-23 10:33 ` Pavel Machek
2018-12-23 11:10 ` Pavel Machek
2018-12-23 15:51 ` Tony Lindgren
2018-12-23 19:59 ` Pavel Machek
2018-12-26 21:16 ` Pavel Machek
2018-12-27 10:16 ` Pavel Machek
2018-12-28 19:31 ` Tony Lindgren
2018-12-28 20:46 ` Pavel Machek
2018-12-28 22:28 ` Tony Lindgren
2018-12-28 23:25 ` Pavel Machek
2018-12-28 23:34 ` Tony Lindgren
2018-12-31 22:20 ` Tony Lindgren
2019-01-16 13:58 ` Pavel Machek
2019-01-16 14:59 ` Tony Lindgren
2019-01-16 15:09 ` Tony Lindgren
2019-01-16 23:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218124616.GA10758@amd \
--to=pavel@ucw.cz \
--cc=hashcode0f@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=johan@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=omerlle@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).