From: Lubomir Rintel <lkundrak@v3.sk>
To: Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
platform-driver-x86@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>, Rob Herring <robh+dt@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 04/10] Platform: OLPC: Avoid a warning if the EC didn't register yet
Date: Thu, 10 Jan 2019 18:58:39 +0100 [thread overview]
Message-ID: <20190110175845.1203986-5-lkundrak@v3.sk> (raw)
In-Reply-To: <20190110175845.1203986-1-lkundrak@v3.sk>
Just return EPROBE_DEFER, so that whoever attempted to use the EC call can
defer their work.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
Changes since v2:
- Adjust the commit message for the s/ENODEV/EPROBE_DEFER/ change
Changes since v1:
- EPROBE_DEFER instead of ENODEV
drivers/platform/olpc/olpc-ec.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c
index 2a647455a368..a91f78245f5e 100644
--- a/drivers/platform/olpc/olpc-ec.c
+++ b/drivers/platform/olpc/olpc-ec.c
@@ -125,8 +125,11 @@ int olpc_ec_cmd(u8 cmd, u8 *inbuf, size_t inlen, u8 *outbuf, size_t outlen)
struct olpc_ec_priv *ec = ec_priv;
struct ec_cmd_desc desc;
- /* Ensure a driver and ec hook have been registered */
- if (WARN_ON(!ec_driver || !ec_driver->ec_cmd))
+ /* Driver not yet registered. */
+ if (!ec_driver)
+ return -EPROBE_DEFER;
+
+ if (WARN_ON(!ec_driver->ec_cmd))
return -ENODEV;
if (!ec)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-10 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 17:58 [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 01/10] dt-bindings: olpc, xo1.75-ec: Add OLPC XO-1.75 EC bindings Lubomir Rintel
2019-01-11 14:36 ` [PATCH v5 01/10] dt-bindings: olpc,xo1.75-ec: " Rob Herring
2019-02-21 1:21 ` Darren Hart
2019-01-10 17:58 ` [PATCH v5 02/10] Platform: OLPC: Remove an unused include Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 03/10] Platform: OLPC: Move EC-specific functionality out from x86 Lubomir Rintel
2019-01-10 17:58 ` Lubomir Rintel [this message]
2019-01-10 17:58 ` [PATCH v5 05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver Lubomir Rintel
2019-02-21 1:22 ` Darren Hart
2019-02-21 13:28 ` Andy Shevchenko
2019-01-10 17:58 ` [PATCH v5 07/10] Platform: OLPC: Add a regulator for the DCON Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 08/10] power: supply: olpc_battery: Allow building the driver on non-x86 Lubomir Rintel
2019-02-19 23:17 ` Sebastian Reichel
2019-01-10 17:58 ` [PATCH v5 09/10] ARM: export arm_pm_restart Lubomir Rintel
2019-01-10 17:58 ` [PATCH v5 10/10] Platform: OLPC: Add restart support to XO-1.75 EC driver Lubomir Rintel
2019-02-11 11:46 ` [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-02-11 11:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110175845.1203986-5-lkundrak@v3.sk \
--to=lkundrak@v3.sk \
--cc=andy@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).