From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AD1C43387 for ; Fri, 11 Jan 2019 09:20:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3289B2146F for ; Fri, 11 Jan 2019 09:20:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LRUL1bRo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="J3+uACOs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3289B2146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74STRhzVbE4r91rYGpHu+4rh+iHhwd54nof/qqFb0es=; b=LRUL1bRoutPslL 3bMZzacynmECsQyq28XwAQkAqh+sON8kaeyMrtoC2f6TloGPh39hPL3S2moOL0UdIUHJ+E6dSEtK4 Ck05SJQvPeDZksPjsYsRjZMc35scUHt83NNuKrNDcbMeGlbNEVKQCX2xM8zFZx01LgiHAnNSGwp4J NZEeiiizg/3jkWat4oDwnLDYN/CJ24rHkPoQVgpmv8SRPbS4CRa8CTqIIAMU0Ds9/canPKWsI/7xT SsnPTwrgbqjkX3lGIE505jfPvZUR0UoHgmQpBkk1Gsb/2VCt5P2s25e1ZJnPQ170aJYdLyGlqUx1E MtzCxwzw4KfpsT8/ocgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghszk-0003il-SC; Fri, 11 Jan 2019 09:20:52 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghszf-0003hP-Qw for linux-arm-kernel@lists.infradead.org; Fri, 11 Jan 2019 09:20:49 +0000 Received: by mail-ed1-x543.google.com with SMTP id h50so12516267ede.5 for ; Fri, 11 Jan 2019 01:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GaqnS2LOgt+LFJt9xFrmU2vVR4iRU1kwlidEkb98jHQ=; b=J3+uACOsGvjKIwwNZU9v/5e9exunHsPJpRPYDg4OlMHHf/XELl6dYwNsYlGox5YTa8 yMbxIMStMsUQrN+OyrAaM3vIDZ3TDlpKGlarvZ6Rb6jV8SGsXkCrKe5+9f6rxGOE0zrC M4wSFRXHs04vdaIB4+CC7tXD97hu9kx632QVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=GaqnS2LOgt+LFJt9xFrmU2vVR4iRU1kwlidEkb98jHQ=; b=bLvXOfwnlzhKkhXfAfGQIlsjMQArMhGg4gCQY4jmUbUOyolVCtNUGEu1ac/m9nVhqn goe6N+AZPJjSjEycX0THDIkVAQ3moCLaVivnB3ox1rVvWHrfVkcaP4uVBw7hbmaGaQDS KTlgseQq9x6dCvPn8IlRZoL2rM2eLfFBZmHFtKxUc5EoewMtACp9FKNW1AMSOnB9FNQz XW+in7lonf5mSkHODDajbY0Ln9iX6iuKuuCB731LpD6n8KK0Cm0FjF8dUncjGOK6IUd4 tY9ut9/EbF6HeGjU4shHcfJ+p3f55GzTizA24pWq2cmSVyNBKh6IGBtAgPHKe/UlE7h7 xPCA== X-Gm-Message-State: AJcUukf/2rHibMzTAbyqHJOKqPI3qo3/2/zrKXwj8SaW7lZWM0OUc+3S iVp0DsMt8W5PL6YDuFPeUBZnbQ== X-Google-Smtp-Source: ALg8bN4kBtaXnQRgos4KUgmDEnpC7otk8vZ64bn1MqFMnTMg4iIyt3mMD7L0TM3+lcOPEX94Yx+UEg== X-Received: by 2002:a17:906:d507:: with SMTP id ge7-v6mr11266479ejb.78.1547198445731; Fri, 11 Jan 2019 01:20:45 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id m14sm3064811edc.27.2019.01.11.01.20.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 01:20:44 -0800 (PST) Date: Fri, 11 Jan 2019 10:20:42 +0100 From: Daniel Vetter To: CK Hu , Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: Re: [PATCH] drm/mediatek: Add MTK Framebuffer-Device (mt7623) Message-ID: <20190111092042.GP21184@phenom.ffwll.local> Mail-Followup-To: CK Hu , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Frank Wunderlich , David Airlie , Alexander Ryabchenko , Linux Kernel Mailing List , dri-devel , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Philipp Zabel , Linux ARM References: <20190102084917.4049-1-frank-w@public-files.de> <20190107103640.GH21184@phenom.ffwll.local> <20190110200225.GN21184@phenom.ffwll.local> <1547176809.12054.11.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1547176809.12054.11.camel@mtksdaap41> X-Operating-System: Linux phenom 4.18.0-2-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190111_012047_933045_D5D1F838 X-CRM114-Status: GOOD ( 27.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philipp Zabel , Frank Wunderlich , David Airlie , Alexander Ryabchenko , Linux Kernel Mailing List , dri-devel , "moderated list:ARM/Mediatek SoC support" , Daniel Vetter , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 11, 2019 at 11:20:09AM +0800, CK Hu wrote: > Hi, Daniel: > > On Thu, 2019-01-10 at 21:02 +0100, Daniel Vetter wrote: > > On Thu, Jan 10, 2019 at 08:01:37PM +0100, Frank Wunderlich wrote: > > > Hi Daniel, > > > > > > > > Would be good to use the new generic fbdev emulation code here, for even > > > > > less code. Or at least know why this isn't possible to use for mtk (and > > > > > maybe address that in the core code). Hand-rolling fbdev code shouldn't be > > > > > needed anymore. > > > > > > > > Back on the mailing list, no private replies please: > > > > > > i don't wanted to spam all people with dumb questions ;) > > > > There's no dumb questions, only insufficient documentation :-) > > > > > > For examples please grep for drm_fbdev_generic_setup(). There's also a > > > > still in-flight series from Gerd Hoffmann to convert over bochs. That, > > > > plus all the kerneldoc linked from there should get you started. > > > > -Daniel > > > > > > this is one of google best founds if i search for drm_fbdev_generic_setup: > > > > > > https://lkml.org/lkml/2018/12/19/305 > > > > > > not very helpful... > > > > > > so i tried kernel-doc > > > > > > https://www.kernel.org/doc/html/latest/gpu/drm-kms-helpers.html?highlight=drm_fbdev_generic_setup#c.drm_fbdev_generic_setup > > > > > > which is nice function-reference but i've found no generic workflow > > > > > > as the posted driver is "only" a driver ported from kernel 4.4 by Alexander, i don't know if this new framework can be used and which parts need to be changed. I only try to bring his code Mainline.... > > > Maybe CK Hu can help here because driver is originally from him and he knows internals. Or maybe you can help here? > > > > > > i personally make my first steps as spare-time kernel-developer :) > > > > There's a ton of in-kernel users of that function already, I meant you can > > use those to serve as examples ... If those + the kerneldoc aren't > > good enough, then we need to improve them. > > -Daniel > > I've tried with drm_fbdev_generic_setup() and it works fine with simple > modification. The patch is > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -379,6 +380,7 @@ static void mtk_drm_kms_deinit(struct drm_device > *drm) > .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table, > .gem_prime_import_sg_table = mtk_gem_prime_import_sg_table, > .gem_prime_mmap = mtk_drm_gem_mmap_buf, > + .gem_prime_vmap = mtk_drm_gem_prime_vmap, > .ioctls = mtk_ioctls, > .num_ioctls = ARRAY_SIZE(mtk_ioctls), > .fops = &mtk_drm_fops, > @@ -416,6 +418,8 @@ static int mtk_drm_bind(struct device *dev) > if (ret < 0) > goto err_deinit; > > + drm_fbdev_generic_setup(drm, 32); > + > return 0; > > > But I implement .gem_prime_vmap with a workaround, > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > @@ -280,3 +280,8 @@ int mtk_gem_create_ioctl(struct drm_device *dev, > void *data, > mtk_drm_gem_free_object(&mtk_gem->base); > return ret; > } > + > +void *mtk_drm_gem_prime_vmap(struct drm_gem_object *obj) > +{ > + return (void *)1; > +} > > Current drm_fb_helper depends on drm_client to create fbdev. When > drm_client create drm_client_buffer, it need to vmap to get kernel > vaddr. But I think for fbdev, the vaddr is useless. Do you agree that I > temporarily implement .gem_prime_vmap in such way? The vmap is used by fbcon, without that fbdev won't really work I think. So I'm rather confused on what you tested ... Adding Noralf, he's the expert here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel