Re: [PATCH] bus: ts-nbus: remove bus driver without user - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	kernel <kernel@savoirfairelinux.com>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Jérôme OUFELLA" <jerome.oufella@savoirfairelinux.com>,
	"Sebastien Bourdelin" <sebastien.bourdelin@savoirfairelinux.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] bus: ts-nbus: remove bus driver without user
Date: Fri, 11 Jan 2019 16:04:41 +0100	[thread overview]
Message-ID: <20190111150441.rsmize5dudrmgu52@pengutronix.de> (raw)
In-Reply-To: <CACRpkdbYizVLtQxh8_ZXWC-d6+E-k0T6Zq67qRJ7ascFGWTXig@mail.gmail.com>

Hello,

On Fri, Jan 11, 2019 at 01:52:36PM +0100, Linus Walleij wrote:
> On Mon, Jan 7, 2019 at 8:46 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> 
> > Since the ts-nbus driver was introduced in 2017 it only saw some reworking
> > changes. There is no user in the tree, neither a machine that has this
> > bus nor a driver for a device on that bus. Also the email address of the
> > author doesn't exist any more.
> >
> > So remove this bus.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Sebastien added this bus and I was under the impression that he was
> using it, even if no config or DTS in the kernel seems to be using it.
> 
> IIRC it should land in this one:
> arch/arm/boot/dts/imx28-ts4600.dts
> 
> This was added over a year ago and not much happened since.
> 
> Sebastien what happened with this?
> (I hope his mail is not bouncing...)
> 
> This interestingly brings up the following question: we used to just
> grep the kernel for users of a certain driver, which will find e.g. board
> files even if there is currently no defconfig for the system.
> With device tree drivers these DTS files defining the use of the
> driver can be out-of-tree, sometimes (SunOS?) in the ROM of a
> machine, and not possible to check using grep.
> 
> We need some policy there, like preferably merge device trees
> upstream and add defconfigs so we have some indication that
> the driver is used and also get compiled in tests.

Ack. For now I'd say a statement from someone who uses this stuff about
this fact would be good enough. Given that some time ago I sent patches
for this driver and didn't get any feedback from an interested party[1]
I tried with that patch adding some more people from
savoirfairelinux.com ...

I suggest to give them some more time, and then drop this for 5.2 or so
if we don't hear anything.

Best regards
Uwe

[1] https://patchwork.kernel.org/patch/10657725/

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel