From: Rob Herring <robh@kernel.org>
To: David Summers <beagleboard@davidjohnsummers.uk>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
johan.hedberg@gmail.com, marcel@holtmann.org,
linux-bluetooth@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2] Description of the realtek bluetooth device tree hooks
Date: Fri, 11 Jan 2019 10:34:20 -0600 [thread overview]
Message-ID: <20190111163420.GA20311@bogus> (raw)
In-Reply-To: <20190103163538.6575-1-beagleboard@davidjohnsummers.uk>
On Thu, Jan 03, 2019 at 04:35:37PM +0000, David Summers wrote:
> This adds the desrciption file that describes the hooks for the
> realtek bluetooth serial devices, as needed to refer to the interface
> in the device tree.
Please follow conventions for patch subjects. 'git log --oneline
--no-merges -- path/to/file' usually gives a good clue. In this case,
something like:
dt-bindings: net: Add Realtek serial bluetooth binding
>
> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk>
> ---
> .../bindings/net/realtek-bluetooth-serial.txt | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth-serial.txt
>
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth-serial.txt b/Documentation/devicetree/bindings/net/realtek-bluetooth-serial.txt
> new file mode 100644
> index 000000000000..0aabca1fc002
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth-serial.txt
> @@ -0,0 +1,28 @@
> +Realtek bluetooth devices connected via a UART
> +
> +- compatible: should be "realtek,<name>-bluetooth"
> + except for "realtek,trl8761atv" - which only has a serial bluetooth connection
> + "realtek,rtl8723as-bluetooth"
> + "realtek,rtl8723bs-bluetooth"
> + "realtek,rtl8723ds-bluetooth"
> + "realtek,rtl8761atv"
> + "realtek,rtl8821as-bluetooth"
> + "realtek,rtl8821cs-bluetooth"
> + "realtek,rtl8822bs-bluetooth"
Arguably, '-bluetooth' is not necessary as nothing else is attached to
the serial port. At least shorten it to '-bt'.
> +- These device are bluetooth devices, that connect via a uart
s/device/devices/
> +- all devices (except for rtl8761atv) are also wifi devices, this is connected
> + seperatly via sdio - and is not covered by this compatible node
Really, this should be up above the property list in a description of
the device(s).
> +- ideally these will be referenced in a device tree serial node via serdev
Not ideally, but it is only valid for this to be a child of a UART.
serdev is a kernel thing, and shouldn't be part of the binding doc.
> + http://events17.linuxfoundation.org/sites/events/files/slides/serdev-elce-2017-2.pdf
Useful, but again, not part of this binding.
There's no interrupts, GPIO control lines, power supplies, etc. for
these chips? The binding should be complete even if your platform
doesn't need these.
> +
> +Example:
> +
> +&uart0 {
> + status = "okay";
Don't show status in examples.
> + pinctrl-0 = <&uart0_xfer>, <&uart0_cts>;
> + bluetooth {
> + compatible = "realtek,rtl8723bs-bluetooth";
> + };
Mixed tabs and spaces. Use tabs.
> +};
> +
> +this ensures that the bluetooth device is tied to the correct uart
> --
> beagleboard@davidjohnsummers.uk
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 11:55 [PATCH] bluetooth: realtek: devicetree: Add device tree description to bluetooth rtl drivers David Summers
2018-12-29 16:51 ` David Summers
2018-12-30 10:25 ` Marcel Holtmann
2019-01-03 16:35 ` [PATCHv2] Description of the realtek bluetooth device tree hooks David Summers
2019-01-03 16:35 ` [PATCHv2] Patch to add the realtek bluetooth device tree refs to the code David Summers
2019-01-18 10:57 ` Marcel Holtmann
2019-01-19 13:18 ` beagleboard
2019-01-11 16:34 ` Rob Herring [this message]
2019-01-12 15:00 ` [PATCHv2] Description of the realtek bluetooth device tree hooks David Summers
2019-01-15 19:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111163420.GA20311@bogus \
--to=robh@kernel.org \
--cc=beagleboard@davidjohnsummers.uk \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).