Linux-ARM-Kernel Archive on lore.kernel.org
 help / Atom feed
* [PATCH] ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3
@ 2019-01-12  1:15 Shawn Guo
  2019-01-12 21:10 ` Lukasz Majewski
  0 siblings, 1 reply; 2+ messages in thread
From: Shawn Guo @ 2019-01-12  1:15 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: devicetree, Rob Herring, Shawn Guo, Lukasz Majewski

The dspi3 is used as slave controller on vf610-bk4, and the default
'#address-cells = <1>;' setting in vfxxx.dtsi causes the following DTC
warning.

  DTC     arch/arm/boot/dts/vf610-bk4.dtb
../arch/arm/boot/dts/vfxxx.dtsi:550.24-563.6: Warning (spi_bus_bridge): /soc/aips-bus@40080000/spi@400ad000: incorrect #address-cells for SPI bus
  also defined at ../arch/arm/boot/dts/vf610-bk4.dts:107.8-119.3
arch/arm/boot/dts/vf610-bk4.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'

For spi device used as slave controller, '#address-cells' should be 0.
Let's overwrite the property in vf610-bk4.dts to fix the warning.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---
 arch/arm/boot/dts/vf610-bk4.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/vf610-bk4.dts b/arch/arm/boot/dts/vf610-bk4.dts
index 689c8930dce3..b08d561d6748 100644
--- a/arch/arm/boot/dts/vf610-bk4.dts
+++ b/arch/arm/boot/dts/vf610-bk4.dts
@@ -110,11 +110,11 @@
 	bus-num = <3>;
 	status = "okay";
 	spi-slave;
+	#address-cells = <0>;
 
-	slave@0 {
+	slave {
 		compatible = "lwn,bk4";
 		spi-max-frequency = <30000000>;
-		reg = <0>;
 	};
 };
 
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3
  2019-01-12  1:15 [PATCH] ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3 Shawn Guo
@ 2019-01-12 21:10 ` Lukasz Majewski
  0 siblings, 0 replies; 2+ messages in thread
From: Lukasz Majewski @ 2019-01-12 21:10 UTC (permalink / raw)
  To: Shawn Guo; +Cc: devicetree, Rob Herring, linux-arm-kernel

[-- Attachment #1.1: Type: text/plain, Size: 1704 bytes --]

Hi Shawn,

> The dspi3 is used as slave controller on vf610-bk4, and the default
> '#address-cells = <1>;' setting in vfxxx.dtsi causes the following DTC
> warning.
> 
>   DTC     arch/arm/boot/dts/vf610-bk4.dtb
> ../arch/arm/boot/dts/vfxxx.dtsi:550.24-563.6: Warning
> (spi_bus_bridge): /soc/aips-bus@40080000/spi@400ad000: incorrect
> #address-cells for SPI bus also defined
> at ../arch/arm/boot/dts/vf610-bk4.dts:107.8-119.3
> arch/arm/boot/dts/vf610-bk4.dtb: Warning (spi_bus_reg): Failed
> prerequisite 'spi_bus_bridge'
> 
> For spi device used as slave controller, '#address-cells' should be 0.
> Let's overwrite the property in vf610-bk4.dts to fix the warning.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
>  arch/arm/boot/dts/vf610-bk4.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/vf610-bk4.dts
> b/arch/arm/boot/dts/vf610-bk4.dts index 689c8930dce3..b08d561d6748
> 100644 --- a/arch/arm/boot/dts/vf610-bk4.dts
> +++ b/arch/arm/boot/dts/vf610-bk4.dts
> @@ -110,11 +110,11 @@
>  	bus-num = <3>;
>  	status = "okay";
>  	spi-slave;
> +	#address-cells = <0>;
>  
> -	slave@0 {
> +	slave {
>  		compatible = "lwn,bk4";
>  		spi-max-frequency = <30000000>;
> -		reg = <0>;
>  	};
>  };
>  

Thanks for fixing this problem,

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-12  1:15 [PATCH] ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3 Shawn Guo
2019-01-12 21:10 ` Lukasz Majewski

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox