From: Lukasz Majewski <lukma@denx.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3
Date: Sat, 12 Jan 2019 22:10:40 +0100 [thread overview]
Message-ID: <20190112221040.5a5e85ee@jawa> (raw)
In-Reply-To: <20190112011514.8527-1-shawnguo@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1704 bytes --]
Hi Shawn,
> The dspi3 is used as slave controller on vf610-bk4, and the default
> '#address-cells = <1>;' setting in vfxxx.dtsi causes the following DTC
> warning.
>
> DTC arch/arm/boot/dts/vf610-bk4.dtb
> ../arch/arm/boot/dts/vfxxx.dtsi:550.24-563.6: Warning
> (spi_bus_bridge): /soc/aips-bus@40080000/spi@400ad000: incorrect
> #address-cells for SPI bus also defined
> at ../arch/arm/boot/dts/vf610-bk4.dts:107.8-119.3
> arch/arm/boot/dts/vf610-bk4.dtb: Warning (spi_bus_reg): Failed
> prerequisite 'spi_bus_bridge'
>
> For spi device used as slave controller, '#address-cells' should be 0.
> Let's overwrite the property in vf610-bk4.dts to fix the warning.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
> arch/arm/boot/dts/vf610-bk4.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610-bk4.dts
> b/arch/arm/boot/dts/vf610-bk4.dts index 689c8930dce3..b08d561d6748
> 100644 --- a/arch/arm/boot/dts/vf610-bk4.dts
> +++ b/arch/arm/boot/dts/vf610-bk4.dts
> @@ -110,11 +110,11 @@
> bus-num = <3>;
> status = "okay";
> spi-slave;
> + #address-cells = <0>;
>
> - slave@0 {
> + slave {
> compatible = "lwn,bk4";
> spi-max-frequency = <30000000>;
> - reg = <0>;
> };
> };
>
Thanks for fixing this problem,
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-12 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 1:15 [PATCH] ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3 Shawn Guo
2019-01-12 21:10 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112221040.5a5e85ee@jawa \
--to=lukma@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).