From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CC1C43387 for ; Wed, 16 Jan 2019 15:39:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90D48206C2 for ; Wed, 16 Jan 2019 15:39:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sj8KlGZ7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oaIuu4SI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90D48206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZD+mjg6g155HxTCF2hBcWrEJOxsVcbqwOAZAEvCCH8s=; b=Sj8KlGZ7Dzx91z ORme9n0CdOmzf5GbtN4a3LT5lmqPcN+t62KKUoE9W+KFOe7qX76rY0Sxm2Wrm1+nJiiEx86GuL7Nz DBqaepdyXPSSSw1+X2yu6JmWgU69r+jVrAZXLfF1iLOnqcTcVZ+9SSZYm6aN9AXY1F00/wuAnf+wZ ibpnuU85y4Vgi4/9C6Lzk2FPZT5PnSyHcWqrsSkeJu3LU9LxXHmgXLus+tdr7PoYia58whu0VipzX TK67WNEJoxBS8V4EsXMkE2PwHtw+tsztYOvCGWXa7napv9ZidzFSGu3Oz04fR6yyYP0Djgcog7KpE fW0Dv+v+A2hHzWoZYFpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjnII-0002wE-VF; Wed, 16 Jan 2019 15:39:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjnIF-0002vl-BX for linux-arm-kernel@lists.infradead.org; Wed, 16 Jan 2019 15:39:52 +0000 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E450B20675; Wed, 16 Jan 2019 15:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547653190; bh=PEudjCXimqi3wHtjBM4HU2HIpO6DWL+KSri+QLk5FTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oaIuu4SI+d3eQeefbWuwkH8qZ8F+SCf8kKML1HTGynqR+/A8OQsRCcW6QBnd+Se8G sOwfZHfT3MGaAV8IXSDxt4PPOjvqfRmY4S8AEEkYrfl3jZD/Nn9m2HOz+/LqzPrnWw 9zNe3c/h/wvGGakahDvrkEuXeXgMIfIKLg0VX45M= Date: Wed, 16 Jan 2019 16:39:48 +0100 From: Greg KH To: Mathieu Poirier Subject: Re: [PATCH 2/7] coresight: perf: Add "sinks" group to PMU directory Message-ID: <20190116153948.GC871@kroah.com> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> <20190115230742.13730-3-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190115230742.13730-3-mathieu.poirier@linaro.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190116_073951_442605_B2106B21 X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org, suzuki.poulose@arm.com, peterz@infradead.org, will.deacon@arm.com, heiko.carstens@de.ibm.com, adrian.hunter@intel.com, acme@kernel.org, ast@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, linux-arm-kernel@lists.infradead.org, hpa@zytor.com, schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de, jolsa@redhat.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 15, 2019 at 04:07:37PM -0700, Mathieu Poirier wrote: > Add a "sinks" directory entry so that users can see all the sinks > available in the system in a single place. Individual sink are added > as they are registered with the coresight bus. > > Signed-off-by: Mathieu Poirier > --- > .../hwtracing/coresight/coresight-etm-perf.c | 43 +++++++++++++++++++ > .../hwtracing/coresight/coresight-etm-perf.h | 1 + > drivers/hwtracing/coresight/coresight.c | 17 ++++++++ > 3 files changed, 61 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index f21eb28b6782..292bd409a68c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -43,8 +44,18 @@ static const struct attribute_group etm_pmu_format_group = { > .attrs = etm_config_formats_attr, > }; > > +static struct attribute *etm_config_sinks_attr[] = { > + NULL, > +}; > + > +static const struct attribute_group etm_pmu_sinks_group = { > + .name = "sinks", > + .attrs = etm_config_sinks_attr, > +}; > + > static const struct attribute_group *etm_pmu_attr_groups[] = { > &etm_pmu_format_group, > + &etm_pmu_sinks_group, > NULL, > }; > > @@ -479,6 +490,38 @@ int etm_perf_symlink(struct coresight_device *csdev, bool link) > return 0; > } > > +static ssize_t etm_perf_sink_name_show(struct device *dev, > + struct device_attribute *dattr, > + char *buf) > +{ > + /* See function coresight_sink_by_id() to know where this is used */ > + u32 hash = hashlen_hash(hashlen_string(NULL, dattr->attr.name)); > + > + return scnprintf(buf, PAGE_SIZE, "%x\n", hash); > +} > + > +int etm_perf_symlink_sink(struct coresight_device *csdev) > +{ > + struct device *pmu_dev = etm_pmu.dev; > + struct device *pdev = csdev->dev.parent; > + struct device_attribute *dev_attr; > + > + if (csdev->type != CORESIGHT_DEV_TYPE_SINK && > + csdev->type != CORESIGHT_DEV_TYPE_LINKSINK) > + return -EINVAL; > + > + if (!etm_perf_up) > + return -EPROBE_DEFER; > + > + dev_attr = kzalloc(sizeof(*dev_attr), GFP_KERNEL); > + dev_attr->attr.name = kstrdup(dev_name(pdev), GFP_KERNEL); > + dev_attr->attr.mode = 0444; > + dev_attr->show = etm_perf_sink_name_show; > + > + return sysfs_add_file_to_group(&pmu_dev->kobj, > + &dev_attr->attr, "sinks"); What is so odd about this call that you needed me to review this? And what happens if this call fails, do you leak memory? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel