From: Will Deacon <will.deacon@arm.com>
To: Kassey <kassey1216@gmail.com>
Cc: mark.rutland@arm.com, kassey@126.com, ard.biesheuvel@linaro.org,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
willy@infradead.org, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: arm64: copy_from_user access the last page of ddr has problem on 4.14 kernel
Date: Wed, 16 Jan 2019 16:48:18 +0000 [thread overview]
Message-ID: <20190116164817.GG1910@brain-police> (raw)
In-Reply-To: <CAKwPUowmzZ2BNi-RmJm3=ENrZ5sxPf1SeT+b9A9iHHSCUQQAUw@mail.gmail.com>
[I'm due to get on a long flight shortly, so I've added LAKML and a few
others to CC]
On Wed, Jan 16, 2019 at 11:25:15AM +0800, Kassey wrote:
> Hi, Will and team:
>
> we met a issue when copy_from_user to access the last page of DDR
> on 4.14 kenrel, below is the detail steps,
> can you help to suggest if there is know fix or debug something ?
>
> 1. we mmap ( in userspace) a region of phy address that is not
> continous but include the last page of ddr
>
> for example our ddr end is 0x200000000
> the last page is fall in below addr:
> 0x1fffff000 to 0x200000000
>
> 2. we using copy_from_user to copy these mmap address to kernel buffer
>
> 3. and we find everytime when trying to copy_from_user the last page
> in phy of ddr,
> the dst kernel buffer is looks overwrite by some same patten start
> with "mmap" in this last page ,but the src in the last page of ddr is
> still correct.
>
> is there any know issue for copy_from_user to accces the last page of
> phy ddr mmaped by userspace ?
Not that I'm aware of. Are you using defconfig and can you reproduce the
problem with mainline (e.g. v5.0-rc2)? What exactly do you mean by:
"the fst kernel buffer is looks overwrite by some same patten start with
"mmap""?
Does the copy_from_user fail (what does it return?) or does it succeed but
the data copied appears to be junk? Is it deterministic? Could you share an
example of what the corrupted data looks like, please?
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2019-01-16 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKwPUowmzZ2BNi-RmJm3=ENrZ5sxPf1SeT+b9A9iHHSCUQQAUw@mail.gmail.com>
2019-01-16 16:48 ` Will Deacon [this message]
2019-01-17 1:57 ` arm64: copy_from_user access the last page of ddr has problem on 4.14 kernel Kassey
2019-01-20 2:08 ` Will Deacon
2019-02-01 9:46 ` kassey
2019-02-11 11:34 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116164817.GG1910@brain-police \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=kassey1216@gmail.com \
--cc=kassey@126.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).