* [PATCH] arm64: perf: remove misleading comment
@ 2019-01-18 14:02 Andrew Murray
2019-01-18 15:51 ` Mark Rutland
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Murray @ 2019-01-18 14:02 UTC (permalink / raw)
To: Will Deacon, Mark Rutland, Catalin Marinas; +Cc: linux-arm-kernel
The comment for the armv8pmu_set_event_filter function suggests that
it only works for PMUv2 PMUs - this is incorrect.
Let's remove the incorrect comment.
Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
arch/arm64/kernel/perf_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 1620a37..4addb38 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -810,7 +810,7 @@ static void armv8pmu_clear_event_idx(struct pmu_hw_events *cpuc,
}
/*
- * Add an event filter to a given event. This will only work for PMUv2 PMUs.
+ * Add an event filter to a given event.
*/
static int armv8pmu_set_event_filter(struct hw_perf_event *event,
struct perf_event_attr *attr)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: perf: remove misleading comment
2019-01-18 14:02 [PATCH] arm64: perf: remove misleading comment Andrew Murray
@ 2019-01-18 15:51 ` Mark Rutland
0 siblings, 0 replies; 2+ messages in thread
From: Mark Rutland @ 2019-01-18 15:51 UTC (permalink / raw)
To: Andrew Murray; +Cc: Catalin Marinas, Will Deacon, linux-arm-kernel
On Fri, Jan 18, 2019 at 02:02:27PM +0000, Andrew Murray wrote:
> The comment for the armv8pmu_set_event_filter function suggests that
> it only works for PMUv2 PMUs - this is incorrect.
>
> Let's remove the incorrect comment.
>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
This was inherited from 32-bit, where PMUv1 didn't have mode exclusion.
Since we have PMUv3+ on arm64, I guess this is misleading.
FWIW: Acked-by: Mark Rutland <mark.rutland@arm.com>
... I expect Will to pick this up as part of perf/updates, assuming he's
also fine with it.
Thanks,
Mark.
> ---
> arch/arm64/kernel/perf_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 1620a37..4addb38 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -810,7 +810,7 @@ static void armv8pmu_clear_event_idx(struct pmu_hw_events *cpuc,
> }
>
> /*
> - * Add an event filter to a given event. This will only work for PMUv2 PMUs.
> + * Add an event filter to a given event.
> */
> static int armv8pmu_set_event_filter(struct hw_perf_event *event,
> struct perf_event_attr *attr)
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-18 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 14:02 [PATCH] arm64: perf: remove misleading comment Andrew Murray
2019-01-18 15:51 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).