From: Will Deacon <will.deacon@arm.com>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Michal Hocko <mhocko@suse.com>,
Levin Alexander <Alexander.Levin@microsoft.com>,
linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Huaisheng Ye <yehs1@lenovo.com>, Joerg Roedel <joro@8bytes.org>,
Matthew Wilcox <willy@infradead.org>,
hch@infradead.org, linux-arm-kernel@lists.infradead.org,
David Rientjes <rientjes@google.com>,
yingjoe.chen@mediatek.com, Vlastimil Babka <vbabka@suse.cz>,
Tomasz Figa <tfiga@google.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
hsinyi@chromium.org, Matthias Brugger <matthias.bgg@gmail.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Yong Wu <yong.wu@mediatek.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Pekka Enberg <penberg@kernel.org>,
iommu@lists.linux-foundation.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH v6 2/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging
Date: Sat, 19 Jan 2019 23:57:39 +0000 [thread overview]
Message-ID: <20190119235737.GE26876@brain-police> (raw)
In-Reply-To: <20181210011504.122604-3-drinkcat@chromium.org>
On Mon, Dec 10, 2018 at 09:15:03AM +0800, Nicolas Boichat wrote:
> IOMMUs using ARMv7 short-descriptor format require page tables
> (level 1 and 2) to be allocated within the first 4GB of RAM, even
> on 64-bit systems.
>
> For level 1/2 pages, ensure GFP_DMA32 is used if CONFIG_ZONE_DMA32
> is defined (e.g. on arm64 platforms).
>
> For level 2 pages, allocate a slab cache in SLAB_CACHE_DMA32. Note
> that we do not explicitly pass GFP_DMA[32] to kmem_cache_zalloc,
> as this is not strictly necessary, and would cause a warning
> in mm/sl*b.c, as we did not update GFP_SLAB_BUG_MASK.
>
> Also, print an error when the physical address does not fit in
> 32-bit, to make debugging easier in the future.
>
> Cc: stable@vger.kernel.org
> Fixes: ad67f5a6545f ("arm64: replace ZONE_DMA with ZONE_DMA32")
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Assuming you're routing all of this via akpm:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-19 23:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 1:15 [PATCH v6 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables Nicolas Boichat
2018-12-10 1:15 ` [PATCH v6 1/3] mm: Add support for kmem caches in DMA32 zone Nicolas Boichat
2018-12-10 1:15 ` [PATCH v6 2/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging Nicolas Boichat
2018-12-10 15:35 ` Will Deacon
2019-01-19 23:57 ` Will Deacon [this message]
2018-12-10 1:15 ` [PATCH v6 3/3] mm: Add /sys/kernel/slab/cache/cache_dma32 Nicolas Boichat
[not found] ` <CANMq1KAmFKpcxi49wJyfP4N01A80B2d-2RGY2Wrwg0BvaFxAxg@mail.gmail.com>
2019-01-11 10:21 ` [PATCH v6 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables Joerg Roedel
2019-01-22 22:51 ` Nicolas Boichat
2019-02-13 17:12 ` Vlastimil Babka
2019-02-25 0:23 ` Nicolas Boichat
2019-03-19 7:41 ` Nicolas Boichat
2019-03-19 17:56 ` Andrew Morton
2019-03-20 0:20 ` Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119235737.GE26876@brain-police \
--to=will.deacon@arm.com \
--cc=Alexander.Levin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=drinkcat@chromium.org \
--cc=hch@infradead.org \
--cc=hsinyi@chromium.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tfiga@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yehs1@lenovo.com \
--cc=yingjoe.chen@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).