From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A84CC282C0 for ; Wed, 23 Jan 2019 21:05:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49EDC21855 for ; Wed, 23 Jan 2019 21:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VayOvY/u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49EDC21855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=myk84/QdOAfoM5FmUTyQwKeng22gg2Z5DMem8EF1X7A=; b=VayOvY/uD0bTqa fojp2EcBwMnHFgFkrXZxMhfsksrhYsxnMrJscD8C8sj5yhAnpHrNxE9rjPTJJrF0X5y/SrriyxBt4 79fizOkRpIStUboSi+iyAE4uSEIaGFLLykJAwIvqaIJDo+KhlNaC5HK8e7friqw5ISfNxdpq9FeDh 44NFnkoxJ88EqlKxJZe09FEHmtEHNiJQ4ns1lxUg+o9za+p6L71WGWgJ4TzctAdLNqO1LHBBxbZNE ionz0YfaQlFZ8QLHD/xID5MH67gwQ2j+DYaoflExuBlRVOOWAemXCjLhLk5Q5HUrL6I+9rKnQm9dn C42SXfVwJwrLokf9NOlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmPhv-0000JO-V7; Wed, 23 Jan 2019 21:05:11 +0000 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmPht-00082z-8q; Wed, 23 Jan 2019 21:05:09 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8C3CE20F51B1C; Wed, 23 Jan 2019 22:05:07 +0100 (CET) Date: Wed, 23 Jan 2019 22:05:07 +0100 From: Peter Zijlstra To: Mathieu Poirier Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection Message-ID: <20190123210507.GA17767@hirez.programming.kicks-ass.net> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> <20190115230742.13730-4-mathieu.poirier@linaro.org> <20190123210333.GZ27931@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190123210333.GZ27931@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org, suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, heiko.carstens@de.ibm.com, adrian.hunter@intel.com, acme@kernel.org, ast@kernel.org, mingo@redhat.com, will.deacon@arm.com, hpa@zytor.com, schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de, jolsa@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 23, 2019 at 10:03:33PM +0100, Peter Zijlstra wrote: > On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote: > > + /* First get the selected sink from user space. */ > > + sink = coresight_get_sink_by_id(event->attr.config2); > > (I know there's a new version out, I'll go look there shortly) > > should this patch not also have something like: > > PMU_FORMAT_ATTR(sinkid, "config2:0-63"); n/m, I see it's already there. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel