Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/3] ARM: dts: lpc32xx: fix lpc32xx-key device node
@ 2019-01-26 14:29 Vladimir Zapolskiy
  2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Vladimir Zapolskiy @ 2019-01-26 14:29 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring
  Cc: devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

The changeset adds missing but required 'clocks' property and fixes
'interrupts' property of a keypad controller on NXP LPC32xx powered boards.

The devicetree binding documentation is updated accordingly.

Vladimir Zapolskiy (3):
  Input: lpc32xx-key - add clocks property and fix DT binding example
  ARM: dts: lpc32xx: add required clocks property to keypad device node
  ARM: dts: lpc32xx: reparent keypad controller to SIC1

 Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
 arch/arm/boot/dts/lpc32xx.dtsi                          | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
  2019-01-26 14:29 [PATCH 0/3] ARM: dts: lpc32xx: fix lpc32xx-key device node Vladimir Zapolskiy
@ 2019-01-26 14:29 ` Vladimir Zapolskiy
  2019-01-30 21:22   ` Vladimir Zapolskiy
  2019-02-23  0:41   ` Rob Herring
  2019-01-26 14:29 ` [PATCH 2/3] ARM: dts: lpc32xx: add required clocks property to keypad device node Vladimir Zapolskiy
  2019-01-26 14:29 ` [PATCH 3/3] ARM: dts: lpc32xx: reparent keypad controller to SIC1 Vladimir Zapolskiy
  2 siblings, 2 replies; 9+ messages in thread
From: Vladimir Zapolskiy @ 2019-01-26 14:29 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring
  Cc: devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

The keypad controller on NXP LPC32xx requires its clock gate to be open,
therefore add description of the requires 'clocks' property.

In addition adjust the example by adding description of required 'clocks'
property and by fixing 'interrupts' property.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
index bcf62f856358..2b075a080d30 100644
--- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
+++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
@@ -8,6 +8,7 @@ Required Properties:
 - reg: Physical base address of the controller and length of memory mapped
   region.
 - interrupts: The interrupt number to the cpu.
+- clocks: phandle to clock controller plus clock-specifier pair
 - nxp,debounce-delay-ms: Debounce delay in ms
 - nxp,scan-delay-ms: Repeated scan period in ms
 - linux,keymap: the key-code to be reported when the key is pressed
@@ -22,7 +23,9 @@ Example:
 	key@40050000 {
 		compatible = "nxp,lpc3220-key";
 		reg = <0x40050000 0x1000>;
-		interrupts = <54 0>;
+		clocks = <&clk LPC32XX_CLK_KEY>;
+		interrupt-parent = <&sic1>;
+		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
 		keypad,num-rows = <1>;
 		keypad,num-columns = <1>;
 		nxp,debounce-delay-ms = <3>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/3] ARM: dts: lpc32xx: add required clocks property to keypad device node
  2019-01-26 14:29 [PATCH 0/3] ARM: dts: lpc32xx: fix lpc32xx-key device node Vladimir Zapolskiy
  2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
@ 2019-01-26 14:29 ` Vladimir Zapolskiy
  2019-01-26 14:29 ` [PATCH 3/3] ARM: dts: lpc32xx: reparent keypad controller to SIC1 Vladimir Zapolskiy
  2 siblings, 0 replies; 9+ messages in thread
From: Vladimir Zapolskiy @ 2019-01-26 14:29 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring
  Cc: devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

NXP LPC32xx keypad controller requires a clock property to be defined.

The change fixes the driver initialization problem:

  lpc32xx_keys 40050000.key: failed to get clock
  lpc32xx_keys: probe of 40050000.key failed with error -2

Fixes: 93898eb775e5 ("arm: dts: lpc32xx: add clock properties to device nodes")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 arch/arm/boot/dts/lpc32xx.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi
index ed0d6fb20122..d4368eeff1b9 100644
--- a/arch/arm/boot/dts/lpc32xx.dtsi
+++ b/arch/arm/boot/dts/lpc32xx.dtsi
@@ -462,6 +462,7 @@
 			key: key@40050000 {
 				compatible = "nxp,lpc3220-key";
 				reg = <0x40050000 0x1000>;
+				clocks = <&clk LPC32XX_CLK_KEY>;
 				interrupts = <54 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 3/3] ARM: dts: lpc32xx: reparent keypad controller to SIC1
  2019-01-26 14:29 [PATCH 0/3] ARM: dts: lpc32xx: fix lpc32xx-key device node Vladimir Zapolskiy
  2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
  2019-01-26 14:29 ` [PATCH 2/3] ARM: dts: lpc32xx: add required clocks property to keypad device node Vladimir Zapolskiy
@ 2019-01-26 14:29 ` Vladimir Zapolskiy
  2 siblings, 0 replies; 9+ messages in thread
From: Vladimir Zapolskiy @ 2019-01-26 14:29 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring
  Cc: devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

After switching to a new interrupt controller scheme by separating SIC1
and SIC2 from MIC interrupt controller just one SoC keypad controller
was not taken into account, fix it now:

  WARNING: CPU: 0 PID: 1 at kernel/irq/irqdomain.c:524 irq_domain_associate+0x50/0x1b0
  error: hwirq 0x36 is too large for interrupt-controller@40008000
  ...
  lpc32xx_keys 40050000.key: failed to get platform irq
  lpc32xx_keys: probe of 40050000.key failed with error -22

Fixes: 9b8ad3fb81ae ("ARM: dts: lpc32xx: reparent SIC1 and SIC2 interrupts from MIC")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 arch/arm/boot/dts/lpc32xx.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi
index d4368eeff1b9..4f8f671c3343 100644
--- a/arch/arm/boot/dts/lpc32xx.dtsi
+++ b/arch/arm/boot/dts/lpc32xx.dtsi
@@ -463,7 +463,8 @@
 				compatible = "nxp,lpc3220-key";
 				reg = <0x40050000 0x1000>;
 				clocks = <&clk LPC32XX_CLK_KEY>;
-				interrupts = <54 IRQ_TYPE_LEVEL_HIGH>;
+				interrupt-parent = <&sic1>;
+				interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
  2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
@ 2019-01-30 21:22   ` Vladimir Zapolskiy
  2019-02-11 22:52     ` Dmitry Torokhov
  2019-02-23  0:41   ` Rob Herring
  1 sibling, 1 reply; 9+ messages in thread
From: Vladimir Zapolskiy @ 2019-01-30 21:22 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring
  Cc: devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

Hi Rob, Dmitry,

On 01/26/2019 04:29 PM, Vladimir Zapolskiy wrote:
> The keypad controller on NXP LPC32xx requires its clock gate to be open,
> therefore add description of the requires 'clocks' property.
> 
> In addition adjust the example by adding description of required 'clocks'
> property and by fixing 'interrupts' property.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> index bcf62f856358..2b075a080d30 100644
> --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> +++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> @@ -8,6 +8,7 @@ Required Properties:
>  - reg: Physical base address of the controller and length of memory mapped
>    region.
>  - interrupts: The interrupt number to the cpu.
> +- clocks: phandle to clock controller plus clock-specifier pair
>  - nxp,debounce-delay-ms: Debounce delay in ms
>  - nxp,scan-delay-ms: Repeated scan period in ms
>  - linux,keymap: the key-code to be reported when the key is pressed
> @@ -22,7 +23,9 @@ Example:
>  	key@40050000 {
>  		compatible = "nxp,lpc3220-key";
>  		reg = <0x40050000 0x1000>;
> -		interrupts = <54 0>;
> +		clocks = <&clk LPC32XX_CLK_KEY>;
> +		interrupt-parent = <&sic1>;
> +		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
>  		keypad,num-rows = <1>;
>  		keypad,num-columns = <1>;
>  		nxp,debounce-delay-ms = <3>;
> 

if you find time, please review/ack this change before 5.0-rc5 to give
me a chance to push it through ARM tree, thank you in advance.

--
Best wishes,
Vladimir

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
  2019-01-30 21:22   ` Vladimir Zapolskiy
@ 2019-02-11 22:52     ` Dmitry Torokhov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2019-02-11 22:52 UTC (permalink / raw)
  To: Vladimir Zapolskiy
  Cc: linux-input, devicetree, Rob Herring, linux-arm-kernel, Sylvain Lemieux

On Wed, Jan 30, 2019 at 11:22:40PM +0200, Vladimir Zapolskiy wrote:
> Hi Rob, Dmitry,
> 
> On 01/26/2019 04:29 PM, Vladimir Zapolskiy wrote:
> > The keypad controller on NXP LPC32xx requires its clock gate to be open,
> > therefore add description of the requires 'clocks' property.
> > 
> > In addition adjust the example by adding description of required 'clocks'
> > property and by fixing 'interrupts' property.
> > 
> > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> > ---
> >  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > index bcf62f856358..2b075a080d30 100644
> > --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > +++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > @@ -8,6 +8,7 @@ Required Properties:
> >  - reg: Physical base address of the controller and length of memory mapped
> >    region.
> >  - interrupts: The interrupt number to the cpu.
> > +- clocks: phandle to clock controller plus clock-specifier pair
> >  - nxp,debounce-delay-ms: Debounce delay in ms
> >  - nxp,scan-delay-ms: Repeated scan period in ms
> >  - linux,keymap: the key-code to be reported when the key is pressed
> > @@ -22,7 +23,9 @@ Example:
> >  	key@40050000 {
> >  		compatible = "nxp,lpc3220-key";
> >  		reg = <0x40050000 0x1000>;
> > -		interrupts = <54 0>;
> > +		clocks = <&clk LPC32XX_CLK_KEY>;
> > +		interrupt-parent = <&sic1>;
> > +		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> >  		keypad,num-rows = <1>;
> >  		keypad,num-columns = <1>;
> >  		nxp,debounce-delay-ms = <3>;
> > 
> 
> if you find time, please review/ack this change before 5.0-rc5 to give
> me a chance to push it through ARM tree, thank you in advance.

Sorry, I guess am a bit late, still, the binding is already used by the
driver so we should acknowledge it.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
  2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
  2019-01-30 21:22   ` Vladimir Zapolskiy
@ 2019-02-23  0:41   ` Rob Herring
  2019-02-23 11:38     ` Vladimir Zapolskiy
  1 sibling, 1 reply; 9+ messages in thread
From: Rob Herring @ 2019-02-23  0:41 UTC (permalink / raw)
  To: Vladimir Zapolskiy
  Cc: linux-input, devicetree, Dmitry Torokhov, linux-arm-kernel,
	Sylvain Lemieux

On Sat, 26 Jan 2019 16:29:19 +0200, Vladimir Zapolskiy wrote:
> The keypad controller on NXP LPC32xx requires its clock gate to be open,
> therefore add description of the requires 'clocks' property.
> 
> In addition adjust the example by adding description of required 'clocks'
> property and by fixing 'interrupts' property.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
  2019-02-23  0:41   ` Rob Herring
@ 2019-02-23 11:38     ` Vladimir Zapolskiy
  2019-04-03 17:53       ` Dmitry Torokhov
  0 siblings, 1 reply; 9+ messages in thread
From: Vladimir Zapolskiy @ 2019-02-23 11:38 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Rob Herring, devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

Hi Dmitry,

On 02/23/2019 02:41 AM, Rob Herring wrote:
> On Sat, 26 Jan 2019 16:29:19 +0200, Vladimir Zapolskiy wrote:
>> The keypad controller on NXP LPC32xx requires its clock gate to be open,
>> therefore add description of the requires 'clocks' property.
>>
>> In addition adjust the example by adding description of required 'clocks'
>> property and by fixing 'interrupts' property.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

can you please pull this documentation change through Linux input branch?

The two other dts changes have been already included into arm-soc.

--
Best wishes,
Vladimir

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
  2019-02-23 11:38     ` Vladimir Zapolskiy
@ 2019-04-03 17:53       ` Dmitry Torokhov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2019-04-03 17:53 UTC (permalink / raw)
  To: Vladimir Zapolskiy
  Cc: Rob Herring, devicetree, linux-input, linux-arm-kernel, Sylvain Lemieux

On Sat, Feb 23, 2019 at 01:38:01PM +0200, Vladimir Zapolskiy wrote:
> Hi Dmitry,
> 
> On 02/23/2019 02:41 AM, Rob Herring wrote:
> > On Sat, 26 Jan 2019 16:29:19 +0200, Vladimir Zapolskiy wrote:
> >> The keypad controller on NXP LPC32xx requires its clock gate to be open,
> >> therefore add description of the requires 'clocks' property.
> >>
> >> In addition adjust the example by adding description of required 'clocks'
> >> property and by fixing 'interrupts' property.
> >>
> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> >> ---
> >>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> 
> can you please pull this documentation change through Linux input branch?
> 
> The two other dts changes have been already included into arm-soc.

Applied, thank you.

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-26 14:29 [PATCH 0/3] ARM: dts: lpc32xx: fix lpc32xx-key device node Vladimir Zapolskiy
2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
2019-01-30 21:22   ` Vladimir Zapolskiy
2019-02-11 22:52     ` Dmitry Torokhov
2019-02-23  0:41   ` Rob Herring
2019-02-23 11:38     ` Vladimir Zapolskiy
2019-04-03 17:53       ` Dmitry Torokhov
2019-01-26 14:29 ` [PATCH 2/3] ARM: dts: lpc32xx: add required clocks property to keypad device node Vladimir Zapolskiy
2019-01-26 14:29 ` [PATCH 3/3] ARM: dts: lpc32xx: reparent keypad controller to SIC1 Vladimir Zapolskiy

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox