From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Gavin Schenk <g.schenk@eckelmann.de>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: Add devicetree for Eckelmann CI4x10
Date: Tue, 5 Feb 2019 09:18:25 +0100 [thread overview]
Message-ID: <20190205081825.rcoi2wx2bvxsyfjz@pengutronix.de> (raw)
In-Reply-To: <20190114013909.GE15371@dragon>
Hello,
On Mon, Jan 14, 2019 at 09:39:11AM +0800, Shawn Guo wrote:
> On Fri, Jan 11, 2019 at 05:49:35PM +0100, Uwe Kleine-König wrote:
> > + model = "Freescale i.MX6 DualLite Eckelmann CI 4X10 Board";
>
> It's not a board produced by Freescale, right?
Right, it's only the CPU that is produced by Freescale. So the implicit
associativity is: (Freescale i.MX6 DualLite) Eckelmann CI 4X10 Board :-)
I will make this "Eckelmann CI 4X10 Board".
> > + compatible = "eckelmann,imx6dl-ci4x10", "fsl,imx6dl";
>
> Document the compatible.
Where is this supposed to be documented? I found
Documentation/devicetree/bindings/arm/fsl.txt but that only seems to
list Freescale reference boards and e.g. wand,imx6q-wandboard isn't
there (or anywhere else).
> > + mram: mr25h256@0 {
> > + compatible = "everspin,mr25h256";
>
> Undocumented compatible.
Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt documents:
compatible : May include a device-specific string consisting of the
manufacturer and name of the chip. A list of supported chip
names follows.
"everspin" is a documented manufacturer and "mr25h256" is included in
the referenced list. So it's unclear to me what is missing here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-05 8:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 16:49 [PATCH 1/2] ARM: dts: Add devicetree for Eckelmann CI4x10 Uwe Kleine-König
2019-01-11 16:49 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Enable SIOX bus Uwe Kleine-König
2019-01-14 1:40 ` Shawn Guo
2019-02-05 6:17 ` Uwe Kleine-König
2019-02-11 1:28 ` Shawn Guo
2019-01-14 1:39 ` [PATCH 1/2] ARM: dts: Add devicetree for Eckelmann CI4x10 Shawn Guo
2019-02-05 8:18 ` Uwe Kleine-König [this message]
2019-02-08 9:33 ` [PATCH v2] " Uwe Kleine-König
2019-02-08 10:48 ` Fabio Estevam
2019-02-11 10:50 ` Uwe Kleine-König
2019-02-11 1:38 ` [PATCH 1/2] " Shawn Guo
2019-02-11 10:59 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205081825.rcoi2wx2bvxsyfjz@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fabio.estevam@nxp.com \
--cc=g.schenk@eckelmann.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).