* [PATCHv4] arm64: dts: allwinner: a64: teres-i: enable backlight
@ 2019-02-09 10:40 Harald Geyer
2019-02-12 8:34 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Harald Geyer @ 2019-02-09 10:40 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland
Cc: devicetree, linux-arm-kernel, Harald Geyer
Enable pwm and add a pretty standard backlight node.
The regulator is always on, but we include it anyway, because it is
required by the binding document.
Signed-off-by: Harald Geyer <harald@ccbib.org>
---
Changes since v3:
* Adjust brightness-levels to follow closer to an exponential law
* Change default value to have a similar brightness to what we had
before.
Changes since v2:
* Drop all the other stuff that got merged a year ago.
* Rebased on current sunxi/for-next branch
* Add power-supply property (just to conform to the binding)
* Use slightly different brightness-levels
Actually I tried omitting brightness-levels completely, as it is now
optional. However automatic calculation gives unreasonable results
(depending on the exact value of pwm period). A report has been sent
to the author of the code.
.../arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
index 7b7b14ba58e6..0ec46b969a75 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
@@ -21,6 +21,15 @@
serial0 = &uart0;
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 0 50000 0>;
+ power-supply = <®_dcdc1>;
+ brightness-levels = <0 5 7 10 14 20 28 40 56 80 112>;
+ default-brightness-level = <5>;
+ enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* PD23 */
+ };
+
chosen {
stdout-path = "serial0:115200n8";
@@ -131,6 +140,10 @@
status = "okay";
};
+&pwm {
+ status = "okay";
+};
+
&r_rsb {
status = "okay";
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv4] arm64: dts: allwinner: a64: teres-i: enable backlight
2019-02-09 10:40 [PATCHv4] arm64: dts: allwinner: a64: teres-i: enable backlight Harald Geyer
@ 2019-02-12 8:34 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2019-02-12 8:34 UTC (permalink / raw)
To: Harald Geyer
Cc: Mark Rutland, devicetree, Chen-Yu Tsai, Rob Herring, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]
On Sat, Feb 09, 2019 at 10:40:18AM +0000, Harald Geyer wrote:
> Enable pwm and add a pretty standard backlight node.
>
> The regulator is always on, but we include it anyway, because it is
> required by the binding document.
>
> Signed-off-by: Harald Geyer <harald@ccbib.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-12 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-09 10:40 [PATCHv4] arm64: dts: allwinner: a64: teres-i: enable backlight Harald Geyer
2019-02-12 8:34 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).