From: Mike Rapoport <rppt@linux.ibm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"logang@deltatee.com" <logang@deltatee.com>,
"rppt@linux.vnet.ibm.com" <rppt@linux.vnet.ibm.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"van.freenix@gmail.com" <van.freenix@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ghackmann@android.com" <ghackmann@android.com>
Subject: Re: [PATCH] arm64: use memblocks_present
Date: Sun, 10 Feb 2019 11:55:15 +0200 [thread overview]
Message-ID: <20190210095515.GA12403@rapoport-lnx> (raw)
In-Reply-To: <20190210093738.30923-1-peng.fan@nxp.com>
On Sun, Feb 10, 2019 at 09:28:43AM +0000, Peng Fan wrote:
> arm64_memory_present is doing same thing as memblocks_present, so
> let's use common code memblocks_present instead of platform
> specific arm64_memory_present.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/arm64/mm/init.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 7205a9085b4d..2302b4093a63 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -285,24 +285,6 @@ int pfn_valid(unsigned long pfn)
> }
> EXPORT_SYMBOL(pfn_valid);
>
> -#ifndef CONFIG_SPARSEMEM
> -static void __init arm64_memory_present(void)
> -{
> -}
> -#else
> -static void __init arm64_memory_present(void)
> -{
> - struct memblock_region *reg;
> -
> - for_each_memblock(memory, reg) {
> - int nid = memblock_get_region_node(reg);
> -
> - memory_present(nid, memblock_region_memory_base_pfn(reg),
> - memblock_region_memory_end_pfn(reg));
> - }
> -}
> -#endif
> -
> static phys_addr_t memory_limit = PHYS_ADDR_MAX;
>
> /*
> @@ -489,7 +471,7 @@ void __init bootmem_init(void)
> * Sparsemem tries to allocate bootmem in memory_present(), so must be
> * done after the fixed reservations.
> */
> - arm64_memory_present();
> + memblocks_present();
>
> sparse_init();
> zone_sizes_init(min, max);
> --
> 2.14.1
>
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-10 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 9:28 [PATCH] arm64: use memblocks_present Peng Fan
2019-02-10 9:55 ` Mike Rapoport [this message]
2019-02-11 11:06 ` Will Deacon
2019-02-11 12:20 ` Catalin Marinas
2019-02-11 12:26 ` Peng Fan
2019-02-11 17:26 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210095515.GA12403@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=f.fainelli@gmail.com \
--cc=ghackmann@android.com \
--cc=hannes@cmpxchg.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=peng.fan@nxp.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=stefan@agner.ch \
--cc=van.freenix@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).