Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org,
	Philipp Zabel <p.zabel@pengutronix.de>,
	robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
	c.hemp@phytec.de, fabio.estevam@nxp.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: pfla02: add ksz9031 clock skew values
Date: Mon, 11 Feb 2019 11:36:52 +0100
Message-ID: <20190211103652.hq77ftu56c34zeas@pengutronix.de> (raw)
In-Reply-To: <20190211023639.GG22487@dragon>

Hi Shawn,

On 19-02-11 10:36, Shawn Guo wrote:
> On Mon, Feb 04, 2019 at 04:29:56PM +0100, Marco Felsch wrote:
> > From: Philipp Zabel <p.zabel@pengutronix.de>
> > 
> > The pfla02 SoM has a Micrel KSZ9031RNX ethernet phy connected to the FEC,
> > which needs RX and TX clock skew settings to compensate for differences
> > in line length. The skew values are taken from barebox commit
> > 4c65c20f1071 ("ARM: pfla02: Set new ethernet phy tx timings"), which
> > is based on patches originally provided by Phytec:
> > 
> >     TX_CLK line is approx. 54mm longer than other TX lines which adds
> >     a delay of 0.36ns. RGMII need a delay of min. 1.0ns. This mean we
> >     have to add a delay of 0.64ns. We choose 0.78 to have a little gap.
> >     This can be done by setting GTX pad skew value to 11100
> >     Also add a delay for the RX delay lines, needed for the Duallite
> >     variant.  => Set register 2.8 (RGMII Clock Pad Skew) to 0x039F.
> > 
> > Cc: Christian Hemp <c.hemp@phytec.de>
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> Applied, thanks.

Thanks, for applying. Just for me, is something wrong with the first
patch?

Regards,
Marco

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 15:29 [PATCH 1/2] ARM: dts: pfla02: prepare storage devices to add paritions Marco Felsch
2019-02-04 15:29 ` [PATCH 2/2] ARM: dts: pfla02: add ksz9031 clock skew values Marco Felsch
2019-02-11  2:36   ` Shawn Guo
2019-02-11 10:36     ` Marco Felsch [this message]
2019-02-28  2:23       ` Shawn Guo
2019-02-12  7:12 ` [PATCH 1/2] ARM: dts: pfla02: prepare storage devices to add paritions Uwe Kleine-König
2019-02-28  2:26 ` Shawn Guo

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211103652.hq77ftu56c34zeas@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=c.hemp@phytec.de \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox