From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479ADC169C4 for ; Mon, 11 Feb 2019 12:18:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16D83218D8 for ; Mon, 11 Feb 2019 12:18:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H86LRe75" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16D83218D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OcjKvl7mgZbQ9JxLqfE1qPnjWt8Lw/RIWUfJMfwtMJQ=; b=H86LRe754XEYc3 ds0Aexh+kuaWDGo6VH7/ztu5AOetIqo2MR4fyK8yLw14rMg/zI94PkhrSpHufk4EEh2lyp5uF9Er6 G7ljQ2J/5CosIPw8IYUW28PGtl27Q01kZK50zLgDEL99fuibOeH11hUzPzGj1sBh99S6eqn/hGBIj J/IS+l4tkDDz5N8hL1KDkufzWG3AxjUyQ2bXFQNCp4iAK4huQkGQNLf0kRSF6PUOKfwijWzLOmvYs hl5UuZxK62f/y+KHd3AOu6fKzOH1CzTd3AzfGbb2xqzZGf7HY/C84CwXtXMlaS9lZxTneCToxvG1a oMfeTDFZPoj1OBRNSAmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtAXV-0003XF-A8; Mon, 11 Feb 2019 12:18:21 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtAXR-0003WW-Vh for linux-arm-kernel@lists.infradead.org; Mon, 11 Feb 2019 12:18:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC5CA80D; Mon, 11 Feb 2019 04:18:15 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98F3E3F557; Mon, 11 Feb 2019 04:18:14 -0800 (PST) Date: Mon, 11 Feb 2019 12:18:04 +0000 From: Lorenzo Pieralisi To: Trent Piepho Subject: Re: [PATCH v2 3/3] PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure Message-ID: <20190211121804.GA19106@e107981-ln.cambridge.arm.com> References: <20190205001721.18639-1-tpiepho@impinj.com> <20190205001721.18639-4-tpiepho@impinj.com> <20190207123132.GA21111@e107981-ln.cambridge.arm.com> <1549563351.3075.49.camel@impinj.com> <20190208101802.GA13009@e107981-ln.cambridge.arm.com> <1549649949.3075.79.camel@impinj.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1549649949.3075.79.camel@impinj.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_041818_026653_CB739EF3 X-CRM114-Status: GOOD ( 23.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-pci@vger.kernel.org" , "hongxing.zhu@nxp.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 08, 2019 at 06:19:10PM +0000, Trent Piepho wrote: > On Fri, 2019-02-08 at 10:18 +0000, Lorenzo Pieralisi wrote: > > On Thu, Feb 07, 2019 at 06:15:52PM +0000, Trent Piepho wrote: > > > On Thu, 2019-02-07 at 12:31 +0000, Lorenzo Pieralisi wrote: > > > > + /* De-assert DCC_FB_EN */ > > > > > + writel(PCIE_PHY_CMN_REG4_DCC_FB_EN, > > > > > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG4); > > > > > + /* Assert RX_EQS and RX_EQS_SEL */ > > > > > + writel(PCIE_PHY_CMN_REG24_RX_EQ_SEL > > > > > + | PCIE_PHY_CMN_REG24_RX_EQ, > > > > > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG24); > > > > > + /* Assert ATT_MODE */ > > > > > + writel(PCIE_PHY_CMN_REG26_ATT_MODE, > > > > > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG26); > > > > > + } else { > > > > > + dev_warn(dev, "DT lacks imx7d-pcie-phy, unable to apply ERR010728 workaround\n"); > > > > > > > > It is a nit but the warning log is not necessarily true ie you may not > > > > have a mapped address for other reasons as well. It is up to you but I > > > > would change the log message. > > > > > > True, but I hardly want to enumerate every possible failure point in a > > > log message. How about: > > > > > > Unable to apply ERR010728 workaround. DT lacks imx7d-pcie-phy? > > > > I would just log "Unable to apply ERR010728 workaround" but it is up > > to you. I can make the change myself with no need for reposting. > > I was following Lucas's comment on the v1 version: > > the user. It would be better to have something like "No access to > PHY registers, can't apply workaround for ERR010728." Maybe even > with a hint to update the DT. > > I think the pretty much the only way any of the errors conditions will > get hit, is when someone with an old DT runs a new kernel. So the hint > about the DT change might be actually useful to some users. > > But it's not a big deal so just change it to whatever when applying the > patch. Applied the series to pci/dwc for v5.1, please have a look to check if we are in agreement (slightly tweaked the log string), thanks. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel