From: Michal Hocko <mhocko@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
"robh@kernel.org" <robh@kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rppt@linux.vnet.ibm.com" <rppt@linux.vnet.ibm.com>,
"van.freenix@gmail.com" <van.freenix@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: use memblocks_present
Date: Mon, 11 Feb 2019 15:00:31 +0100 [thread overview]
Message-ID: <20190211140031.GD15609@dhcp22.suse.cz> (raw)
In-Reply-To: <20190211131602.3294-1-peng.fan@nxp.com>
On Mon 11-02-19 13:04:59, Peng Fan wrote:
> arm_memory_present is doing same thing as memblocks_present, so
> let's use common code memblocks_present instead of platform
> specific arm_memory_present.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> arch/arm/mm/init.c | 17 +----------------
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 478ea8b7db87..6c50dd407ba8 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -182,21 +182,6 @@ int pfn_valid(unsigned long pfn)
> EXPORT_SYMBOL(pfn_valid);
> #endif
>
> -#ifndef CONFIG_SPARSEMEM
> -static void __init arm_memory_present(void)
> -{
> -}
> -#else
> -static void __init arm_memory_present(void)
> -{
> - struct memblock_region *reg;
> -
> - for_each_memblock(memory, reg)
> - memory_present(0, memblock_region_memory_base_pfn(reg),
> - memblock_region_memory_end_pfn(reg));
> -}
> -#endif
> -
> static bool arm_memblock_steal_permitted = true;
>
> phys_addr_t __init arm_memblock_steal(phys_addr_t size, phys_addr_t align)
> @@ -292,7 +277,7 @@ void __init bootmem_init(void)
> * Sparsemem tries to allocate bootmem in memory_present(),
> * so must be done after the fixed reservations
> */
> - arm_memory_present();
> + memblocks_present();
>
> /*
> * sparse_init() needs the bootmem allocator up and running.
> --
> 2.16.4
--
Michal Hocko
SUSE Labs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-11 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 13:04 [PATCH] arm: use memblocks_present Peng Fan
2019-02-11 13:30 ` Mike Rapoport
2019-02-11 14:00 ` Michal Hocko [this message]
2019-02-12 17:27 ` Russell King - ARM Linux admin
2019-03-19 12:06 ` Peng Fan
2019-03-19 13:14 ` Fabio Estevam
2019-03-19 13:37 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211140031.GD15609@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=van.freenix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).