* [PATCH 02/15] ARM: dts: imx6qdl-cubox-i: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 03/15] ARM: dts: imx6qdl-hummingboard: " Uwe Kleine-König
` (13 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index e3be453d8a4a..532d2e3f8b6a 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -171,7 +171,7 @@
pinctrl_cubox_i_ir: cubox-i-ir {
fsl,pins = <
- MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x80000000
+ MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x0000b0b1
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 03/15] ARM: dts: imx6qdl-hummingboard: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 02/15] ARM: dts: imx6qdl-cubox-i: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: " Uwe Kleine-König
` (12 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 4 ++--
arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
index 2ffb21dd89f2..305dc4f11e3f 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
@@ -216,8 +216,8 @@
hummingboard {
pinctrl_hummingboard_flexcan1: hummingboard-flexcan1 {
fsl,pins = <
- MX6QDL_PAD_SD3_CLK__FLEXCAN1_RX 0x80000000
- MX6QDL_PAD_SD3_CMD__FLEXCAN1_TX 0x80000000
+ MX6QDL_PAD_SD3_CLK__FLEXCAN1_RX 0x0001b0b0
+ MX6QDL_PAD_SD3_CMD__FLEXCAN1_TX 0x0001b0b0
>;
};
diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index e4231331f04e..af5f0cfa518b 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -366,7 +366,7 @@
pinctrl_hummingboard2_gpio7_9: hummingboard2-gpio7_9 {
fsl,pins = <
- MX6QDL_PAD_SD4_CMD__GPIO7_IO09 0x80000000
+ MX6QDL_PAD_SD4_CMD__GPIO7_IO09 0x0001b0b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 02/15] ARM: dts: imx6qdl-cubox-i: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 03/15] ARM: dts: imx6qdl-hummingboard: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-12 8:15 ` Marco Felsch
2019-02-11 14:13 ` [PATCH 05/15] ARM: dts: imx6qdl-rex-*: " Uwe Kleine-König
` (11 subsequent siblings)
14 siblings, 1 reply; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults of the i.MX6dl are used owing to lack of other evidence. (They
differ from the i.MX6q defaults for GPIO_0 and KEY_ROW4.)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index 1b50b01e9bac..8e04ab7df2d7 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -211,11 +211,11 @@
imx6q-phytec-pfla02 {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x80000000
- MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
- MX6QDL_PAD_SD4_DAT1__GPIO2_IO09 0x80000000 /* PMIC interrupt */
- MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* Green LED */
- MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x80000000 /* Red LED */
+ MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x1b0b0
+ MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x1b0b0 /* SPI NOR chipselect */
+ MX6QDL_PAD_SD4_DAT1__GPIO2_IO09 0x1b0b0 /* PMIC interrupt */
+ MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x1b0b0 /* Green LED */
+ MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x1b0b1 /* Red LED */
>;
};
@@ -299,7 +299,7 @@
};
pinctrl_pcie: pciegrp {
- fsl,pins = <MX6QDL_PAD_DI0_PIN15__GPIO4_IO17 0x80000000>;
+ fsl,pins = <MX6QDL_PAD_DI0_PIN15__GPIO4_IO17 0x1b0b0>;
};
pinctrl_uart3: uart3grp {
@@ -320,7 +320,7 @@
pinctrl_usbh1: usbh1grp {
fsl,pins = <
- MX6QDL_PAD_GPIO_0__USB_H1_PWR 0x80000000
+ MX6QDL_PAD_GPIO_0__USB_H1_PWR 0x130b0
>;
};
@@ -328,7 +328,7 @@
fsl,pins = <
MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
MX6QDL_PAD_KEY_COL4__USB_OTG_OC 0x1b0b0
- MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x80000000
+ MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x130b0
>;
};
@@ -356,8 +356,8 @@
pinctrl_usdhc3_cdwp: usdhc3cdwp {
fsl,pins = <
- MX6QDL_PAD_ENET_RXD0__GPIO1_IO27 0x80000000
- MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
+ MX6QDL_PAD_ENET_RXD0__GPIO1_IO27 0x1b0b0
+ MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x1b0b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: Use explicit swpad values
2019-02-11 14:13 ` [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: " Uwe Kleine-König
@ 2019-02-12 8:15 ` Marco Felsch
2019-02-12 8:24 ` Uwe Kleine-König
0 siblings, 1 reply; 18+ messages in thread
From: Marco Felsch @ 2019-02-12 8:15 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Fabio Estevam, Shawn Guo, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
Hi Uwe,
On 19-02-11 15:13, Uwe Kleine-König wrote:
> Instead of relying on reset defaults or a bootloader to configure
> use explicit values for the swpad configuration. Here the reset
> defaults of the i.MX6dl are used owing to lack of other evidence. (They
> differ from the i.MX6q defaults for GPIO_0 and KEY_ROW4.)
Rely on the reset/bootloader values isn't that good at all. Since the
bootloader use case can be different. I've checked your patch against a
vanilla barebox (bootloader) which includes this devicetree. My test
setup was a imx6q pfla02 SoM and a pbab01 baseboard. Please look my
comment below.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 1b50b01e9bac..8e04ab7df2d7 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -211,11 +211,11 @@
> imx6q-phytec-pfla02 {
> pinctrl_hog: hoggrp {
> fsl,pins = <
> - MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x80000000
> - MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
> - MX6QDL_PAD_SD4_DAT1__GPIO2_IO09 0x80000000 /* PMIC interrupt */
> - MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* Green LED */
> - MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x80000000 /* Red LED */
> + MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x1b0b0
> + MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x1b0b0 /* SPI NOR chipselect */
> + MX6QDL_PAD_SD4_DAT1__GPIO2_IO09 0x1b0b0 /* PMIC interrupt */
> + MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x1b0b0 /* Green LED */
> + MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x1b0b1 /* Red LED */
Don't wanna nitpick, the MX6QDL_PAD_EIM_EB3__GPIO2_IO31 pad should be
configured to 0x1b0b0 too, but I don't know the default imx6dl
behaviour as you mentioned above. So I'm fine with the patch.
Acked-by: Marco Felsch <m.felsch@pengutronix.de>
> >;
> };
>
> @@ -299,7 +299,7 @@
> };
>
> pinctrl_pcie: pciegrp {
> - fsl,pins = <MX6QDL_PAD_DI0_PIN15__GPIO4_IO17 0x80000000>;
> + fsl,pins = <MX6QDL_PAD_DI0_PIN15__GPIO4_IO17 0x1b0b0>;
> };
>
> pinctrl_uart3: uart3grp {
> @@ -320,7 +320,7 @@
>
> pinctrl_usbh1: usbh1grp {
> fsl,pins = <
> - MX6QDL_PAD_GPIO_0__USB_H1_PWR 0x80000000
> + MX6QDL_PAD_GPIO_0__USB_H1_PWR 0x130b0
> >;
> };
>
> @@ -328,7 +328,7 @@
> fsl,pins = <
> MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> MX6QDL_PAD_KEY_COL4__USB_OTG_OC 0x1b0b0
> - MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x80000000
> + MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x130b0
> >;
> };
>
> @@ -356,8 +356,8 @@
>
> pinctrl_usdhc3_cdwp: usdhc3cdwp {
> fsl,pins = <
> - MX6QDL_PAD_ENET_RXD0__GPIO1_IO27 0x80000000
> - MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
> + MX6QDL_PAD_ENET_RXD0__GPIO1_IO27 0x1b0b0
> + MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x1b0b0
> >;
> };
>
> --
> 2.20.1
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: Use explicit swpad values
2019-02-12 8:15 ` Marco Felsch
@ 2019-02-12 8:24 ` Uwe Kleine-König
0 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-12 8:24 UTC (permalink / raw)
To: Marco Felsch
Cc: Fabio Estevam, Shawn Guo, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
On Tue, Feb 12, 2019 at 09:15:45AM +0100, Marco Felsch wrote:
> Hi Uwe,
>
> On 19-02-11 15:13, Uwe Kleine-König wrote:
> > Instead of relying on reset defaults or a bootloader to configure
> > use explicit values for the swpad configuration. Here the reset
> > defaults of the i.MX6dl are used owing to lack of other evidence. (They
> > differ from the i.MX6q defaults for GPIO_0 and KEY_ROW4.)
>
> Rely on the reset/bootloader values isn't that good at all. Since the
> bootloader use case can be different. I've checked your patch against a
> vanilla barebox (bootloader) which includes this devicetree. My test
> setup was a imx6q pfla02 SoM and a pbab01 baseboard. Please look my
> comment below.
>
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > index 1b50b01e9bac..8e04ab7df2d7 100644
> > --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > @@ -211,11 +211,11 @@
> > imx6q-phytec-pfla02 {
> > pinctrl_hog: hoggrp {
> > fsl,pins = <
> > - MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x80000000
> > - MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
> > - MX6QDL_PAD_SD4_DAT1__GPIO2_IO09 0x80000000 /* PMIC interrupt */
> > - MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* Green LED */
> > - MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x80000000 /* Red LED */
> > + MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x1b0b0
> > + MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x1b0b0 /* SPI NOR chipselect */
> > + MX6QDL_PAD_SD4_DAT1__GPIO2_IO09 0x1b0b0 /* PMIC interrupt */
> > + MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x1b0b0 /* Green LED */
> > + MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x1b0b1 /* Red LED */
>
> Don't wanna nitpick, the MX6QDL_PAD_EIM_EB3__GPIO2_IO31 pad should be
> configured to 0x1b0b0 too, but I don't know the default imx6dl
> behaviour as you mentioned above. So I'm fine with the patch.
This is a bug in my linter's data table. EIM_EB3 should use 0x1b0b0 on
both imx6q and imx6dl.
I will wait a bit more for feedback, and then probably respin with this
fixed. Thanks for your input.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 05/15] ARM: dts: imx6qdl-rex-*: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (2 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 06/15] ARM: dts: imx6qdl-sabreauto: " Uwe Kleine-König
` (10 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-rex.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-rex.dtsi b/arch/arm/boot/dts/imx6qdl-rex.dtsi
index 039e3b8306c4..e02836c45e1e 100644
--- a/arch/arm/boot/dts/imx6qdl-rex.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-rex.dtsi
@@ -237,7 +237,7 @@
pinctrl_led: ledgrp {
fsl,pins = <
/* user led */
- MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x80000000
+ MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x0001b0b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 06/15] ARM: dts: imx6qdl-sabreauto: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (3 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 05/15] ARM: dts: imx6qdl-rex-*: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 07/15] ARM: dts: imx6qdl-udoo: " Uwe Kleine-König
` (9 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index 1280de50a984..e3dab97dd168 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -466,9 +466,9 @@
imx6qdl-sabreauto {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_NANDF_CS2__GPIO6_IO15 0x80000000
- MX6QDL_PAD_SD2_DAT2__GPIO1_IO13 0x80000000
- MX6QDL_PAD_GPIO_18__SD3_VSELECT 0x17059
+ MX6QDL_PAD_NANDF_CS2__GPIO6_IO15 0x1b0b0
+ MX6QDL_PAD_SD2_DAT2__GPIO1_IO13 0x1b0b0
+ MX6QDL_PAD_GPIO_18__SD3_VSELECT 0x17059
>;
};
@@ -482,7 +482,7 @@
pinctrl_ecspi1_cs: ecspi1cs {
fsl,pins = <
- MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x80000000
+ MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x1b0b0
>;
};
@@ -554,7 +554,7 @@
pinctrl_gpio_leds: gpioledsgrp {
fsl,pins = <
- MX6QDL_PAD_DISP0_DAT21__GPIO5_IO15 0x80000000
+ MX6QDL_PAD_DISP0_DAT21__GPIO5_IO15 0x1b0b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 07/15] ARM: dts: imx6qdl-udoo: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (4 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 06/15] ARM: dts: imx6qdl-sabreauto: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 08/15] ARM: dts: imx6qdl-wandboard-*: " Uwe Kleine-König
` (8 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 776bfc77f89d..031f3d91c206 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -205,8 +205,8 @@
pinctrl_usbh: usbhgrp {
fsl,pins = <
- MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000
- MX6QDL_PAD_NANDF_CS2__CCM_CLKO2 0x130b0
+ MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0
+ MX6QDL_PAD_NANDF_CS2__CCM_CLKO2 0x130b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 08/15] ARM: dts: imx6qdl-wandboard-*: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (5 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 07/15] ARM: dts: imx6qdl-udoo: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 09/15] ARM: dts: imx6q-arm2: " Uwe Kleine-König
` (7 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi | 16 ++++++++--------
arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi | 16 ++++++++--------
arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi | 6 +++---
3 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi
index e781a45785ed..95661c39a519 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard-revb1.dtsi
@@ -12,17 +12,17 @@
imx6qdl-wandboard {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x80000000 /* uSDHC1 CD */
- MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x80000000 /* uSDHC3 CD */
+ MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 /* uSDHC1 CD */
+ MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x0b0b1 /* uSDHC3 CD */
MX6QDL_PAD_EIM_EB1__GPIO2_IO29 0x0f0b0 /* WL_REF_ON */
MX6QDL_PAD_EIM_A25__GPIO5_IO02 0x0f0b0 /* WL_RST_N */
MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x000b0 /* WL_REG_ON */
- MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 /* WL_HOST_WAKE */
- MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* WL_WAKE */
- MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x80000000 /* RGMII_nRST */
- MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x80000000 /* BT_ON */
- MX6QDL_PAD_EIM_DA14__GPIO3_IO14 0x80000000 /* BT_WAKE */
- MX6QDL_PAD_EIM_DA15__GPIO3_IO15 0x80000000 /* BT_HOST_WAKE */
+ MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x1b0b0 /* WL_HOST_WAKE */
+ MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x1b0b0 /* WL_WAKE */
+ MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x1b0b0 /* RGMII_nRST */
+ MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x0b0b1 /* BT_ON */
+ MX6QDL_PAD_EIM_DA14__GPIO3_IO14 0x0b0b1 /* BT_WAKE */
+ MX6QDL_PAD_EIM_DA15__GPIO3_IO15 0x0b0b1 /* BT_HOST_WAKE */
>;
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi
index 3874e74703f0..8abda47bc866 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard-revc1.dtsi
@@ -12,17 +12,17 @@
imx6qdl-wandboard {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x80000000 /* uSDHC1 CD */
- MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x80000000 /* uSDHC3 CD */
+ MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 /* uSDHC1 CD */
+ MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x0b0b1 /* uSDHC3 CD */
MX6QDL_PAD_CSI0_DAT14__GPIO6_IO00 0x0f0b0 /* WIFI_ON (reset, active low) */
MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x000b0 /* WL_REG_ON (unused) */
- MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 /* WL_HOST_WAKE, input */
+ MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x1b0b0 /* WL_HOST_WAKE, input */
MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x0f0b0 /* GPIO5_IO31 (Wifi Power Enable) */
- MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* WL_WAKE (unused) */
- MX6QDL_PAD_CSI0_VSYNC__GPIO5_IO21 0x80000000 /* BT_ON */
- MX6QDL_PAD_CSI0_DAT12__GPIO5_IO30 0x80000000 /* BT_WAKE */
- MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x80000000 /* BT_HOST_WAKE */
- MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x80000000 /* RGMII_nRST */
+ MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x1b0b0 /* WL_WAKE (unused) */
+ MX6QDL_PAD_CSI0_VSYNC__GPIO5_IO21 0x1b0b0 /* BT_ON */
+ MX6QDL_PAD_CSI0_DAT12__GPIO5_IO30 0x1b0b0 /* BT_WAKE */
+ MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b0 /* BT_HOST_WAKE */
+ MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x1b0b0 /* RGMII_nRST */
>;
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi
index 93909796885a..c94d247a2496 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi
@@ -142,9 +142,9 @@
imx6qdl-wandboard {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x80000000 /* USB Power Enable */
- MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x80000000 /* USDHC1 CD */
- MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x80000000 /* uSDHC3 CD */
+ MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x1b0b0 /* USB Power Enable */
+ MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 /* USDHC1 CD */
+ MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0x0b0b1 /* uSDHC3 CD */
MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x1f0b1 /* RGMII PHY reset */
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 09/15] ARM: dts: imx6q-arm2: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (6 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 08/15] ARM: dts: imx6qdl-wandboard-*: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 10/15] ARM: dts: imx6q-mccmon6: " Uwe Kleine-König
` (6 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6q-arm2.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-arm2.dts b/arch/arm/boot/dts/imx6q-arm2.dts
index baadcb7fe011..e93bbfb01cbd 100644
--- a/arch/arm/boot/dts/imx6q-arm2.dts
+++ b/arch/arm/boot/dts/imx6q-arm2.dts
@@ -72,7 +72,7 @@
imx6q-arm2 {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_EIM_D25__GPIO3_IO25 0x80000000
+ MX6QDL_PAD_EIM_D25__GPIO3_IO25 0x1b0b0
>;
};
@@ -158,8 +158,8 @@
pinctrl_usdhc3_cdwp: usdhc3cdwp {
fsl,pins = <
- MX6QDL_PAD_NANDF_CS0__GPIO6_IO11 0x80000000
- MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x80000000
+ MX6QDL_PAD_NANDF_CS0__GPIO6_IO11 0x1b0b0
+ MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x1b0b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 10/15] ARM: dts: imx6q-mccmon6: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (7 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 09/15] ARM: dts: imx6q-arm2: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 11/15] ARM: dts: imx6q-dmo-edmqmx6: " Uwe Kleine-König
` (5 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6q-mccmon6.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-mccmon6.dts b/arch/arm/boot/dts/imx6q-mccmon6.dts
index 74d9824e920b..b0fcf3e9ee50 100644
--- a/arch/arm/boot/dts/imx6q-mccmon6.dts
+++ b/arch/arm/boot/dts/imx6q-mccmon6.dts
@@ -314,13 +314,13 @@
pinctrl_ecspi3_cs: ecspi3csgrp {
fsl,pins = <
- MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000
+ MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x1b0b0
>;
};
pinctrl_ecspi3_flwp: ecspi3flwpgrp {
fsl,pins = <
- MX6QDL_PAD_DISP0_DAT6__GPIO4_IO27 0x80000000
+ MX6QDL_PAD_DISP0_DAT6__GPIO4_IO27 0x1b0b0
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 11/15] ARM: dts: imx6q-dmo-edmqmx6: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (8 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 10/15] ARM: dts: imx6q-mccmon6: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 12/15] ARM: dts: imx6qdl-aristainetos2: fix swpad values for reserved values Uwe Kleine-König
` (4 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index ee8c38eee03b..ca686d7c7405 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -301,8 +301,8 @@
imx6q-dmo-edmqmx6 {
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_EIM_A16__GPIO2_IO22 0x80000000
- MX6QDL_PAD_EIM_A17__GPIO2_IO21 0x80000000
+ MX6QDL_PAD_EIM_A16__GPIO2_IO22 0x0b0b1
+ MX6QDL_PAD_EIM_A17__GPIO2_IO21 0x0b0b1
>;
};
@@ -315,10 +315,10 @@
pinctrl_ecspi5: ecspi5rp-1 {
fsl,pins = <
- MX6QDL_PAD_SD1_DAT0__ECSPI5_MISO 0x80000000
- MX6QDL_PAD_SD1_CMD__ECSPI5_MOSI 0x80000000
- MX6QDL_PAD_SD1_CLK__ECSPI5_SCLK 0x80000000
- MX6QDL_PAD_SD2_DAT3__GPIO1_IO12 0x80000000
+ MX6QDL_PAD_SD1_DAT0__ECSPI5_MISO 0x1b0b0
+ MX6QDL_PAD_SD1_CMD__ECSPI5_MOSI 0x1b0b0
+ MX6QDL_PAD_SD1_CLK__ECSPI5_SCLK 0x1b0b0
+ MX6QDL_PAD_SD2_DAT3__GPIO1_IO12 0x1b0b0
>;
};
@@ -373,16 +373,16 @@
pinctrl_pfuze: pfuze100grp1 {
fsl,pins = <
- MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x80000000
+ MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b0
>;
};
pinctrl_stmpe1: stmpe1grp {
- fsl,pins = <MX6QDL_PAD_EIM_D30__GPIO3_IO30 0x80000000>;
+ fsl,pins = <MX6QDL_PAD_EIM_D30__GPIO3_IO30 0x1b0b0>;
};
pinctrl_stmpe2: stmpe2grp {
- fsl,pins = <MX6QDL_PAD_EIM_A25__GPIO5_IO02 0x80000000>;
+ fsl,pins = <MX6QDL_PAD_EIM_A25__GPIO5_IO02 0x0b0b1>;
};
pinctrl_uart1: uart1grp {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 12/15] ARM: dts: imx6qdl-aristainetos2: fix swpad values for reserved values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (9 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 11/15] ARM: dts: imx6q-dmo-edmqmx6: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 13/15] ARM: dts: imx6qdl-aristainetos: " Uwe Kleine-König
` (3 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Most of the RGMII_* pads don't have a writable SPEED field. The
respective read-only bits read as zero, so also write back a zero.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 24 ++++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi b/arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi
index 376750882ed3..da0125ef4ff1 100644
--- a/arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi
@@ -448,19 +448,19 @@
fsl,pins = <
MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0
MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0
- MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1b0b0
- MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1b0b0
- MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1b0b0
- MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1b0b0
- MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1b0b0
- MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1b0b0
+ MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1b030
+ MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1b030
+ MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1b030
+ MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1b030
+ MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1b030
+ MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1b030
MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1b0b0
- MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1b0b0
- MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1b0b0
- MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1b0b0
- MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1b0b0
- MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1b0b0
- MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
+ MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1b030
+ MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1b030
+ MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1b030
+ MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1b030
+ MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1b030
+ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b030
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 13/15] ARM: dts: imx6qdl-aristainetos: fix swpad values for reserved values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (10 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 12/15] ARM: dts: imx6qdl-aristainetos2: fix swpad values for reserved values Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 14/15] ARM: dts: imx6qdl-colibri: " Uwe Kleine-König
` (2 subsequent siblings)
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
The IOMUXC_SW_PAD_CTL_PAD_DI0_PIN04 register reads back as 0 when
0x20000 was written to it because bit 17 is readonly. So change the
swpad value accordingly to not write a 1 to this reserved bit.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-aristainetos.dtsi b/arch/arm/boot/dts/imx6qdl-aristainetos.dtsi
index ee4d0f84eeb2..4d2968850b75 100644
--- a/arch/arm/boot/dts/imx6qdl-aristainetos.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-aristainetos.dtsi
@@ -328,7 +328,7 @@
MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0x10
MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x10
MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x10
- MX6QDL_PAD_DI0_PIN4__GPIO4_IO20 0x20000
+ MX6QDL_PAD_DI0_PIN4__GPIO4_IO20 0x00
MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0x10
MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0x10
MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0x10
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 14/15] ARM: dts: imx6qdl-colibri: fix swpad values for reserved values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (11 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 13/15] ARM: dts: imx6qdl-aristainetos: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 15/15] ARM: dts: imx6qdl-ts7970: " Uwe Kleine-König
2019-02-28 2:47 ` [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Shawn Guo
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Bits 6 and 7 of the RGMII_* swpad registers are not writeable and read
as zero. So change the corresponding configuration values to write a
zero to these bits.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index 87e15e7cb32b..5cbf35293e41 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -555,7 +555,7 @@
pinctrl_mic_gnd: gpiomicgnd {
fsl,pins = <
/* Controls Mic GND, PU or '1' pull Mic GND to GND */
- MX6QDL_PAD_RGMII_TD1__GPIO6_IO21 0x1b0b0
+ MX6QDL_PAD_RGMII_TD1__GPIO6_IO21 0x1b030
>;
};
@@ -607,7 +607,7 @@
pinctrl_touch_int: gpiotouchintgrp {
fsl,pins = <
/* STMPE811 interrupt */
- MX6QDL_PAD_RGMII_TD0__GPIO6_IO20 0x1b0b0
+ MX6QDL_PAD_RGMII_TD0__GPIO6_IO20 0x1b030
>;
};
@@ -658,9 +658,9 @@
/* USBC_DET */
MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0
/* USBC_DET_EN */
- MX6QDL_PAD_RGMII_TX_CTL__GPIO6_IO26 0x0f058
+ MX6QDL_PAD_RGMII_TX_CTL__GPIO6_IO26 0x0f018
/* USBC_DET_OVERWRITE */
- MX6QDL_PAD_RGMII_RXC__GPIO6_IO30 0x0f058
+ MX6QDL_PAD_RGMII_RXC__GPIO6_IO30 0x0f018
>;
};
@@ -757,14 +757,14 @@
pinctrl_weim_rdnwr: weimrdnwr {
fsl,pins = <
MX6QDL_PAD_SD2_CLK__GPIO1_IO10 0x0040
- MX6QDL_PAD_RGMII_TD3__GPIO6_IO23 0x130b0
+ MX6QDL_PAD_RGMII_TD3__GPIO6_IO23 0x13030
>;
};
pinctrl_weim_npwe: weimnpwe {
fsl,pins = <
MX6QDL_PAD_SD2_DAT3__GPIO1_IO12 0x0040
- MX6QDL_PAD_RGMII_TD2__GPIO6_IO22 0x130b0
+ MX6QDL_PAD_RGMII_TD2__GPIO6_IO22 0x13030
>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 15/15] ARM: dts: imx6qdl-ts7970: fix swpad values for reserved values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (12 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 14/15] ARM: dts: imx6qdl-colibri: " Uwe Kleine-König
@ 2019-02-11 14:13 ` Uwe Kleine-König
2019-02-28 2:47 ` [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Shawn Guo
14 siblings, 0 replies; 18+ messages in thread
From: Uwe Kleine-König @ 2019-02-11 14:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
Most of the RGMII_* pads don't have a writable SPEED field. The
respective read-only bits read as zero, so also write back a zero.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-ts7970.dtsi | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
index f0be516dc28e..044d875e0b86 100644
--- a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
@@ -282,18 +282,18 @@
fsl,pins = <
MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0
MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0
- MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1b0b0
- MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1b0b0
- MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1b0b0
- MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1b0b0
- MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1b0b0
- MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1b0b0
- MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1b0b0
- MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1b0b0
- MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1b0b0
- MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1b0b0
- MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1b0b0
- MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
+ MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1b030
+ MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1b030
+ MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1b030
+ MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1b030
+ MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1b030
+ MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1b030
+ MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1b030
+ MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1b030
+ MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1b030
+ MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1b030
+ MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1b030
+ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b030
MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1b0b0
MX6QDL_PAD_ENET_TX_EN__GPIO1_IO28 0x1b088
MX6QDL_PAD_DI0_PIN4__GPIO4_IO20 0x1b088 /* ETH_PHY_RESET */
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values
2019-02-11 14:13 [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values Uwe Kleine-König
` (13 preceding siblings ...)
2019-02-11 14:13 ` [PATCH 15/15] ARM: dts: imx6qdl-ts7970: " Uwe Kleine-König
@ 2019-02-28 2:47 ` Shawn Guo
14 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2019-02-28 2:47 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
On Mon, Feb 11, 2019 at 03:13:19PM +0100, Uwe Kleine-König wrote:
> Instead of relying on reset defaults or a bootloader to configure
> use explicit values for the swpad configuration. Here the reset
> defaults are used owing to lack of other evidence.
As there is a pretty good chance that kernel works only because of the
configuration set up by bootloader, we are likely going to break things.
So I'm happy to take the patches only with board maintainers' ACK.
Shawn
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> index ebe7a8bddf04..208f94be1296 100644
> --- a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> @@ -58,9 +58,9 @@
> imx6qdl-dfi-fs700-m60 {
> pinctrl_hog: hoggrp {
> fsl,pins = <
> - MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
> - MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x80000000 /* PMIC irq */
> - MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x80000000 /* MAX11801 irq */
> + MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x0001b0b0
> + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x0001b0b0 /* PMIC irq */
> + MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x0001b0b0 /* MAX11801 irq */
> MX6QDL_PAD_NANDF_D5__GPIO2_IO05 0x000030b0 /* Backlight enable */
> >;
> };
> @@ -114,7 +114,7 @@
> MX6QDL_PAD_SD2_DAT1__SD2_DATA1 0x17059
> MX6QDL_PAD_SD2_DAT2__SD2_DATA2 0x17059
> MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x17059
> - MX6QDL_PAD_NANDF_D2__GPIO2_IO02 0x80000000 /* card detect */
> + MX6QDL_PAD_NANDF_D2__GPIO2_IO02 0x1b0b0 /* card detect */
> >;
> };
>
> @@ -149,7 +149,7 @@
> MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO 0x100b1
> MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI 0x100b1
> MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK 0x100b1
> - MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
> + MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x1b0b0 /* SPI NOR chipselect */
> >;
> };
> };
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread