Linux-ARM-Kernel Archive on
 help / color / Atom feed
From: "Gustavo A. R. Silva" <>
To: Lee Jones <>, Shawn Guo <>,
	Sascha Hauer <>,
	Pengutronix Kernel Team <>,
	Fabio Estevam <>,
	NXP Linux Team <>
Cc: Kees Cook <>,,,
	"Gustavo A. R. Silva" <>
Subject: [PATCH] mfd: mxs-lradc: Mark expected switch fall-through
Date: Mon, 11 Feb 2019 16:48:27 -0600
Message-ID: <20190211224827.GA28902@embeddedor> (raw)

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/mfd/mxs-lradc.c: In function ‘mxs_lradc_probe’:
drivers/mfd/mxs-lradc.c:179:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (lradc->soc == IMX28_LRADC) {
drivers/mfd/mxs-lradc.c:185:3: note: here

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable

Signed-off-by: Gustavo A. R. Silva <>
 drivers/mfd/mxs-lradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c
index 98e732a7ae96..a09a8d06302b 100644
--- a/drivers/mfd/mxs-lradc.c
+++ b/drivers/mfd/mxs-lradc.c
@@ -181,7 +181,7 @@ static int mxs_lradc_probe(struct platform_device *pdev)
-			/* fall through to an error message for i.MX23 */
+			/* fall through - to an error message for i.MX23 */
 				"Unsupported number of touchscreen wires (%d)\n"

linux-arm-kernel mailing list

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 22:48 Gustavo A. R. Silva [this message]
2019-02-14  9:16 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211224827.GA28902@embeddedor \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on

Archives are clonable:
	git clone --mirror linux-arm-kernel/git/0.git
	git clone --mirror linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ \
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone