Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Sylvain Lemieux <slemieux.tyco@gmail.com>
Subject: Re: [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
Date: Mon, 11 Feb 2019 14:52:29 -0800
Message-ID: <20190211225229.GF149505@dtor-ws> (raw)
In-Reply-To: <bd0b4bf2-dc14-2f9d-1350-25996a46760d@mleia.com>

On Wed, Jan 30, 2019 at 11:22:40PM +0200, Vladimir Zapolskiy wrote:
> Hi Rob, Dmitry,
> 
> On 01/26/2019 04:29 PM, Vladimir Zapolskiy wrote:
> > The keypad controller on NXP LPC32xx requires its clock gate to be open,
> > therefore add description of the requires 'clocks' property.
> > 
> > In addition adjust the example by adding description of required 'clocks'
> > property and by fixing 'interrupts' property.
> > 
> > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> > ---
> >  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > index bcf62f856358..2b075a080d30 100644
> > --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > +++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > @@ -8,6 +8,7 @@ Required Properties:
> >  - reg: Physical base address of the controller and length of memory mapped
> >    region.
> >  - interrupts: The interrupt number to the cpu.
> > +- clocks: phandle to clock controller plus clock-specifier pair
> >  - nxp,debounce-delay-ms: Debounce delay in ms
> >  - nxp,scan-delay-ms: Repeated scan period in ms
> >  - linux,keymap: the key-code to be reported when the key is pressed
> > @@ -22,7 +23,9 @@ Example:
> >  	key@40050000 {
> >  		compatible = "nxp,lpc3220-key";
> >  		reg = <0x40050000 0x1000>;
> > -		interrupts = <54 0>;
> > +		clocks = <&clk LPC32XX_CLK_KEY>;
> > +		interrupt-parent = <&sic1>;
> > +		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> >  		keypad,num-rows = <1>;
> >  		keypad,num-columns = <1>;
> >  		nxp,debounce-delay-ms = <3>;
> > 
> 
> if you find time, please review/ack this change before 5.0-rc5 to give
> me a chance to push it through ARM tree, thank you in advance.

Sorry, I guess am a bit late, still, the binding is already used by the
driver so we should acknowledge it.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26 14:29 [PATCH 0/3] ARM: dts: lpc32xx: fix lpc32xx-key device node Vladimir Zapolskiy
2019-01-26 14:29 ` [PATCH 1/3] Input: lpc32xx-key - add clocks property and fix DT binding example Vladimir Zapolskiy
2019-01-30 21:22   ` Vladimir Zapolskiy
2019-02-11 22:52     ` Dmitry Torokhov [this message]
2019-02-23  0:41   ` Rob Herring
2019-02-23 11:38     ` Vladimir Zapolskiy
2019-04-03 17:53       ` Dmitry Torokhov
2019-01-26 14:29 ` [PATCH 2/3] ARM: dts: lpc32xx: add required clocks property to keypad device node Vladimir Zapolskiy
2019-01-26 14:29 ` [PATCH 3/3] ARM: dts: lpc32xx: reparent keypad controller to SIC1 Vladimir Zapolskiy

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211225229.GF149505@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=slemieux.tyco@gmail.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git