From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.torgue@st.com, tduszyns@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] pwm: core: add consumer device link
Date: Tue, 12 Feb 2019 10:03:04 +0100 [thread overview]
Message-ID: <20190212090304.3j4iqj6sodtdvhr7@pengutronix.de> (raw)
In-Reply-To: <b9f1bb5c-36cd-f6e6-e6c6-a0257cf38b7e@st.com>
Hello Fabrice,
On Tue, Feb 12, 2019 at 09:31:37AM +0100, Fabrice Gasnier wrote:
> On 2/11/19 8:06 PM, Uwe Kleine-König wrote:
> > On Mon, Feb 11, 2019 at 05:12:02PM +0100, Fabrice Gasnier wrote:
> >> @@ -943,6 +950,8 @@ struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np,
> >> if (!IS_ERR(pwm)) {
> >> *ptr = pwm;
> >> devres_add(dev, ptr);
> >> + device_link_add(dev, pwm->chip->dev,
> >> + DL_FLAG_AUTOREMOVE_CONSUMER);
> >
> > IMHO it's surprising that devm_of_pwm_get() does more than of_pwm_get()
> > + devres stuff. I'd put device_link_add() into of_pwm_get().
>
> Hi Uwe,
>
> I also agree with this. But I think this implies modifying the API for
> of_pwm_get():
> /**
> * of_pwm_get() - request a PWM via the PWM framework
> + * @dev: device for PWM consumer
> * @np: device node to get the PWM from
> * @con_id: consumer name
>
> It seems there aren't much of_pwm_get() users currently.
> Does this look sensible ?
In my eyes this looks sensible, yes.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-12 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 16:11 [PATCH v2 0/3] Add PM support to STM32 LP Timer drivers Fabrice Gasnier
2019-02-11 16:12 ` [PATCH v2 1/3] dt-bindings: pwm-stm32-lp: document pinctrl sleep state Fabrice Gasnier
2019-02-11 16:12 ` [PATCH v2 2/3] pwm: stm32-lp: Add power management support Fabrice Gasnier
2019-02-11 16:12 ` [PATCH v2 3/3] pwm: core: add consumer device link Fabrice Gasnier
2019-02-11 19:06 ` Uwe Kleine-König
2019-02-12 8:31 ` Fabrice Gasnier
2019-02-12 9:03 ` Uwe Kleine-König [this message]
2019-02-13 10:51 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212090304.3j4iqj6sodtdvhr7@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tduszyns@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).