From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA12C43381 for ; Wed, 13 Feb 2019 21:41:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06BA6222A4 for ; Wed, 13 Feb 2019 21:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BJ9jaKW1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06BA6222A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:In-Reply-To:MIME-Version: References:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6SD3gbCFoAL1h85kjALYX5maIi6vDdWleHblK3X2jqw=; b=BJ9jaKW1ZRDaNX i4/oZPpmP52V3wHFrzUGZXwxb9rjjZLUZ1Ja/PHo1Z8K/4lQ+6OM1KrWV+XZMAq8YWCy0b0ORWYzz tJSoKHuy++gxGwygebbrzm3c0Uf1tNo3v482Uz/LIZ9JAIcSatvAyrbkM/GtQuWZocbozHM6Gtav6 mP3bx3UPD6TinbwNo/TKdjEgoKkxlycmLujEoN4g5kDjKNE6Z+3etat7ytWtcILtbSAI5DNcN9kLa zRGpPahJnBR4J4EhfVS/q54Wk9e0oBgoKHGSiAn3Y5Ux7x9/s8HeAIikaasfiIHZn5jBDB05b3UKb leeY/0K6eiOPa2i40lnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gu2Hx-0005iA-ML; Wed, 13 Feb 2019 21:41:53 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gu2HZ-0005K3-CB for linux-arm-kernel@lists.infradead.org; Wed, 13 Feb 2019 21:41:37 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1DLefRU121779 for ; Wed, 13 Feb 2019 16:41:28 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2qmu8er709-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Feb 2019 16:41:28 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Feb 2019 21:41:22 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 13 Feb 2019 21:41:19 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x1DLfIjG7471430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 13 Feb 2019 21:41:18 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 564F511C050; Wed, 13 Feb 2019 21:41:18 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4200211C058; Wed, 13 Feb 2019 21:41:17 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.207.163]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 13 Feb 2019 21:41:17 +0000 (GMT) Date: Wed, 13 Feb 2019 23:41:15 +0200 From: Mike Rapoport To: Christoph Hellwig Subject: Re: [PATCH 7/8] initramfs: proide a generic free_initrd_mem implementation References: <20190213174621.29297-1-hch@lst.de> <20190213174621.29297-8-hch@lst.de> <20190213184139.GC15270@rapoport-lnx> <20190213184448.GB20399@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190213184448.GB20399@lst.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19021321-0016-0000-0000-0000025622C8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19021321-0017-0000-0000-000032B04C09 Message-Id: <20190213214114.GE15270@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-13_12:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902130142 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_134129_787030_127F18C4 X-CRM114-Status: GOOD ( 30.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Russell King , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Andrew Morton , Guan Xuetao , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 13, 2019 at 07:44:48PM +0100, Christoph Hellwig wrote: > On Wed, Feb 13, 2019 at 08:41:40PM +0200, Mike Rapoport wrote: > > csky seems to open-code free_reserved_page with the only > > difference that it's also increments totalram_pages for the freed pages, > > which doesn't seem correct anyway... > > > > That said, I suppose arch/csky can be also added to the party. > > Yes, I noticed that. But I'd rather move it over manually in > another patch post rc1 or for the next merge window. Fair enough. > > > +void __weak free_initrd_mem(unsigned long start, unsigned long end) > > > +{ > > > + free_reserved_area((void *)start, (void *)end, -1, "initrd"); > > > > Some architectures have pr_info("Freeing initrd memory..."), I'd add it for > > the generic version as well. > > Well, if we think such a printk is useful it should probably be > moved to the caller in init/initramfs.c instead. I can include a > patch for that in the next iteration of the series. I found it useful during board bring ups, this gave some starting point when everything hangs and you are out to catch the lion in the desert. > > Another thing that I was thinking of is that x86 has all those memory > > protection calls in its free_initrd_mem, maybe it'd make sense to have them > > in the generic version as well? > > Maybe. But I'd rather keep it out of the initial series as it looks > a little more complicated. Having a single implementation > of free_initrd_mem would be great, though. Ok. BTW, the memblock_free() arm64 does, seems to be relevant for architectures with CONFIG_ARCH_DISCARD_MEMBLOCK=n. On powerpc the freed initrd region shows up in /sys/kernel/debug/memblock/reserved. -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel