From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1F7C43381 for ; Thu, 14 Feb 2019 16:29:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EC01222DA for ; Thu, 14 Feb 2019 16:29:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DyKXEVV7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EC01222DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AanQN4QqYluv5vOTtyahD1At9eKvsjZkxuApuD2N4pg=; b=DyKXEVV7D02kd2 2uOuOguyTe6ABQIxq713NlOACUCbTm6Tg6kiPaip49JlYeXsY6FxH7rs5DzI4K5ru/O7HFpLXoUaz erZSd6fvv0ZgyjlPkq05Na6oo5cFtS2FOzEDPhzkPsjkJjvWSE81AbfQW1GOIBltxFQOszvB/n+Zm wAHajRGvVCkvqfwwv1pdM2j6NS8nFaxBUQKD+qeD4fmPjt1KPJTJt76y3SZbNMVS8QS+pRJTK8d+v kjqvJjQe+v8VoJUmsLR1DYI9LqzgzPggEcivNkSE1n6ahlIt0lEFDkRFfLQHHV1/PV1Ga1/CoynBo 71qIw+KKIv9dIiouHWRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guJtM-0000Ml-AD; Thu, 14 Feb 2019 16:29:40 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guJtJ-0000M7-1P; Thu, 14 Feb 2019 16:29:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72B51EBD; Thu, 14 Feb 2019 08:29:36 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5ECE73F575; Thu, 14 Feb 2019 08:29:34 -0800 (PST) Date: Thu, 14 Feb 2019 16:29:28 +0000 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I Subject: Re: [PATCH v2 08/15] PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags Message-ID: <20190214162928.GA32523@e107981-ln.cambridge.arm.com> References: <20190114111513.21618-1-kishon@ti.com> <20190114111513.21618-9-kishon@ti.com> <20190211173723.GA31035@e107981-ln.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_082937_087635_140B689B X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Gustavo Pimentel , Shawn Lin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Alan Douglas , Jingoo Han , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 13, 2019 at 07:17:14PM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On 11/02/19 11:07 PM, Lorenzo Pieralisi wrote: > > On Mon, Jan 14, 2019 at 04:45:06PM +0530, Kishon Vijay Abraham I wrote: > >> pci_epf_alloc_space() sets the MEM TYPE flags to indicate a 32-bit > >> Base Address Register irrespective of the size. Fix it here to indicate > >> 64-bit BAR if the size is > 2GB. > >> > >> Signed-off-by: Kishon Vijay Abraham I > >> --- > >> drivers/pci/endpoint/pci-epf-core.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > > > > This looks like a fix and should me marked as such. Does it work > > as as standalone patch if it gets backported ? > > Yeah, it should work. But the current users doesn't allocate > 2GB and some > EPC drivers configure their registers based on size. So nothing is broken > without this patch as such. I suspect you mean 4GB (here and the commit log), right ? I am checking the commit logs, aiming at merging the patches. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel