From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0ECC43381 for ; Thu, 21 Feb 2019 08:28:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B7DF2148D for ; Thu, 21 Feb 2019 08:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jWnDFKpZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZPC4HrPd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B7DF2148D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7pOz6uoFndz7XIKo9WCAtUErYIorX6SHcYNNWRYy+6A=; b=jWnDFKpZVac5W+ 9L3jMm2fHWfb4DoIWNn+CDEna16v7W8QPkeXQB2hk4reaTd7ZTtG4ESp3b/DkDvsaYJzzgP7Qib3I dEb5KCTboZMMU8QMoEdXGFm+bbj48pmhGA4lzOVuJh1uzyYS9OwneeFsnu5k4DbM1akf6EVTY+sgh Qv/1jXhx6mAVdNFJHTzx0bB9ZwLJyaUt6UB0E6Ba5qbsnu0AamZntjs6KIMSVEfFnXcPgLD8cPwZf d1+k1C7cd5pTVzhZCsSD1728EibTWVHoflvbC/Tf80Q00vM3jsLPI+/qlMCkCP/ZfBn/4WZ25aLJY XJ/X4e8UI4T0PxuHUpyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwjhy-00071S-Ik; Thu, 21 Feb 2019 08:27:54 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwjhv-000715-9E for linux-arm-kernel@lists.infradead.org; Thu, 21 Feb 2019 08:27:53 +0000 Received: by mail-pf1-x442.google.com with SMTP id j5so8889315pfa.2 for ; Thu, 21 Feb 2019 00:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g5gN4Ti0gN+mczLgHhdKVrENWOTE09jCVWnpN/478RY=; b=ZPC4HrPdz+WY6AK9hfFZDhcbS7CxkySmfmXhtYXcQUQkKmLIAX2EVxo+MN8tnhNrYs H8pwsE6LR931tqfoTltTDeciYj8gMZmnFqHzpapNqLYGZtsqxLEsJG49B4dDFRzAXZAI wxfFc6d+QlYwVFgCJY5jvgbyWQTOwPVzSA/3Mb4QWd6TrCafEYiFPbnL6vzD2cxJ+LDi n6pTfn2IQTzSakuXkbroS7vy3VeVtWj0C8jFqGj8OMMn0t+BuQQGORqy7lmBXo6ae1wV pTPOR2prRD++s9vCn/842lnW2bGWhrohsW6tTp2vtR18jlTInv5qUO1oBuF8mTooMCM9 W6ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g5gN4Ti0gN+mczLgHhdKVrENWOTE09jCVWnpN/478RY=; b=Y4xOyN6TFyb5rHRE4ZRglBH0PA4FnyEKTao+B2tGjWh+rmFcW98Z7sgOP0hQeXHGUX oE1CYQnmoNj+fIJ+A61hUNLUA+jy7pcObExNYi2X04lGc6Gy9pbBeOErAkZi9a38LTMU gDWzoU4FGRKT39byo655Obbl4wDZtc+bQzwbgcx6JZe7Vp7xcgb2YXtgafAsTWANW7NC iPNikjSuTA/uRWvIJf+1ydjOoWSPbCAAu63/6Of+QgU3A3hRiu6AXbzYAbQ9NiTI3Zyp CsNwYSe9QHVUXcA/vUfRiAMYC7WJ5gMX9fnZ9G8siov4s/epGGFqjTepHmBl88NS2fws 2lYw== X-Gm-Message-State: AHQUAuZG0A4itq2iOuU1oo5MyCoioIsUprhcgZE6naXWtA+Rnz80fHKA P3ZvwC1I+Vzaug1LMRUiWOU= X-Google-Smtp-Source: AHgI3IZHNJbq9wAWv/DgJ7abDmOyMDM9OF93XsPXA58Q+3Eb1CGKbsQCgm4TJ1+6HhEgw1vRQJEhcA== X-Received: by 2002:a63:1766:: with SMTP id 38mr33480045pgx.204.1550737670185; Thu, 21 Feb 2019 00:27:50 -0800 (PST) Received: from icarus ([2001:268:c0a4:888c:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id f67sm29158116pff.29.2019.02.21.00.27.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 00:27:48 -0800 (PST) Date: Thu, 21 Feb 2019 17:28:21 +0900 From: William Breathitt Gray To: Patrick Havelange Subject: Re: [PATCH 5/8] iio/counter: add FlexTimer Module Quadrature decoder counter driver Message-ID: <20190221082758.GA3380@icarus> References: <20190218140321.19166-1-patrick.havelange@essensium.com> <20190218140321.19166-5-patrick.havelange@essensium.com> <20190220164154.00547a77@archlinux> <20190221010931.GA3471@icarus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190221010931.GA3471@icarus> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190221_002751_327666_89DDC204 X-CRM114-Status: GOOD ( 28.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lars-Peter Clausen , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Linus Walleij , Daniel Lezcano , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , Thierry Reding , Esben Haabendal , Peter Meerwald-Stadler , Hartmut Knaack , Thomas Gleixner , Shawn Guo , Jonathan Cameron , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 21, 2019 at 10:09:54AM +0900, William Breathitt Gray wrote: > On Wed, Feb 20, 2019 at 04:41:54PM +0000, Jonathan Cameron wrote: > > On Mon, 18 Feb 2019 15:03:18 +0100 > > Patrick Havelange wrote: > > > > > This driver exposes the counter for the quadrature decoder of the > > > FlexTimer Module, present in the LS1021A soc. > > > > > > Signed-off-by: Patrick Havelange > > > Reviewed-by: Esben Haabendal > > Given you cc'd William, I'm guessing you know about the counter > > subsystem effort. I would really rather not take any drivers > > into IIO if we have any hope of getting that upstreamed soon > > (which I personally think we do and should!). The reason is > > we end up having to maintain old ABI just because someone might be using > > it and it makes the drivers very messy. > > > > I'll review as is though as may be there are some elements that will > > cross over. > > > > Comments inline. William: Looks like a straight forward conversion if > > it makes sense to get this lined up as part of your initial submission? > > You have quite a few drivers so I wouldn't have said it needs to be there > > at the start, but good to have it soon after. > > > > Jonathan > > I agree, we should try to merge this as part of Counter subsystem > introduction rather than as another IIO Counter driver. As we determined > when adding support for the STM32 timers, the existing IIO Counter API > is fundamentally unsuitable for representing counter devices. So > regardless of how a new Counter API is merged, the existing IIO Counter > API must be deprecated. > > Patrick, I apologize for the confusion this has caused. Would you be > able to convert this driver to use the proposed Counter subsystem API > from this patchset that I believe you encountered before: > https://marc.info/?l=linux-arm-kernel&m=153229982404051 > > Although it was last updated in October, I believe you should be able to > rebase that Counter subsystem introduction patchset cleanly on top of > the IIO tree (if there are any merge conflicts send me an email). Take a > look at the generic-counter.rst file under the Documentation/driver-api/ > directory for an overview of the API; the counter drivers under the > drivers/counter/ directory also make good references. > > If you have any difficulties understanding the API, or any other > troubles, don't hesitate to ask. Hopefully, I've made the documentation > clear enough to make the conversion of this driver quick and easy -- and > if not, then it's something I need to fix, so let me know. :-) > > William Breathitt Gray Patrick, It looks like there were some minor conflicts with the v9 patchset, so I've rebased it on top of the latest iio tree testing branch and resolved the conflicts in my personal repository. Please pull from my personal repository at https://gitlab.com/vilhelmgray/iio.git and base your patches on top of the generic_counter_v10 branch. William Breathitt Gray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel