From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Hans de Goede <hdegoede@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Jens Axboe <axboe@kernel.dk>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-ide@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 5/5] arm64: dts: marvell: armada-cp110: Switch to per-port SATA interrupts
Date: Fri, 22 Feb 2019 16:29:12 +0100 [thread overview]
Message-ID: <20190222162912.39e17579@xps13> (raw)
In-Reply-To: <20190222151335.r27yreym5bhaoqaw@shell.armlinux.org.uk>
Hi Russell,
Thanks for the review,
Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote on Fri, 22
Feb 2019 15:13:35 +0000:
> On Fri, Feb 22, 2019 at 03:53:56PM +0100, Miquel Raynal wrote:
> > From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> >
> > There are two SATA ports per CP110. Each of them has a dedicated
> > interrupt. Describe the real hardware by adding two SATA ports to the
> > CP110 SATA node and enabling them in all the DTs including it
> > (7040-db/8040-db/8040-clearfog).
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > arch/arm64/boot/dts/marvell/armada-7040-db.dts | 7 ++++++-
> > arch/arm64/boot/dts/marvell/armada-8040-db.dts | 14 ++++++++++++--
> > arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 16 ++++++++++++++--
> > 3 files changed, 32 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> > index 412efdb46e7c..54c1c0ddc813 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> > +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> > @@ -194,7 +194,12 @@
> > };
> >
> > &cp0_sata0 {
> > - status = "okay";
> > + sata-port@0 {
>
> Don't these all need a reg = <N> to correspond with @N in the node name?
Yes a reg property is added to the sata-port(s) sub-nodes when they are
defined (here they are just enabled, see below).
>
> > + status = "okay";
> > + };
> > + sata-port@1 {
> > + status = "okay";
> > + };
> > };
> >
> > &cp0_usb3_0 {
> > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> > index 1bac437369a1..988cc7dc15d9 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> > +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> > @@ -147,7 +147,12 @@
> >
> > /* CON4 on CP0 expansion */
> > &cp0_sata0 {
> > - status = "okay";
> > + sata-port@0 {
> > + status = "okay";
> > + };
> > + sata-port@1 {
> > + status = "okay";
> > + };
> > };
> >
> > /* CON9 on CP0 expansion */
> > @@ -279,7 +284,12 @@
> >
> > /* CON4 on CP1 expansion */
> > &cp1_sata0 {
> > - status = "okay";
> > + sata-port@0 {
> > + status = "okay";
> > + };
> > + sata-port@1 {
> > + status = "okay";
> > + };
> > };
> >
> > /* CON9 on CP1 expansion */
> > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> > index b9d9f31e3ba1..f27edddcacd1 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> > @@ -292,10 +292,22 @@
> > "generic-ahci";
> > reg = <0x540000 0x30000>;
> > dma-coherent;
> > - interrupts = <107 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&CP110_LABEL(clk) 1 15>,
> > <&CP110_LABEL(clk) 1 16>;
> > - status = "disabled";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + sata-port@0 {
> > + reg = <0>;
Here ^
> > + interrupts = <109 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > + };
> > +
> > + sata-port@1 {
> > + reg = <1>;
> > + interrupts = <107 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > + };
> > };
> >
> > CP110_LABEL(xor0): xor@6a0000 {
> > --
> > 2.19.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-22 15:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 14:53 [PATCH 0/5] Enable per-port SATA interrupts and drop an hack in the IRQ subsystem Miquel Raynal
2019-02-22 14:53 ` [PATCH 1/5] ata: libahci: Ensure the host interrupt status bits are cleared Miquel Raynal
2019-02-22 14:53 ` [PATCH 2/5] ata: libahci_platform: Support per-port interrupts Miquel Raynal
2019-02-22 15:26 ` Hans de Goede
2019-02-22 15:31 ` Miquel Raynal
2019-02-22 15:52 ` Hans de Goede
2019-02-22 16:03 ` Miquel Raynal
2019-02-22 16:10 ` Hans de Goede
2019-02-25 18:08 ` Jens Axboe
2019-02-22 16:41 ` Marc Zyngier
2019-02-22 14:53 ` [PATCH 3/5] irqchip/irq-mvebu-icu: Move the double SATA ports interrupt hack Miquel Raynal
2019-02-23 19:19 ` Marc Zyngier
2019-02-25 15:22 ` Miquel Raynal
2019-02-22 14:53 ` [PATCH 4/5] arm64: dts: marvell: armada-8040-clearfog: Drop non-existent SATA port Miquel Raynal
2019-02-24 5:29 ` Baruch Siach
2019-02-25 10:58 ` Miquel Raynal
2019-02-25 12:15 ` Baruch Siach
2019-02-25 13:05 ` Russell King - ARM Linux admin
2019-02-27 5:16 ` Baruch Siach
2019-02-22 14:53 ` [PATCH 5/5] arm64: dts: marvell: armada-cp110: Switch to per-port SATA interrupts Miquel Raynal
2019-02-22 15:13 ` Russell King - ARM Linux admin
2019-02-22 15:29 ` Miquel Raynal [this message]
2019-02-23 19:21 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222162912.39e17579@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).