From: Mark Rutland <mark.rutland@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: yuzhao@google.com, Steve.Capper@arm.com, marc.zyngier@arm.com,
Catalin.Marinas@arm.com, suzuki.poulose@arm.com,
will.deacon@arm.com, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 5/6] arm64/mm: Enable page table page accounting for user space
Date: Mon, 25 Feb 2019 11:11:08 +0000 [thread overview]
Message-ID: <20190225111108.GD26236@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1551071039-20192-6-git-send-email-anshuman.khandual@arm.com>
On Mon, Feb 25, 2019 at 10:33:58AM +0530, Anshuman Khandual wrote:
> Page table pages created for user space processes must be accounted against
> their memory control groups if initialized. This just introduces a helper
> function pgtable_gfp_flags() which returns PGALLOC_GFP for all kernel page
> table page allocations but adds __GFP_ACCOUNT for user page table pages.
Can't we have pte_alloc_one_kernel() and pte_alloc_one() explicitly pass
the GFP flags down to a __pte_alloc_one() helper, and consistently use
pte_alloc_one_kernel() for kernel mappings?
That would seem less surprising than hiding that detail in another
function.
Thanks,
Mark.
>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> arch/arm64/include/asm/pgalloc.h | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/pgalloc.h b/arch/arm64/include/asm/pgalloc.h
> index 076764f66fb0..a02a4d1d967d 100644
> --- a/arch/arm64/include/asm/pgalloc.h
> +++ b/arch/arm64/include/asm/pgalloc.h
> @@ -100,12 +100,24 @@ pte_alloc_one_kernel(struct mm_struct *mm)
> return (pte_t *)pte_alloc_one_virt(mm);
> }
>
> +extern struct mm_struct efi_mm;
> +
> +static inline gfp_t pgtable_gfp_flags(struct mm_struct *mm)
> +{
> + if (unlikely((mm == &init_mm) || (mm == &efi_mm)))
> + return PGALLOC_GFP;
> + else
> + return PGALLOC_GFP | __GFP_ACCOUNT;
> +}
> +
> static inline pgtable_t
> pte_alloc_one(struct mm_struct *mm)
> {
> struct page *pte;
> + gfp_t gfp;
>
> - pte = alloc_pages(PGALLOC_GFP, 0);
> + gfp = pgtable_gfp_flags(mm);
> + pte = alloc_pages(gfp, 0);
> if (!pte)
> return NULL;
> if (!pgtable_page_ctor(pte)) {
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-25 11:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 5:03 [PATCH V2 0/6] arm64/mm: Enable accounting for page table pages Anshuman Khandual
2019-02-25 5:03 ` [PATCH V2 1/6] KVM: ARM: Remove pgtable standard functions from stage-2 page tables Anshuman Khandual
2019-02-25 11:00 ` Mark Rutland
2019-02-25 14:20 ` Anshuman Khandual
2019-02-25 15:49 ` Mark Rutland
2019-02-26 4:15 ` Anshuman Khandual
2019-02-26 8:51 ` Anshuman Khandual
2019-02-25 5:03 ` [PATCH V2 2/6] arm64/mm: Make pgd_pgtable_alloc() call pte_alloc_one() always Anshuman Khandual
2019-02-25 11:08 ` Mark Rutland
2019-02-25 14:41 ` Anshuman Khandual
2019-02-25 5:03 ` [PATCH V2 3/6] arm64/mm: Make all page table pages cycles through standard constructs Anshuman Khandual
2019-02-25 5:03 ` [PATCH V2 4/6] arm64/mm: Call pgtable_page_dtor() for both PMD and PUD page table pages Anshuman Khandual
2019-02-25 5:03 ` [PATCH V2 5/6] arm64/mm: Enable page table page accounting for user space Anshuman Khandual
2019-02-25 11:11 ` Mark Rutland [this message]
2019-02-25 14:49 ` Anshuman Khandual
2019-02-25 15:35 ` Mark Rutland
2019-02-26 5:06 ` Anshuman Khandual
2019-02-26 6:37 ` Anshuman Khandual
2019-02-25 5:03 ` [PATCH V2 6/6] arm64/mm: Enable ARCH_ENABLE_SPLIT_PMD_PTLOCK Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225111108.GD26236@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Steve.Capper@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).