From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF83C43381 for ; Mon, 25 Feb 2019 13:49:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30AC620842 for ; Mon, 25 Feb 2019 13:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N9TbsGIm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30AC620842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MbkhKQr2yXqg6yMTsHAGuKQFeR09TgZRfzjrakjEJeU=; b=N9TbsGImeEbP83 sTzg/g9hY9N0h8BNWN04gb+3jgzVUpYL3srx+cssaRvs8WpC6H7TWTRkGl+oOK8HOmJYvbWMhhjNY gRHaCDeWzNz1rbTI+ir2gwt2TykspjymNl5ThkeH/VkWC6u34oVSGDKiXOtIu38JRF6gS9sEM9M9H kQDDPmuRHqIsvar1UUGAQrJ2gaqsjGaHCNAFiq+Fabc9zUUz7FgYQ+GRbwMqLlAoy22MkvvHsBoez I38YNGRM98C06GFDIf7n7qk8M1bGQtWb5b5/Rt/VRHsJbmJJ8LVaRNyb6s8IiHI8i7X4NlrLrtnEM Aap2JSPvKuTOUiKs9c0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyGdF-0004p5-E8; Mon, 25 Feb 2019 13:49:21 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyGdB-0004oK-3E for linux-arm-kernel@lists.infradead.org; Mon, 25 Feb 2019 13:49:19 +0000 Received: by mail-ot1-f66.google.com with SMTP id i5so7813392oto.9 for ; Mon, 25 Feb 2019 05:49:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3u0FVYgMT9kAuuRbpn0Afc5ACW25VbT1LoW1egvooZA=; b=INKNkB3bo+Y0lPF4eUl39+tUaSIYPVpuUUte55ANyPccpzps7iJFVZhVr/ksdos0tv TnL1sXn/M6Aoct35kt1U/udon3sPX7eZyy2RTZckj6BxVo/lMorUiWnk9JiEupd2QBhd FXkY9JHckfydNs/ntlmb8Vph1KnpjTbck4KiaAmIsI6TPmsxHHLi1qm+3q41uq/f1U2S BMUesIg+7ziwxvfXZHZ9xlIT7J8NZjPiyZu/uFIm92HdUczxj4VqvWbZkBoSYyiPhj1c 0KtrwEb9QLbZ6h+v/974nrEIfe52Hl3kqoQzssePTpN3j2UV8ca27+kU91wqz9KPG7vD oGyA== X-Gm-Message-State: AHQUAua5sBm2/5l24MLNhX70f8QxVqov+fzWhkFRnAs31Rp2F4fdg1QW e2rX3kLawJwPJpKLSIgZ6w== X-Google-Smtp-Source: AHgI3IbXLoAK4YSGlf/1B6UdA6HMitLBYK78VSh/g/m3XlsuVjw+0yPxEU0xuFfO9visa0O1JjIU8Q== X-Received: by 2002:a05:6830:1258:: with SMTP id s24mr11905593otp.364.1551102555329; Mon, 25 Feb 2019 05:49:15 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i5sm4152714oia.46.2019.02.25.05.49.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 05:49:13 -0800 (PST) Date: Mon, 25 Feb 2019 07:49:13 -0600 From: Rob Herring To: Lukasz Luba Subject: Re: [PATCH 4/8] dt-bindings: devfreq: add DMC device description Message-ID: <20190225134913.GA32033@bogus> References: <1548703299-15806-1-git-send-email-l.luba@partner.samsung.com> <1548703299-15806-5-git-send-email-l.luba@partner.samsung.com> <79cd56c4-2415-7db1-be6f-73c03c0902bc@partner.samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <79cd56c4-2415-7db1-be6f-73c03c0902bc@partner.samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190225_054917_141923_527CEF1F X-CRM114-Status: GOOD ( 29.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , =?utf-8?Q?Bart=C5=82omiej_=C5=BBo=C5=82nierkiewicz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Chanwoo Choi , Kyungmin Park , myungjoo.ham@samsung.com, Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 29, 2019 at 05:02:49PM +0100, Lukasz Luba wrote: > Hi Krzysztof, > > On 1/29/19 3:47 PM, Krzysztof Kozlowski wrote: > > On Mon, 28 Jan 2019 at 20:21, Lukasz Luba wrote: > >> > >> The patch adds description for DT binding for a new Exynos5 Dynamic Memory > >> Controller device. > >> It also contains needed MAINTAINERS file updates. > >> > >> CC: MyungJoo Ham > >> CC: Kyungmin Park > >> CC: Chanwoo Choi > >> CC: Rob Herring > >> CC: Mark Rutland > >> CC: Kukjin Kim > >> CC: Krzysztof Kozlowski > >> CC: linux-pm@vger.kernel.org > >> CC: linux-samsung-soc@vger.kernel.org > >> CC: devicetree@vger.kernel.org > >> CC: linux-arm-kernel@lists.infradead.org > >> CC: linux-kernel@vger.kernel.org > >> Signed-off-by: Lukasz Luba > >> --- > >> .../devicetree/bindings/devfreq/exynos5-dmc.txt | 108 +++++++++++++++++++++ > >> MAINTAINERS | 7 ++ > >> 2 files changed, 115 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos5-dmc.txt > >> > >> diff --git a/Documentation/devicetree/bindings/devfreq/exynos5-dmc.txt b/Documentation/devicetree/bindings/devfreq/exynos5-dmc.txt > >> new file mode 100644 > >> index 0000000..914bd85 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/devfreq/exynos5-dmc.txt > >> @@ -0,0 +1,108 @@ > >> +* Exynos5 frequency and voltage scaling for Dynamic Memory Controller device > >> + > >> +The Samsung Exynos5 SoC has DMC (Dynamic Memory Controller) to which the DRAM > >> +memory chips are connected. The driver is to monitor the controller in runtime > >> +and switch frequency and voltage. To monitor the usage of the controller in > >> +runtime, the driver uses the PPMU (Platform Performance Monitoring Unit), which > >> +is able to measure the current load of the memory. > >> +When 'userspace' governor is used for the driver, an application is able to > >> +switch the DMC frequency. > >> + > >> +Required properties for DMC device for Exynos5422: > >> +- compatible: Should be "samsung,exynos5422-bus". > >> +- clock-names : the name of clock used by the bus, "bus". > >> +- clocks : phandles for clock specified in "clock-names" property. > >> +- devfreq-events : phandles for PPMU devices connected to this DMC. > >> + > >> +The example definition of a DMC and PPMU devices declared in DT is shown below: > >> + > >> + ppmu_dmc0_0: ppmu_dmc0_0@10d00000 { > >> + compatible = "samsung,exynos-ppmu"; > >> + reg = <0x10d00000 0x2000>; > >> + clocks = <&clock CLK_PCLK_PPMU_DREX0_0>; > >> + clock-names = "ppmu"; > >> + status = "okay"; > >> + events { > >> + ppmu_event_dmc0_0: ppmu-event3-dmc0_0 { > >> + event-name = "ppmu-event3-dmc0_0"; > >> + }; > >> + }; > >> + }; > >> + > >> + > >> + ppmu_dmc0_1: ppmu_dmc0_1@10d10000 { > >> + compatible = "samsung,exynos-ppmu"; > >> + reg = <0x10d10000 0x2000>; > >> + clocks = <&clock CLK_PCLK_PPMU_DREX0_1>; > >> + clock-names = "ppmu"; > >> + status = "okay"; > >> + events { > >> + ppmu_event_dmc0_1: ppmu-event3-dmc0_1 { > >> + event-name = "ppmu-event3-dmc0_1"; > >> + }; > >> + }; > >> + }; > >> + > >> + ppmu_dmc1_0: ppmu_dmc1_0@10d10000 { > >> + compatible = "samsung,exynos-ppmu"; > >> + reg = <0x10d60000 0x2000>; > >> + clocks = <&clock CLK_PCLK_PPMU_DREX1_0>; > >> + clock-names = "ppmu"; > >> + status = "okay"; > >> + events { > >> + ppmu_event_dmc1_0: ppmu-event3-dmc1_0 { > >> + event-name = "ppmu-event3-dmc1_0"; > >> + }; > >> + }; > >> + }; > >> + > >> + ppmu_dmc1_1: ppmu_dmc1_1@10d70000 { > >> + compatible = "samsung,exynos-ppmu"; > >> + reg = <0x10d70000 0x2000>; > >> + clocks = <&clock CLK_PCLK_PPMU_DREX1_1>; > >> + clock-names = "ppmu"; > >> + status = "okay"; > >> + events { > >> + ppmu_event_dmc1_1: ppmu-event3-dmc1_1 { > >> + event-name = "ppmu-event3-dmc1_1"; > >> + }; > >> + }; > >> + }; > >> + > >> + dmc: dmc@10c20000 { > >> + compatible = "samsung,exynos5422-dmc"; > >> + reg = <0x10c20000 0x10000>, <0x10c30000 0x10000>, > >> + <0x10030000 0x1000>, <0x10000000 0x1000>; > >> + clocks = <&clock CLK_FOUT_SPLL>, > >> + <&clock CLK_MOUT_SCLK_SPLL>, > >> + <&clock CLK_FF_DOUT_SPLL2>, > >> + <&clock CLK_FOUT_BPLL>, > >> + <&clock CLK_MOUT_BPLL>, > >> + <&clock CLK_SCLK_BPLL>, > >> + <&clock CLK_MOUT_MX_MSPLL_CCORE>, > >> + <&clock CLK_MOUT_MX_MSPLL_CCORE_PHY>, > >> + <&clock CLK_MOUT_MCLK_CDREX>, > >> + <&clock CLK_DOUT_CLK2X_PHY0>, > >> + <&clock CLK_CLKM_PHY0>, > >> + <&clock CLK_CLKM_PHY1> > >> + ; > > > > Join with previous line. > > > >> + clock-names = "fout_spll", > >> + "mout_sclk_spll", > >> + "ff_dout_spll2", > >> + "fout_bpll", > >> + "mout_bpll", > >> + "sclk_bpll", > >> + "mout_mx_mspll_ccore", > >> + "mout_mx_mspll_ccore_phy", > >> + "mout_mclk_cdrex", > >> + "dout_clk2x_phy0", > >> + "clkm_phy0", > >> + "clkm_phy1" > >> + ; > > > > Ditto. > OK, I will fix it. > > > >> + > >> + status = "okay"; > >> + devfreq-events = <&ppmu_dmc0_0>, <&ppmu_dmc0_1>, > >> + <&ppmu_dmc1_0>, <&ppmu_dmc1_1>; > >> + }; > >> + > >> + > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 9f64f8d..3581807 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -3310,6 +3310,13 @@ S: Maintained > >> F: drivers/devfreq/exynos-bus.c > >> F: Documentation/devicetree/bindings/devfreq/exynos-bus.txt > >> > >> +DMC FREQUENCY DRIVER FOR SAMSUNG EXYNOS5 > >> +M: Lukasz Luba > >> +L: linux-pm@vger.kernel.org > >> +L: linux-samsung-soc@vger.kernel.org > >> +S: Maintained > >> +F: Documentation/devicetree/bindings/devfreq/exynos5-dmc.txt > > > > Maintainers change should go with the next change, I think. It looks > > unusual to add an entry for driver... without the driver. > Thank you for the review. I will move the dt-bindings in the patch set > after the dmc driver file. Then the MAINTAINERS file will be updated > only by one entry. No, bindings should come first. Just move this hunk to the driver patch including the line here for the binding. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel